Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/859348/?format=api
{ "id": 859348, "url": "http://patchwork.ozlabs.org/api/patches/859348/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180111214601.4cyjpvmbsothnc23@mwanda/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180111214601.4cyjpvmbsothnc23@mwanda>", "list_archive_url": null, "date": "2018-01-11T21:46:01", "name": "ixgbe: Fix && vs || typo", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "80ab0d9c6dd237b49bf196844a812c266d9c61d3", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180111214601.4cyjpvmbsothnc23@mwanda/mbox/", "series": [ { "id": 22799, "url": "http://patchwork.ozlabs.org/api/series/22799/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=22799", "date": "2018-01-11T21:46:01", "name": "ixgbe: Fix && vs || typo", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/22799/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/859348/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/859348/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"CxI2gWbI\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zHfZz17yrz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 12 Jan 2018 08:46:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 626AB89CA8;\n\tThu, 11 Jan 2018 21:46:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6ScG7lvi-MS7; Thu, 11 Jan 2018 21:46:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 91BF189CA0;\n\tThu, 11 Jan 2018 21:46:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8CD781C221A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 11 Jan 2018 21:46:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 879C08A3DA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 11 Jan 2018 21:46:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GV4A6JeV6Cys for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 11 Jan 2018 21:46:14 +0000 (UTC)", "from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id BD44B8A319\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 11 Jan 2018 21:46:14 +0000 (UTC)", "from pps.filterd (userp2130.oracle.com [127.0.0.1])\n\tby userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw0BLfwna089593; Thu, 11 Jan 2018 21:46:13 GMT", "from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby userp2130.oracle.com with ESMTP id 2fefa7871r-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 11 Jan 2018 21:46:12 +0000", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw0BLkAYt005311\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=FAIL); Thu, 11 Jan 2018 21:46:11 GMT", "from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw0BLkAxu018311; Thu, 11 Jan 2018 21:46:10 GMT", "from mwanda (/197.157.34.168)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 11 Jan 2018 13:46:09 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=date : from : to : cc\n\t: subject : message-id : mime-version : content-type;\n\ts=corp-2017-10-26; \n\tbh=4JG6A7ttDwB63UXXJiiiFvVR6FF51g4LRCrtHTA0qMY=;\n\tb=CxI2gWbIcLOdK777Qg1+f+99CA1K4FmPMovTSVYmrCh+8s9etaUVE3YGulf1jvemF9mJ\n\t5iiCDbwCTvmxZxGJELiarfZqx91zS12S0wMwZDSCBtDTbNv6e9keLvuQcf8OC+X24qzo\n\twjEWvrJemTCP+tMTUHsFfo6h4/G2h8V00RrMKyrukrEE6yXIP9hCQqtcBMEEh12yPhaN\n\tUL8I7sDeYjzjAFpawKtuDmPqqkCn0lAi4jdqCE+mVxL28oHoU6q+zFtwyimdQxsAUqmV\n\t0miZFP1BkTMkut00y6bW7of5x63rAC6ChUi7gCn7vq8glPgwwbWMEReEi/SKFdPUOJWG\n\tqQ== ", "Date": "Fri, 12 Jan 2018 00:46:01 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tPaul Greenwalt <paul.greenwalt@intel.com>", "Message-ID": "<20180111214601.4cyjpvmbsothnc23@mwanda>", "MIME-Version": "1.0", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "NeoMutt/20170609 (1.8.3)", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8771\n\tsignatures=668652", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=901\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1801110293", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Fix && vs || typo", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "\"offset\" can't be both 0x0 and 0xFFFF so presumably || was intended\ninstead of &&. That matches with how this check is done in other\nfunctions.\n\nFixes: 73834aec7199 (\"ixgbe: extend firmware version support\")\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 1948e4208fb4..27de8a7f2aeb 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -4084,7 +4084,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,\n \thw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);\n \n \t/* Return is offset to OEM Product Version block is invalid */\n-\tif (offset == 0x0 && offset == NVM_INVALID_PTR)\n+\tif (offset == 0x0 || offset == NVM_INVALID_PTR)\n \t\treturn;\n \n \t/* Read product version block */\n", "prefixes": [] }