Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/857405/?format=api
{ "id": 857405, "url": "http://patchwork.ozlabs.org/api/patches/857405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180109113705.8464-1-mlichvar@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180109113705.8464-1-mlichvar@redhat.com>", "list_archive_url": null, "date": "2018-01-09T11:37:05", "name": "ixgbe: Don't report unsupported timestamping filters for X550", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "db56910b329672534245f30bc9cc18741427c225", "submitter": { "id": 17040, "url": "http://patchwork.ozlabs.org/api/people/17040/?format=api", "name": "Miroslav Lichvar", "email": "mlichvar@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180109113705.8464-1-mlichvar@redhat.com/mbox/", "series": [ { "id": 22129, "url": "http://patchwork.ozlabs.org/api/series/22129/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=22129", "date": "2018-01-09T11:37:05", "name": "ixgbe: Don't report unsupported timestamping filters for X550", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/22129/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/857405/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/857405/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zG9963ZgKz9rxj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jan 2018 22:37:13 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4D8D2886AA;\n\tTue, 9 Jan 2018 11:37:11 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0j2219lqJRBe; Tue, 9 Jan 2018 11:37:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1956788694;\n\tTue, 9 Jan 2018 11:37:10 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 50AA01C3F88\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jan 2018 11:37:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 491F289B91\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jan 2018 11:37:09 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id trKjD0CijzqC for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jan 2018 11:37:08 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 90AE889B90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 9 Jan 2018 11:37:08 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C4A151546B;\n\tTue, 9 Jan 2018 11:37:07 +0000 (UTC)", "from holly.tpb.lab.eng.brq.redhat.com (unknown [10.43.134.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BDEE5620D6;\n\tTue, 9 Jan 2018 11:37:06 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]); Tue, 09 Jan 2018 11:37:07 +0000 (UTC)" ], "From": "Miroslav Lichvar <mlichvar@redhat.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 9 Jan 2018 12:37:05 +0100", "Message-Id": "<20180109113705.8464-1-mlichvar@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Don't report unsupported\n\ttimestamping filters for X550", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Richard Cochran <richardcochran@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The current code enables on X550 timestamping of all packets for any\nfilter, which means ethtool should not report any PTP-specific filters\nas supported.\n\nSigned-off-by: Miroslav Lichvar <mlichvar@redhat.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 37 ++++++++++++------------\n 1 file changed, 19 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex 0aaf70b..0a5a351 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -3086,26 +3086,9 @@ static int ixgbe_get_ts_info(struct net_device *dev,\n \tcase ixgbe_mac_X550EM_x:\n \tcase ixgbe_mac_x550em_a:\n \t\tinfo->rx_filters |= BIT(HWTSTAMP_FILTER_ALL);\n-\t\t/* fallthrough */\n+\t\tbreak;\n \tcase ixgbe_mac_X540:\n \tcase ixgbe_mac_82599EB:\n-\t\tinfo->so_timestamping =\n-\t\t\tSOF_TIMESTAMPING_TX_SOFTWARE |\n-\t\t\tSOF_TIMESTAMPING_RX_SOFTWARE |\n-\t\t\tSOF_TIMESTAMPING_SOFTWARE |\n-\t\t\tSOF_TIMESTAMPING_TX_HARDWARE |\n-\t\t\tSOF_TIMESTAMPING_RX_HARDWARE |\n-\t\t\tSOF_TIMESTAMPING_RAW_HARDWARE;\n-\n-\t\tif (adapter->ptp_clock)\n-\t\t\tinfo->phc_index = ptp_clock_index(adapter->ptp_clock);\n-\t\telse\n-\t\t\tinfo->phc_index = -1;\n-\n-\t\tinfo->tx_types =\n-\t\t\tBIT(HWTSTAMP_TX_OFF) |\n-\t\t\tBIT(HWTSTAMP_TX_ON);\n-\n \t\tinfo->rx_filters |=\n \t\t\tBIT(HWTSTAMP_FILTER_PTP_V1_L4_SYNC) |\n \t\t\tBIT(HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ) |\n@@ -3114,6 +3097,24 @@ static int ixgbe_get_ts_info(struct net_device *dev,\n \tdefault:\n \t\treturn ethtool_op_get_ts_info(dev, info);\n \t}\n+\n+\tinfo->so_timestamping =\n+\t\tSOF_TIMESTAMPING_TX_SOFTWARE |\n+\t\tSOF_TIMESTAMPING_RX_SOFTWARE |\n+\t\tSOF_TIMESTAMPING_SOFTWARE |\n+\t\tSOF_TIMESTAMPING_TX_HARDWARE |\n+\t\tSOF_TIMESTAMPING_RX_HARDWARE |\n+\t\tSOF_TIMESTAMPING_RAW_HARDWARE;\n+\n+\tif (adapter->ptp_clock)\n+\t\tinfo->phc_index = ptp_clock_index(adapter->ptp_clock);\n+\telse\n+\t\tinfo->phc_index = -1;\n+\n+\tinfo->tx_types =\n+\t\tBIT(HWTSTAMP_TX_OFF) |\n+\t\tBIT(HWTSTAMP_TX_ON);\n+\n \treturn 0;\n }\n \n", "prefixes": [] }