Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/857142/?format=api
{ "id": 857142, "url": "http://patchwork.ozlabs.org/api/patches/857142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1515451669-927-2-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1515451669-927-2-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2018-01-08T22:47:49", "name": "[next-queue,2/2] ixgbe: add unlikely notes to tx fastpath expressions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b7ca55cfba649b90ea4ad574b00990cf862fbcc2", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1515451669-927-2-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 22016, "url": "http://patchwork.ozlabs.org/api/series/22016/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=22016", "date": "2018-01-08T22:47:49", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/22016/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/857142/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/857142/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"MNHJ0wIZ\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zFr5f6vFBz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jan 2018 09:48:06 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D4D8589375;\n\tMon, 8 Jan 2018 22:48:04 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g9vtYqEJSrLa; Mon, 8 Jan 2018 22:48:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 469AF891D0;\n\tMon, 8 Jan 2018 22:48:03 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 564381C001E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jan 2018 22:47:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4EF842635F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jan 2018 22:48:01 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ceIOuwfiILID for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jan 2018 22:48:00 +0000 (UTC)", "from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8C4892313B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jan 2018 22:48:00 +0000 (UTC)", "from pps.filterd (aserp2120.oracle.com [127.0.0.1])\n\tby aserp2120.oracle.com (8.16.0.22/8.16.0.21) with SMTP id\n\tw08MlEFw117629; Mon, 8 Jan 2018 22:47:58 GMT", "from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp2120.oracle.com with ESMTP id 2fcesmgt5c-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 08 Jan 2018 22:47:58 +0000", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw08Mlvcp009589\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=FAIL); Mon, 8 Jan 2018 22:47:57 GMT", "from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tw08MlvS1008070; Mon, 8 Jan 2018 22:47:57 GMT", "from slnelson-mint18.us.oracle.com (/10.159.139.52)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 08 Jan 2018 14:47:57 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references;\n\ts=corp-2017-10-26; \n\tbh=abYdrC0XA0sQo3hKABf78AR6ZICtMP/ZgQr4AjYYseE=;\n\tb=MNHJ0wIZHhLhWLInEIE8ep5THs9AW4HI7ZL0VBWp2OzLrOwZsg17zMQMIf8Vjhvwp19T\n\tzySWhYfUouaQIccCMWpiiGsdXZm5XkGT/uIpYkXPioRUMRj7+htguRcJUgpIjtmvayd/\n\t08DZxoByWhDSUpL3Ya3OU0OqvTe8nuR77ltoAgkV1Xfriaksksrpb4plJoflqbfGcb+K\n\tyBvLD587TvbiAaJgmKH+DD3CU/OhwLkHKXSVMmXclqH1lBfzuM8QpS0Rot4pgHcChk9v\n\teFPo/HehzHOI1l3o2+bfP1ZtiJ+IAgOXA3BojIKf8ykTwVQMbWwIS/B4vc9qYg/fgVWd\n\tSw== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Mon, 8 Jan 2018 14:47:49 -0800", "Message-Id": "<1515451669-927-2-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1515451669-927-1-git-send-email-shannon.nelson@oracle.com>", "References": "<1515451669-927-1-git-send-email-shannon.nelson@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8768\n\tsignatures=668652", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1801080320", "Subject": "[Intel-wired-lan] [PATCH next-queue 2/2] ixgbe: add unlikely notes\n\tto tx fastpath expressions", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "steffen.klassert@secunet.com, netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add unlikely() to a few error checking expressions in the Tx\noffload handling.\n\nSuggested-by: Yanjun Zhu <yanjun.zhu@oracle.com>\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex 57c10e6..3d069a2 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -749,28 +749,28 @@ int ixgbe_ipsec_tx(struct ixgbe_ring *tx_ring,\n \tstruct xfrm_state *xs;\n \tstruct tx_sa *tsa;\n \n-\tif (!first->skb->sp->len) {\n+\tif (unlikely(!first->skb->sp->len)) {\n \t\tnetdev_err(tx_ring->netdev, \"%s: no xfrm state len = %d\\n\",\n \t\t\t __func__, first->skb->sp->len);\n \t\treturn 0;\n \t}\n \n \txs = xfrm_input_state(first->skb);\n-\tif (!xs) {\n+\tif (unlikely(!xs)) {\n \t\tnetdev_err(tx_ring->netdev, \"%s: no xfrm_input_state() xs = %p\\n\",\n \t\t\t __func__, xs);\n \t\treturn 0;\n \t}\n \n \titd->sa_idx = xs->xso.offload_handle - IXGBE_IPSEC_BASE_TX_INDEX;\n-\tif (itd->sa_idx > IXGBE_IPSEC_MAX_SA_COUNT) {\n+\tif (unlikely(itd->sa_idx > IXGBE_IPSEC_MAX_SA_COUNT)) {\n \t\tnetdev_err(tx_ring->netdev, \"%s: bad sa_idx=%d handle=%lu\\n\",\n \t\t\t __func__, itd->sa_idx, xs->xso.offload_handle);\n \t\treturn 0;\n \t}\n \n \ttsa = &ipsec->tx_tbl[itd->sa_idx];\n-\tif (!tsa->used) {\n+\tif (unlikely(!tsa->used)) {\n \t\tnetdev_err(tx_ring->netdev, \"%s: unused sa_idx=%d\\n\",\n \t\t\t __func__, itd->sa_idx);\n \t\treturn 0;\n", "prefixes": [ "next-queue", "2/2" ] }