Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/856690/?format=api
{ "id": 856690, "url": "http://patchwork.ozlabs.org/api/patches/856690/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-20-f4bug@amsat.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180108024558.17983-20-f4bug@amsat.org>", "list_archive_url": null, "date": "2018-01-08T02:45:48", "name": "[19/29] piix4: add a i8254 pit controller as specified in datasheet", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "204a03fd4a40e7f2a03fc265b210e1c7fabaf18e", "submitter": { "id": 70924, "url": "http://patchwork.ozlabs.org/api/people/70924/?format=api", "name": "Philippe Mathieu-Daudé", "email": "f4bug@amsat.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20180108024558.17983-20-f4bug@amsat.org/mbox/", "series": [ { "id": 21847, "url": "http://patchwork.ozlabs.org/api/series/21847/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=21847", "date": "2018-01-08T02:45:30", "name": "remove i386/pc dependency: generic SuperIO, PIIX cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/21847/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/856690/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/856690/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Bgs+ZTfu\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zFKz64dBLz9s71\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 8 Jan 2018 14:10:42 +1100 (AEDT)", "from localhost ([::1]:60322 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1eYNpg-0002Rp-Or\n\tfor incoming@patchwork.ozlabs.org; Sun, 07 Jan 2018 22:10:40 -0500", "from eggs.gnu.org ([2001:4830:134:3::10]:51619)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1eYNT1-0007L4-HL\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:47:16 -0500", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1eYNT0-0002w1-L7\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:47:15 -0500", "from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:42455)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1eYNT0-0002vK-GN\n\tfor qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:47:14 -0500", "by mail-qk0-x241.google.com with SMTP id d202so12534550qkc.9\n\tfor <qemu-devel@nongnu.org>; Sun, 07 Jan 2018 18:47:14 -0800 (PST)", "from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id\n\td10sm7156245qkg.16.2018.01.07.18.47.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 07 Jan 2018 18:47:13 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hBi79hDIgEKjjopvztu2QDJ3BpIh5Nt3kAqhiadNHys=;\n\tb=Bgs+ZTfud/aOfO1xQiT+m4CK9fYEgdRUXU0C1wwEv537uboMZcgt+poolm0a/FI+oO\n\tap3ujdpmDeSbuFOvW2cUb1V38ulL9OGhMn7T5wIjYwxQ4rq36VUXD0yk+A9faWO3vLrI\n\tJjx1hNIGbesvNownA4/fC2zuKEGXJyfd1jGHJj9gXozMxgNhni+J9CIJ29msgXmHjX/4\n\tAqc22CTfr4aCmcsnrKlCQDxPW0PY0Mw7D/gXm/gktv4CLcNfZUBQTksQ6dg55od8hN7Q\n\tFhyfcPGDpDqeIzUApHD12aXZTqH47rv8hvQb0rqSLOYSeAuY2+gV+ex08jiqAWKY5Jmz\n\t1LtA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=hBi79hDIgEKjjopvztu2QDJ3BpIh5Nt3kAqhiadNHys=;\n\tb=Wvq9rSS+kzGR9p0O0lTaaL7v/6VNvc01qi8H//pmZ0k2aJt6Ia4q0BwYk3W6TJnrF5\n\tuvoWKNLd8BYQQwdEPHLmEGQWadqMCfB6obQK7DoF8zPj0W65ybyvFFY9oxnd0hkFefpP\n\tk3DjfZuQag4vGXyNGr/mdki1V0h7ggG3Y4nEyVPWr6BWya4dR80TQduzGUeSyT1QixkV\n\tztlFp2NyoqYYIvW0MxeHbPzHdXbTo0vYqSQlWyvSLt1ZETz05pyIdDPWR1YcbgKes8YM\n\tCKiGJD9aSobfiq13V31GnizMq1N52sLQDvpUa6r16wjgKzubaJ5fxPU4haEliY790aQx\n\tYB9g==", "X-Gm-Message-State": "AKwxytd/KwaWCife0CwEapJFegW3K/NWhqStn9f3bZoWdMSUiO06Mpl1\n\tHnp0ANa8iID6kXAMbZ+1EvY=", "X-Google-Smtp-Source": "ACJfBovCXey5NbFUZkbjv6kqU0J8pHnMNExnw7SOLBjaZG+Z7ZlOuUYtafUq3lU5kE/JnMj42DXMmg==", "X-Received": "by 10.55.152.69 with SMTP id a66mr13204291qke.120.1515379633930; \n\tSun, 07 Jan 2018 18:47:13 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>", "To": "Paolo Bonzini <pbonzini@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>, =?utf-8?q?Herv=C3=A9_Poussinea?=\n\t=?utf-8?q?u?= <hpoussin@reactos.org>,\n\tAurelien Jarno <aurelien@aurel32.net>, Eduardo Habkost\n\t<ehabkost@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>", "Date": "Sun, 7 Jan 2018 23:45:48 -0300", "Message-Id": "<20180108024558.17983-20-f4bug@amsat.org>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20180108024558.17983-1-f4bug@amsat.org>", "References": "<20180108024558.17983-1-f4bug@amsat.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400d:c09::241", "Subject": "[Qemu-devel] [PATCH 19/29] piix4: add a i8254 pit controller as\n\tspecified in datasheet", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Igor Mammedov <imammedo@redhat.com>, Yongbok Kim <yongbok.kim@mips.com>, \n\tqemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t<f4bug@amsat.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Hervé Poussineau <hpoussin@reactos.org>\n\nRemove i8254 instanciated in malta board, to not have it twice.\n\nSigned-off-by: Hervé Poussineau <hpoussin@reactos.org>\n[PMD: rebased]\nSigned-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n hw/isa/piix4.c | 4 ++++\n hw/mips/mips_malta.c | 4 ----\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c\nindex 56a1c7d429..04b13f97c6 100644\n--- a/hw/isa/piix4.c\n+++ b/hw/isa/piix4.c\n@@ -31,6 +31,7 @@\n #include \"hw/southbridge/i82371_piix.h\"\n #include \"hw/dma/i8257.h\"\n #include \"hw/sysbus.h\"\n+#include \"hw/timer/i8254.h\"\n \n PCIDevice *piix4_dev;\n \n@@ -164,6 +165,9 @@ static void piix4_realize(PCIDevice *pci_dev, Error **errp)\n /* initialize ISA irqs */\n isa_bus_irqs(isa_bus, s->isa);\n \n+ /* initialize pit */\n+ i8254_pit_init(isa_bus, 0x40, 0, NULL);\n+\n /* DMA */\n i8257_dma_init(isa_bus, 0);\n \ndiff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\nindex db5a8b1811..84b4d5c423 100644\n--- a/hw/mips/mips_malta.c\n+++ b/hw/mips/mips_malta.c\n@@ -44,7 +44,6 @@\n #include \"hw/loader.h\"\n #include \"elf.h\"\n #include \"hw/timer/mc146818rtc.h\"\n-#include \"hw/timer/i8254.h\"\n #include \"sysemu/blockdev.h\"\n #include \"exec/address-spaces.h\"\n #include \"hw/sysbus.h\" /* SysBusDevice */\n@@ -98,8 +97,6 @@ typedef struct {\n qemu_irq i8259[16];\n } MaltaState;\n \n-static ISADevice *pit;\n-\n static struct _loaderparams {\n int ram_size, ram_low_size;\n const char *kernel_filename;\n@@ -1206,7 +1203,6 @@ void mips_malta_init(MachineState *machine)\n pci_create_simple(pci_bus, piix4_devfn + 2, \"piix4-usb-uhci\");\n smbus = piix4_pm_init(pci_bus, piix4_devfn + 3, 0x1100,\n isa_get_irq(NULL, 9), NULL, 0, NULL);\n- pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);\n mc146818_rtc_init(isa_bus, 2000, NULL);\n \n /* generate SPD EEPROM data */\n", "prefixes": [ "19/29" ] }