Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/856555/?format=api
{ "id": 856555, "url": "http://patchwork.ozlabs.org/api/patches/856555/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180107145146.2934-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180107145146.2934-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-01-07T14:51:46", "name": "ixgbevf: use ARRAY_SIZE for various array sizing calculations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6841c6fa5bd8bf1f2e72ceb742762c6f8b7f92db", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180107145146.2934-1-colin.king@canonical.com/mbox/", "series": [ { "id": 21793, "url": "http://patchwork.ozlabs.org/api/series/21793/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=21793", "date": "2018-01-07T14:51:46", "name": "ixgbevf: use ARRAY_SIZE for various array sizing calculations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/21793/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/856555/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/856555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zF1bh3lSXz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 8 Jan 2018 01:52:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 873CC230F3;\n\tSun, 7 Jan 2018 14:52:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xNZ9dXxyQ-0D; Sun, 7 Jan 2018 14:52:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0655B22DEC;\n\tSun, 7 Jan 2018 14:52:39 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8FB4C1C143E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 7 Jan 2018 14:52:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5A43588E41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 7 Jan 2018 14:52:37 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wyEJZSo-zTtF for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 7 Jan 2018 14:52:34 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 58731892B9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 7 Jan 2018 14:51:51 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1eYCIc-000870-Vp; Sun, 07 Jan 2018 14:51:47 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Sun, 7 Jan 2018 14:51:46 +0000", "Message-Id": "<20180107145146.2934-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.15.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: use ARRAY_SIZE for various array\n\tsizing calculations", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nUse the ARRAY_SIZE macro on various arrays to determine\nsize of the arrays. Improvement suggested by coccinelle.\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbevf/vf.c | 17 +++++++----------\n 1 file changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex 0c25006ce9af..cd79c4a73b48 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -285,7 +285,7 @@ static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n \t\tether_addr_copy(msg_addr, addr);\n \n \tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n-\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n+\t\t\t\t\t ARRAY_SIZE(msgbuf));\n \tif (!ret_val) {\n \t\tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -455,8 +455,7 @@ static s32 ixgbevf_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr,\n \tether_addr_copy(msg_addr, addr);\n \n \tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n-\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n-\n+\t\t\t\t\t ARRAY_SIZE(msgbuf));\n \tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n \t/* if nacked the address was rejected, use \"perm_addr\" */\n@@ -571,7 +570,7 @@ static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n \tmsgbuf[1] = xcast_mode;\n \n \terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n-\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n+\t\t\t\t\t ARRAY_SIZE(msgbuf));\n \tif (err)\n \t\treturn err;\n \n@@ -609,7 +608,7 @@ static s32 ixgbevf_set_vfta_vf(struct ixgbe_hw *hw, u32 vlan, u32 vind,\n \tmsgbuf[0] |= vlan_on << IXGBE_VT_MSGINFO_SHIFT;\n \n \terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n-\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n+\t\t\t\t\t ARRAY_SIZE(msgbuf));\n \tif (err)\n \t\tgoto mbx_err;\n \n@@ -813,7 +812,7 @@ static s32 ixgbevf_set_rlpml_vf(struct ixgbe_hw *hw, u16 max_size)\n \tmsgbuf[1] = max_size;\n \n \tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n-\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n+\t\t\t\t\t ARRAY_SIZE(msgbuf));\n \tif (ret_val)\n \t\treturn ret_val;\n \tif ((msgbuf[0] & IXGBE_VF_SET_LPE) &&\n@@ -859,8 +858,7 @@ static int ixgbevf_negotiate_api_version_vf(struct ixgbe_hw *hw, int api)\n \tmsg[1] = api;\n \tmsg[2] = 0;\n \n-\terr = ixgbevf_write_msg_read_ack(hw, msg, msg,\n-\t\t\t\t\t sizeof(msg) / sizeof(u32));\n+\terr = ixgbevf_write_msg_read_ack(hw, msg, msg, ARRAY_SIZE(msg));\n \tif (!err) {\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -911,8 +909,7 @@ int ixgbevf_get_queues(struct ixgbe_hw *hw, unsigned int *num_tcs,\n \tmsg[0] = IXGBE_VF_GET_QUEUE;\n \tmsg[1] = msg[2] = msg[3] = msg[4] = 0;\n \n-\terr = ixgbevf_write_msg_read_ack(hw, msg, msg,\n-\t\t\t\t\t sizeof(msg) / sizeof(u32));\n+\terr = ixgbevf_write_msg_read_ack(hw, msg, msg, ARRAY_SIZE(msg));\n \tif (!err) {\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n", "prefixes": [] }