Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/856133/?format=api
{ "id": 856133, "url": "http://patchwork.ozlabs.org/api/patches/856133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180105095521.3621-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20180105095521.3621-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-01-05T09:55:21", "name": "i40evf: ignore link up if not running", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "42d8b23b29f3c64bb650d6ab1e1cfc4cf2e6f587", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20180105095521.3621-1-alice.michael@intel.com/mbox/", "series": [ { "id": 21562, "url": "http://patchwork.ozlabs.org/api/series/21562/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=21562", "date": "2018-01-05T09:55:21", "name": "i40evf: ignore link up if not running", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/21562/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/856133/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/856133/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zCsvY75lyz9sBZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 6 Jan 2018 05:02:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 529FE30C56;\n\tFri, 5 Jan 2018 18:02:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SDLnOjTGeP5G; Fri, 5 Jan 2018 18:02:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 400B430BC8;\n\tFri, 5 Jan 2018 18:02:30 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8BD661C033D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 5 Jan 2018 18:02:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 86BA08A621\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 5 Jan 2018 18:02:28 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id D0OwWi1kP66U for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 5 Jan 2018 18:02:27 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id CE3BE8A694\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 5 Jan 2018 18:02:27 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jan 2018 10:02:26 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga005.fm.intel.com with ESMTP; 05 Jan 2018 10:02:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,319,1511856000\"; d=\"scan'208\";a=\"192563115\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 5 Jan 2018 04:55:21 -0500", "Message-Id": "<20180105095521.3621-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [patch] i40evf: ignore link up if not running", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nIf we receive the link status message from PF with link up before queues\nare actually enabled, it will trigger a TX hang. This fixes the issue\nby ignoring a link up message if the VF state is not yet in RUNNING\nstate.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 35 ++++++++++++++--------\n 1 file changed, 23 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex 09b198e..d57a672 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -1007,23 +1007,34 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \tif (v_opcode == VIRTCHNL_OP_EVENT) {\n \t\tstruct virtchnl_pf_event *vpe =\n \t\t\t(struct virtchnl_pf_event *)msg;\n+\t\tbool link_up = vpe->event_data.link_event.link_status;\n \t\tswitch (vpe->event) {\n \t\tcase VIRTCHNL_EVENT_LINK_CHANGE:\n \t\t\tadapter->link_speed =\n \t\t\t\tvpe->event_data.link_event.link_speed;\n-\t\t\tif (adapter->link_up !=\n-\t\t\t vpe->event_data.link_event.link_status) {\n-\t\t\t\tadapter->link_up =\n-\t\t\t\t\tvpe->event_data.link_event.link_status;\n-\t\t\t\tif (adapter->link_up) {\n-\t\t\t\t\tnetif_tx_start_all_queues(netdev);\n-\t\t\t\t\tnetif_carrier_on(netdev);\n-\t\t\t\t} else {\n-\t\t\t\t\tnetif_tx_stop_all_queues(netdev);\n-\t\t\t\t\tnetif_carrier_off(netdev);\n-\t\t\t\t}\n-\t\t\t\ti40evf_print_link_message(adapter);\n+\n+\t\t\t/* we've already got the right link status, bail */\n+\t\t\tif (adapter->link_up == link_up)\n+\t\t\t\tbreak;\n+\n+\t\t\t/* If we get link up message and start queues before\n+\t\t\t * our queues are configured it will trigger a TX hang.\n+\t\t\t * In that case, just ignore the link status message,\n+\t\t\t * we'll get another one after we enable queues and\n+\t\t\t * actually prepared to send traffic.\n+\t\t\t */\n+\t\t\tif (link_up && adapter->state != __I40EVF_RUNNING)\n+\t\t\t\tbreak;\n+\n+\t\t\tadapter->link_up = link_up;\n+\t\t\tif (link_up) {\n+\t\t\t\tnetif_tx_start_all_queues(netdev);\n+\t\t\t\tnetif_carrier_on(netdev);\n+\t\t\t} else {\n+\t\t\t\tnetif_tx_stop_all_queues(netdev);\n+\t\t\t\tnetif_carrier_off(netdev);\n \t\t\t}\n+\t\t\ti40evf_print_link_message(adapter);\n \t\t\tbreak;\n \t\tcase VIRTCHNL_EVENT_RESET_IMPENDING:\n \t\t\tdev_info(&adapter->pdev->dev, \"PF reset warning received\\n\");\n", "prefixes": [] }