Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/854012/?format=api
{ "id": 854012, "url": "http://patchwork.ozlabs.org/api/patches/854012/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171229135120.14693-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171229135120.14693-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-29T13:51:20", "name": "[next,S85-V1,12/14] i40evf: Correctly populate rxitr_idx and txitr_idx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f320713c41f8ebbbdb58adfd3652a5d21c9243d4", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171229135120.14693-1-alice.michael@intel.com/mbox/", "series": [ { "id": 20665, "url": "http://patchwork.ozlabs.org/api/series/20665/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=20665", "date": "2017-12-29T13:48:33", "name": "[next,S85-V1,01/14] i40e: fix typo in function description", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/20665/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/854012/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/854012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z7gSs2SgPz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Dec 2017 08:58:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9E18186C93;\n\tFri, 29 Dec 2017 21:58:19 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PFKQYv6iUtTC; Fri, 29 Dec 2017 21:58:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1A77686C6B;\n\tFri, 29 Dec 2017 21:58:18 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id A31E41C0180\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Dec 2017 21:58:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9F3C08769B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Dec 2017 21:58:16 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wWJ1l1Fe564I for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Dec 2017 21:58:16 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 24DD287691\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Dec 2017 21:58:16 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Dec 2017 13:58:15 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga008.jf.intel.com with ESMTP; 29 Dec 2017 13:58:15 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,478,1508828400\"; d=\"scan'208\";a=\"6525429\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 29 Dec 2017 08:51:20 -0500", "Message-Id": "<20171229135120.14693-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S85-V1 12/14] i40evf: Correctly\n\tpopulate rxitr_idx and txitr_idx", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nWhile testing code for the recent ITR changes I found that updating the Tx\nITR appeared to have no effect with everything defaulting to the Rx ITR. A\nbit of digging narrowed it down the fact that we were asking the PF to\nassociate all causes with ITR 0 as we weren't populating the itr_idx values\nfor either Rx or Tx.\n\nTo correct it I have added the configuration for these values to this\npatch. In addition I did some minor clean-up to just add a local pointer\nfor the vector map instead of dereferencing it based off of the index\nrepeatedly. In my opinion this makes the resultant code a bit more readable\nand saves us a few characters.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 24 ++++++++++++++--------\n 1 file changed, 15 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex feb95b6..09b198e 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -344,6 +344,7 @@ void i40evf_disable_queues(struct i40evf_adapter *adapter)\n void i40evf_map_queues(struct i40evf_adapter *adapter)\n {\n \tstruct virtchnl_irq_map_info *vimi;\n+\tstruct virtchnl_vector_map *vecmap;\n \tint v_idx, q_vectors, len;\n \tstruct i40e_q_vector *q_vector;\n \n@@ -367,17 +368,22 @@ void i40evf_map_queues(struct i40evf_adapter *adapter)\n \tvimi->num_vectors = adapter->num_msix_vectors;\n \t/* Queue vectors first */\n \tfor (v_idx = 0; v_idx < q_vectors; v_idx++) {\n-\t\tq_vector = adapter->q_vectors + v_idx;\n-\t\tvimi->vecmap[v_idx].vsi_id = adapter->vsi_res->vsi_id;\n-\t\tvimi->vecmap[v_idx].vector_id = v_idx + NONQ_VECS;\n-\t\tvimi->vecmap[v_idx].txq_map = q_vector->ring_mask;\n-\t\tvimi->vecmap[v_idx].rxq_map = q_vector->ring_mask;\n+\t\tq_vector = &adapter->q_vectors[v_idx];\n+\t\tvecmap = &vimi->vecmap[v_idx];\n+\n+\t\tvecmap->vsi_id = adapter->vsi_res->vsi_id;\n+\t\tvecmap->vector_id = v_idx + NONQ_VECS;\n+\t\tvecmap->txq_map = q_vector->ring_mask;\n+\t\tvecmap->rxq_map = q_vector->ring_mask;\n+\t\tvecmap->rxitr_idx = I40E_RX_ITR;\n+\t\tvecmap->txitr_idx = I40E_TX_ITR;\n \t}\n \t/* Misc vector last - this is only for AdminQ messages */\n-\tvimi->vecmap[v_idx].vsi_id = adapter->vsi_res->vsi_id;\n-\tvimi->vecmap[v_idx].vector_id = 0;\n-\tvimi->vecmap[v_idx].txq_map = 0;\n-\tvimi->vecmap[v_idx].rxq_map = 0;\n+\tvecmap = &vimi->vecmap[v_idx];\n+\tvecmap->vsi_id = adapter->vsi_res->vsi_id;\n+\tvecmap->vector_id = 0;\n+\tvecmap->txq_map = 0;\n+\tvecmap->rxq_map = 0;\n \n \tadapter->aq_required &= ~I40EVF_FLAG_AQ_MAP_VECTORS;\n \ti40evf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_IRQ_MAP,\n", "prefixes": [ "next", "S85-V1", "12/14" ] }