Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/853261/?format=api
{ "id": 853261, "url": "http://patchwork.ozlabs.org/api/patches/853261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227132633.24272-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171227132633.24272-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-27T13:26:33", "name": "[next,S84-V2,13/13] i40e: fix reported mask for ntuple filters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2f486dcde287ade1a4922331d77be44b6aaa50f1", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227132633.24272-1-alice.michael@intel.com/mbox/", "series": [ { "id": 20419, "url": "http://patchwork.ozlabs.org/api/series/20419/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=20419", "date": "2017-12-27T13:25:32", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/20419/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/853261/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/853261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z6R1C0rfgz9sR8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Dec 2017 08:33:34 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2748F86A73;\n\tWed, 27 Dec 2017 21:33:33 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hal3-vS6kTa7; Wed, 27 Dec 2017 21:33:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CCDA0869A1;\n\tWed, 27 Dec 2017 21:33:31 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9F0D11BFC4F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:33:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9BC25869A1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:33:30 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id e1hRT_ocpUcy for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:33:29 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 6AB6F86935\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:33:29 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Dec 2017 13:33:28 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Dec 2017 13:33:28 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,467,1508828400\"; d=\"scan'208\";a=\"21885942\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Dec 2017 08:26:33 -0500", "Message-Id": "<20171227132633.24272-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S84-V2 13/13] i40e: fix reported mask\n\tfor ntuple filters", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nIn commit 36777d9fa24c (\"i40e: check current configured input set when\nadding ntuple filters\") some code was added to report the input set\nmask for a given filter when reporting it to the user.\n\nThis code is necessary so that the reported filter correctly displays\nthat it is or is not masking certain fields.\n\nUnfortunately the code was incorrect. Development error accidentally\nswapped the mask values for the IPv4 addresses with the L4 port numbers.\nThe port numbers are only 16bits wide while IPv4 addresses are 32 bits.\nUnfortunately we assigned only 16 bits to the IPv4 address masks.\nAdditionally we assigned 32bit value 0xFFFFFFF to the TCP port numbers.\nThis second part does not matter as the value would be truncated to\n16bits regardless, but it is unnecessary.\n\nFix the reported masks to properly report that the entire field is\nmasked.\n\nTesting-hints:\n Upstream commit message will need to reword to target the equivalent\n upstream commit for the \"Fixes\" line.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 83021c7..8236689 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2749,16 +2749,16 @@ static int i40e_get_ethtool_fdir_entry(struct i40e_pf *pf,\n \n no_input_set:\n \tif (input_set & I40E_L3_SRC_MASK)\n-\t\tfsp->m_u.tcp_ip4_spec.ip4src = htonl(0xFFFF);\n+\t\tfsp->m_u.tcp_ip4_spec.ip4src = htonl(0xFFFFFFFF);\n \n \tif (input_set & I40E_L3_DST_MASK)\n-\t\tfsp->m_u.tcp_ip4_spec.ip4dst = htonl(0xFFFF);\n+\t\tfsp->m_u.tcp_ip4_spec.ip4dst = htonl(0xFFFFFFFF);\n \n \tif (input_set & I40E_L4_SRC_MASK)\n-\t\tfsp->m_u.tcp_ip4_spec.psrc = htons(0xFFFFFFFF);\n+\t\tfsp->m_u.tcp_ip4_spec.psrc = htons(0xFFFF);\n \n \tif (input_set & I40E_L4_DST_MASK)\n-\t\tfsp->m_u.tcp_ip4_spec.pdst = htons(0xFFFFFFFF);\n+\t\tfsp->m_u.tcp_ip4_spec.pdst = htons(0xFFFF);\n \n \tif (rule->dest_ctl == I40E_FILTER_PROGRAM_DESC_DEST_DROP_PACKET)\n \t\tfsp->ring_cookie = RX_CLS_FLOW_DISC;\n", "prefixes": [ "next", "S84-V2", "13/13" ] }