Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/853259/?format=api
{ "id": 853259, "url": "http://patchwork.ozlabs.org/api/patches/853259/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227132412.24115-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171227132412.24115-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-27T13:24:12", "name": "[next,S84-V2,11/13] i40e: program fragmented IPv4 filter input set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "85a2016a982ccd69dff8a0715921d04f6833ce8b", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227132412.24115-1-alice.michael@intel.com/mbox/", "series": [ { "id": 20417, "url": "http://patchwork.ozlabs.org/api/series/20417/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=20417", "date": "2017-12-27T13:14:40", "name": "[next,S84-V2,01/13] i40e: Add returning AQ critical error to SW", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/20417/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/853259/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/853259/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z6QyS5Rv7z9sR8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Dec 2017 08:31:12 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E918886DC3;\n\tWed, 27 Dec 2017 21:31:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MVpp0CjfVEF5; Wed, 27 Dec 2017 21:31:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2944386DAD;\n\tWed, 27 Dec 2017 21:31:10 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3A89E1BFC4F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:31:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 35D3C8710A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:31:09 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PeZdhuUqvRVh for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:31:08 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id A46E2870B9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:31:08 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Dec 2017 13:31:08 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 27 Dec 2017 13:31:08 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,467,1508828400\"; d=\"scan'208\";a=\"19359208\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Dec 2017 08:24:12 -0500", "Message-Id": "<20171227132412.24115-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S84-V2 11/13] i40e: program\n\tfragmented IPv4 filter input set", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nWhen implementing support for IP_USER_FLOW filters, we correctly\nprogrammed a filter for both the non fragmented IPv4/Other filter, as\nwell as the fragmented IPv4 filters. However, we did not properly\nprogram the input set for fragmented IPv4 PCTYPE. This meant that the\nfilters would almost certainly not match, unless the user specified all\nof the flow types.\n\nAdd support to program the fragmented IPv4 filter input set. Since we\nalways program these filters together, we'll assume that the two input\nsets must match, and will thus always program the input sets to the same\nvalue.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 ++++++++++\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 96155f1..9f6e4f0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -3809,6 +3809,16 @@ static int i40e_check_fdir_input_set(struct i40e_vsi *vsi,\n \n \ti40e_write_fd_input_set(pf, index, new_mask);\n \n+\t/* IP_USER_FLOW filters match both IPv4/Other and IPv4/Fragmented\n+\t * frames. If we're programming the input set for IPv4/Other, we also\n+\t * need to program the IPv4/Fragmented input set. Since we don't have\n+\t * separate support, we'll always assume and enforce that the two flow\n+\t * types must have matching input sets.\n+\t */\n+\tif (index == I40E_FILTER_PCTYPE_NONF_IPV4_OTHER)\n+\t\ti40e_write_fd_input_set(pf, I40E_FILTER_PCTYPE_FRAG_IPV4,\n+\t\t\t\t\tnew_mask);\n+\n \t/* Add the new offset and update table, if necessary */\n \tif (new_flex_offset) {\n \t\terr = i40e_add_flex_offset(&pf->l4_flex_pit_list, src_offset,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4493652..4a3b13d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7736,6 +7736,9 @@ static void i40e_fdir_filter_exit(struct i40e_pf *pf)\n \t/* Reprogram the default input set for Other/IPv4 */\n \ti40e_write_fd_input_set(pf, I40E_FILTER_PCTYPE_NONF_IPV4_OTHER,\n \t\t\t\tI40E_L3_SRC_MASK | I40E_L3_DST_MASK);\n+\n+\ti40e_write_fd_input_set(pf, I40E_FILTER_PCTYPE_FRAG_IPV4,\n+\t\t\t\tI40E_L3_SRC_MASK | I40E_L3_DST_MASK);\n }\n \n /**\n", "prefixes": [ "next", "S84-V2", "11/13" ] }