Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/853251/?format=api
{ "id": 853251, "url": "http://patchwork.ozlabs.org/api/patches/853251/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227131551.23675-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171227131551.23675-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-27T13:15:51", "name": "[next,S84-V2,04/13] i40e/i40evf: Use ring pointers to clean up _set_itr_per_queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "09ee58e8df1ffc60f8f455e15ec0ba20e440a94a", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227131551.23675-1-alice.michael@intel.com/mbox/", "series": [ { "id": 20417, "url": "http://patchwork.ozlabs.org/api/series/20417/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=20417", "date": "2017-12-27T13:14:40", "name": "[next,S84-V2,01/13] i40e: Add returning AQ critical error to SW", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/20417/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/853251/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/853251/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z6Qmq57Vlz9sR8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Dec 2017 08:22:51 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0750B86FC7;\n\tWed, 27 Dec 2017 21:22:50 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3taug+gCdOvX; Wed, 27 Dec 2017 21:22:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EE4C187060;\n\tWed, 27 Dec 2017 21:22:48 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 35AE11C25C5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:22:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3085C86B72\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:22:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iFyKrvf-PLEO for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:22:46 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 2060283AA7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:22:46 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Dec 2017 13:22:45 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga004.fm.intel.com with ESMTP; 27 Dec 2017 13:22:45 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,467,1508828400\"; d=\"scan'208\";a=\"15985647\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Dec 2017 08:15:51 -0500", "Message-Id": "<20171227131551.23675-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S84-V2 04/13] i40e/i40evf: Use ring\n\tpointers to clean up _set_itr_per_queue", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis change cleans up the i40e/i40evf_set_itr_per_queue function by\ndropping all the unneeded pointer chases. Instead we can just pull out the\npointers for the Tx and Rx rings and use them throughout the function.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 22 +++++++++--------\n drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 28 +++++++++++-----------\n 2 files changed, 26 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 099b170..79c752a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2305,6 +2305,8 @@ static void i40e_set_itr_per_queue(struct i40e_vsi *vsi,\n \t\t\t\t struct ethtool_coalesce *ec,\n \t\t\t\t int queue)\n {\n+\tstruct i40e_ring *rx_ring = vsi->rx_rings[queue];\n+\tstruct i40e_ring *tx_ring = vsi->tx_rings[queue];\n \tstruct i40e_pf *pf = vsi->back;\n \tstruct i40e_hw *hw = &pf->hw;\n \tstruct i40e_q_vector *q_vector;\n@@ -2312,26 +2314,26 @@ static void i40e_set_itr_per_queue(struct i40e_vsi *vsi,\n \n \tintrl = i40e_intrl_usec_to_reg(vsi->int_rate_limit);\n \n-\tvsi->rx_rings[queue]->rx_itr_setting = ec->rx_coalesce_usecs;\n-\tvsi->tx_rings[queue]->tx_itr_setting = ec->tx_coalesce_usecs;\n+\trx_ring->rx_itr_setting = ec->rx_coalesce_usecs;\n+\ttx_ring->tx_itr_setting = ec->tx_coalesce_usecs;\n \n \tif (ec->use_adaptive_rx_coalesce)\n-\t\tvsi->rx_rings[queue]->rx_itr_setting |= I40E_ITR_DYNAMIC;\n+\t\trx_ring->rx_itr_setting |= I40E_ITR_DYNAMIC;\n \telse\n-\t\tvsi->rx_rings[queue]->rx_itr_setting &= ~I40E_ITR_DYNAMIC;\n+\t\trx_ring->rx_itr_setting &= ~I40E_ITR_DYNAMIC;\n \n \tif (ec->use_adaptive_tx_coalesce)\n-\t\tvsi->tx_rings[queue]->tx_itr_setting |= I40E_ITR_DYNAMIC;\n+\t\ttx_ring->tx_itr_setting |= I40E_ITR_DYNAMIC;\n \telse\n-\t\tvsi->tx_rings[queue]->tx_itr_setting &= ~I40E_ITR_DYNAMIC;\n+\t\ttx_ring->tx_itr_setting &= ~I40E_ITR_DYNAMIC;\n \n-\tq_vector = vsi->rx_rings[queue]->q_vector;\n-\tq_vector->rx.itr = ITR_TO_REG(vsi->rx_rings[queue]->rx_itr_setting);\n+\tq_vector = rx_ring->q_vector;\n+\tq_vector->rx.itr = ITR_TO_REG(rx_ring->rx_itr_setting);\n \tvector = vsi->base_vector + q_vector->v_idx;\n \twr32(hw, I40E_PFINT_ITRN(I40E_RX_ITR, vector - 1), q_vector->rx.itr);\n \n-\tq_vector = vsi->tx_rings[queue]->q_vector;\n-\tq_vector->tx.itr = ITR_TO_REG(vsi->tx_rings[queue]->tx_itr_setting);\n+\tq_vector = tx_ring->q_vector;\n+\tq_vector->tx.itr = ITR_TO_REG(tx_ring->tx_itr_setting);\n \tvector = vsi->base_vector + q_vector->v_idx;\n \twr32(hw, I40E_PFINT_ITRN(I40E_TX_ITR, vector - 1), q_vector->tx.itr);\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\nindex da006fa..e2d8aa1 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n@@ -512,31 +512,31 @@ static void i40evf_set_itr_per_queue(struct i40evf_adapter *adapter,\n \t\t\t\t struct ethtool_coalesce *ec,\n \t\t\t\t int queue)\n {\n+\tstruct i40e_ring *rx_ring = &adapter->rx_rings[queue];\n+\tstruct i40e_ring *tx_ring = &adapter->tx_rings[queue];\n \tstruct i40e_vsi *vsi = &adapter->vsi;\n \tstruct i40e_hw *hw = &adapter->hw;\n \tstruct i40e_q_vector *q_vector;\n \tu16 vector;\n \n-\tadapter->rx_rings[queue].rx_itr_setting = ec->rx_coalesce_usecs;\n-\tadapter->tx_rings[queue].tx_itr_setting = ec->tx_coalesce_usecs;\n+\trx_ring->rx_itr_setting = ec->rx_coalesce_usecs;\n+\ttx_ring->tx_itr_setting = ec->tx_coalesce_usecs;\n \n-\tif (ec->use_adaptive_rx_coalesce)\n-\t\tadapter->rx_rings[queue].rx_itr_setting |= I40E_ITR_DYNAMIC;\n-\telse\n-\t\tadapter->rx_rings[queue].rx_itr_setting &= ~I40E_ITR_DYNAMIC;\n+\trx_ring->rx_itr_setting |= I40E_ITR_DYNAMIC;\n+\tif (!ec->use_adaptive_rx_coalesce)\n+\t\trx_ring->rx_itr_setting ^= I40E_ITR_DYNAMIC;\n \n-\tif (ec->use_adaptive_tx_coalesce)\n-\t\tadapter->tx_rings[queue].tx_itr_setting |= I40E_ITR_DYNAMIC;\n-\telse\n-\t\tadapter->tx_rings[queue].tx_itr_setting &= ~I40E_ITR_DYNAMIC;\n+\ttx_ring->tx_itr_setting |= I40E_ITR_DYNAMIC;\n+\tif (!ec->use_adaptive_tx_coalesce)\n+\t\ttx_ring->tx_itr_setting ^= I40E_ITR_DYNAMIC;\n \n-\tq_vector = adapter->rx_rings[queue].q_vector;\n-\tq_vector->rx.itr = ITR_TO_REG(adapter->rx_rings[queue].rx_itr_setting);\n+\tq_vector = rx_ring->q_vector;\n+\tq_vector->rx.itr = ITR_TO_REG(rx_ring->rx_itr_setting);\n \tvector = vsi->base_vector + q_vector->v_idx;\n \twr32(hw, I40E_VFINT_ITRN1(I40E_RX_ITR, vector - 1), q_vector->rx.itr);\n \n-\tq_vector = adapter->tx_rings[queue].q_vector;\n-\tq_vector->tx.itr = ITR_TO_REG(adapter->tx_rings[queue].tx_itr_setting);\n+\tq_vector = tx_ring->q_vector;\n+\tq_vector->tx.itr = ITR_TO_REG(tx_ring->tx_itr_setting);\n \tvector = vsi->base_vector + q_vector->v_idx;\n \twr32(hw, I40E_VFINT_ITRN1(I40E_TX_ITR, vector - 1), q_vector->tx.itr);\n \n", "prefixes": [ "next", "S84-V2", "04/13" ] }