Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/853250/?format=api
{ "id": 853250, "url": "http://patchwork.ozlabs.org/api/patches/853250/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227131440.23579-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171227131440.23579-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-27T13:14:40", "name": "[next,S84-V2,01/13] i40e: Add returning AQ critical error to SW", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "37580f7318b3302da20d66dddd2b70d5ec10e9c3", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227131440.23579-1-alice.michael@intel.com/mbox/", "series": [ { "id": 20417, "url": "http://patchwork.ozlabs.org/api/series/20417/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=20417", "date": "2017-12-27T13:14:40", "name": "[next,S84-V2,01/13] i40e: Add returning AQ critical error to SW", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/20417/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/853250/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/853250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z6QlX26B4z9sR8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Dec 2017 08:21:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B9BA285B63;\n\tWed, 27 Dec 2017 21:21:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ovjT5cfjT68g; Wed, 27 Dec 2017 21:21:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7319485AC9;\n\tWed, 27 Dec 2017 21:21:41 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7621F1C25C5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:21:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 70AE285AC9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:21:40 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3jKrKOaJhOmY for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:21:38 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 2DD7085A56\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 21:21:38 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Dec 2017 13:21:37 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga004.jf.intel.com with ESMTP; 27 Dec 2017 13:21:37 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,467,1508828400\"; d=\"scan'208\";a=\"162176217\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Dec 2017 08:14:40 -0500", "Message-Id": "<20171227131440.23579-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S84-V2 01/13] i40e: Add returning AQ\n\tcritical error to SW", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Michal Kosiarz <michal.kosiarz@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Michal Kosiarz <michal.kosiarz@intel.com>\n\nThe FW has the ability to return a critical error on every AQ command.\nWhen this critical error occurs then we need to send the correct response\nto the caller.\n\nSigned-off-by: Michal Kosiarz <michal.kosiarz@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_adminq.c | 13 +++++++++----\n drivers/net/ethernet/intel/i40e/i40e_common.c | 2 ++\n drivers/net/ethernet/intel/i40e/i40e_status.h | 1 +\n drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 13 +++++++++----\n drivers/net/ethernet/intel/i40evf/i40e_common.c | 2 ++\n drivers/net/ethernet/intel/i40evf/i40e_status.h | 1 +\n 6 files changed, 24 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\nindex d9670cd..c4fa06d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n@@ -907,10 +907,15 @@ i40e_status i40e_asq_send_command(struct i40e_hw *hw,\n \t/* update the error if time out occurred */\n \tif ((!cmd_completed) &&\n \t (!details->async && !details->postpone)) {\n-\t\ti40e_debug(hw,\n-\t\t\t I40E_DEBUG_AQ_MESSAGE,\n-\t\t\t \"AQTX: Writeback timeout.\\n\");\n-\t\tstatus = I40E_ERR_ADMIN_QUEUE_TIMEOUT;\n+\t\tif (rd32(hw, hw->aq.asq.len) & I40E_GL_ATQLEN_ATQCRIT_MASK) {\n+\t\t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\t\t\t\t \"AQTX: AQ Critical error.\\n\");\n+\t\t\tstatus = I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR;\n+\t\t} else {\n+\t\t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\t\t\t\t \"AQTX: Writeback timeout.\\n\");\n+\t\t\tstatus = I40E_ERR_ADMIN_QUEUE_TIMEOUT;\n+\t\t}\n \t}\n \n asq_send_command_error:\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex ee6052e..c690e9c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -278,6 +278,8 @@ const char *i40e_stat_str(struct i40e_hw *hw, i40e_status stat_err)\n \t\treturn \"I40E_NOT_SUPPORTED\";\n \tcase I40E_ERR_FIRMWARE_API_VERSION:\n \t\treturn \"I40E_ERR_FIRMWARE_API_VERSION\";\n+\tcase I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR:\n+\t\treturn \"I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR\";\n \t}\n \n \tsnprintf(hw->err_str, sizeof(hw->err_str), \"%d\", stat_err);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_status.h b/drivers/net/ethernet/intel/i40e/i40e_status.h\nindex 5f9cac5..afb72e7 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_status.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_status.h\n@@ -95,6 +95,7 @@ enum i40e_status_code {\n \tI40E_ERR_NOT_READY\t\t\t= -63,\n \tI40E_NOT_SUPPORTED\t\t\t= -64,\n \tI40E_ERR_FIRMWARE_API_VERSION\t\t= -65,\n+\tI40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR\t= -66,\n };\n \n #endif /* _I40E_STATUS_H_ */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq.c b/drivers/net/ethernet/intel/i40evf/i40e_adminq.c\nindex 8b0d4b2..ae3a740 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_adminq.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_adminq.c\n@@ -837,10 +837,15 @@ i40e_status i40evf_asq_send_command(struct i40e_hw *hw,\n \t/* update the error if time out occurred */\n \tif ((!cmd_completed) &&\n \t (!details->async && !details->postpone)) {\n-\t\ti40e_debug(hw,\n-\t\t\t I40E_DEBUG_AQ_MESSAGE,\n-\t\t\t \"AQTX: Writeback timeout.\\n\");\n-\t\tstatus = I40E_ERR_ADMIN_QUEUE_TIMEOUT;\n+\t\tif (rd32(hw, hw->aq.asq.len) & I40E_VF_ATQLEN1_ATQCRIT_MASK) {\n+\t\t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\t\t\t\t \"AQTX: AQ Critical error.\\n\");\n+\t\t\tstatus = I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR;\n+\t\t} else {\n+\t\t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\t\t\t\t \"AQTX: Writeback timeout.\\n\");\n+\t\t\tstatus = I40E_ERR_ADMIN_QUEUE_TIMEOUT;\n+\t\t}\n \t}\n \n asq_send_command_error:\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c\nindex a946484..67bf5ce 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c\n@@ -284,6 +284,8 @@ const char *i40evf_stat_str(struct i40e_hw *hw, i40e_status stat_err)\n \t\treturn \"I40E_NOT_SUPPORTED\";\n \tcase I40E_ERR_FIRMWARE_API_VERSION:\n \t\treturn \"I40E_ERR_FIRMWARE_API_VERSION\";\n+\tcase I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR:\n+\t\treturn \"I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR\";\n \t}\n \n \tsnprintf(hw->err_str, sizeof(hw->err_str), \"%d\", stat_err);\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_status.h b/drivers/net/ethernet/intel/i40evf/i40e_status.h\nindex 7fa7a41..5b22224 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_status.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_status.h\n@@ -95,6 +95,7 @@ enum i40e_status_code {\n \tI40E_ERR_NOT_READY\t\t\t= -63,\n \tI40E_NOT_SUPPORTED\t\t\t= -64,\n \tI40E_ERR_FIRMWARE_API_VERSION\t\t= -65,\n+\tI40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR\t= -66,\n };\n \n #endif /* _I40E_STATUS_H_ */\n", "prefixes": [ "next", "S84-V2", "01/13" ] }