Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/853246/?format=api
{ "id": 853246, "url": "http://patchwork.ozlabs.org/api/patches/853246/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227123242.22356-2-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171227123242.22356-2-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-27T12:32:31", "name": "[next,S84-V2,02/13] i40e: Fix for adding multiple ethtool filters on the same location", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ec6f1de7fbdc64c6cfb1dfeb9f7b59ffa57cb9cc", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171227123242.22356-2-alice.michael@intel.com/mbox/", "series": [ { "id": 20413, "url": "http://patchwork.ozlabs.org/api/series/20413/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=20413", "date": "2017-12-27T12:32:31", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/20413/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/853246/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/853246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z6Pq52cPfz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Dec 2017 07:39:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 04FFA870B9;\n\tWed, 27 Dec 2017 20:39:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JozHJQNJlbW0; Wed, 27 Dec 2017 20:39:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5EF738708F;\n\tWed, 27 Dec 2017 20:39:40 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3519D1C024B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 20:39:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3160286A61\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 20:39:39 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VeVeur3KThOV for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 20:39:38 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A6EDD86A08\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Dec 2017 20:39:38 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Dec 2017 12:39:37 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga008.fm.intel.com with ESMTP; 27 Dec 2017 12:39:37 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,467,1508828400\"; d=\"scan'208\";a=\"5622487\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Dec 2017 07:32:31 -0500", "Message-Id": "<20171227123242.22356-2-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20171227123242.22356-1-alice.michael@intel.com>", "References": "<20171227123242.22356-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S84-V2 02/13] i40e: Fix for adding\n\tmultiple ethtool filters on the same location", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Patryk Małek <patryk.malek@intel.com>\n\nThis patch reorders i40e_add_del_fdir and i40e_update_ethtool_fdir_entry\ncalls so that we first remove an already existing filter (inside\ni40e_update_ethtool_fdir_entry using i40e_add_del_fdir) and then\nwe add a new one with i40e_add_del_fdir.\nAfter applying this patch, creating multiple identical filters (with\nthe same location) one after another doesn't revert their behavior\nbut behaves correctly.\n\nSigned-off-by: Patryk Małek <patryk.malek@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 86329a3..099b170 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -3939,19 +3939,19 @@ static int i40e_add_fdir_ethtool(struct i40e_vsi *vsi,\n \t\tinput->flex_offset = userdef.flex_offset;\n \t}\n \n-\tret = i40e_add_del_fdir(vsi, input, true);\n-\tif (ret)\n-\t\tgoto free_input;\n-\n \t/* Add the input filter to the fdir_input_list, possibly replacing\n \t * a previous filter. Do not free the input structure after adding it\n \t * to the list as this would cause a use-after-free bug.\n \t */\n \ti40e_update_ethtool_fdir_entry(vsi, input, fsp->location, NULL);\n-\n+\tret = i40e_add_del_fdir(vsi, input, true);\n+\tif (ret)\n+\t\tgoto remove_sw_rule;\n \treturn 0;\n \n-free_input:\n+remove_sw_rule:\n+\thlist_del(&input->fdir_node);\n+\tpf->fdir_pf_active_filters--;\n \tkfree(input);\n \treturn ret;\n }\n", "prefixes": [ "next", "S84-V2", "02/13" ] }