Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/851553/?format=api
{ "id": 851553, "url": "http://patchwork.ozlabs.org/api/patches/851553/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20171220170607.41516-2-lorenzo@google.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171220170607.41516-2-lorenzo@google.com>", "list_archive_url": null, "date": "2017-12-20T17:06:01", "name": "[ipsec-next,1/7] net: xfrm: Don't check for TUNNEL_KEY when hashing VTI tunnels.", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": true, "hash": "34847140a2c18473787ac8d8d1230775a54e4371", "submitter": { "id": 3403, "url": "http://patchwork.ozlabs.org/api/people/3403/?format=api", "name": "Lorenzo Colitti", "email": "lorenzo@google.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20171220170607.41516-2-lorenzo@google.com/mbox/", "series": [ { "id": 19695, "url": "http://patchwork.ozlabs.org/api/series/19695/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=19695", "date": "2017-12-20T17:06:00", "name": ": Support multiple VTIs with the same src+dst pair", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/19695/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/851553/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/851553/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"JDnBH3t0\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3z21QZ5wnFz9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Dec 2017 04:06:46 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755503AbdLTRGd (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 20 Dec 2017 12:06:33 -0500", "from mail-pf0-f195.google.com ([209.85.192.195]:39211 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755292AbdLTRG2 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 20 Dec 2017 12:06:28 -0500", "by mail-pf0-f195.google.com with SMTP id l24so12809636pfj.6\n\tfor <netdev@vger.kernel.org>; Wed, 20 Dec 2017 09:06:28 -0800 (PST)", "from lorenzo.tok.corp.google.com ([100.103.3.232])\n\tby smtp.gmail.com with ESMTPSA id\n\tt62sm29103067pgt.23.2017.12.20.09.06.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Dec 2017 09:06:26 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=pYpFkwn3PYDZLJ9r3bZjVIZ6dJdzqEXaML5njxMop4M=;\n\tb=JDnBH3t0GjQJIXo+7C6ctf7YOPlwC976XRVBXRI5mstMx8NcKA2vYiMuOAIYVc6pyx\n\trKt+LCOMsM9L3q1fAGShpfkwXEH1TYYG0PPX68D4ZAKjXqtZ59HOGO1dwlEyqXN0uHcS\n\tVX8rd9dCuGpuFoCE2H4J0uJFUk7NnPoCuvX1vuukic15YYbSSD5QOD/zox+zpOnZDLPK\n\tj2zFcuapIrEMoSY1VtZdC1j46aY8IyqrsjWN5YqcXR65Q9me+l9+fQ31aRgRnwawcd+y\n\tTPBCveAqhxP168oOW/ZLff29FrQGZ1R8z5GkVtPoQRL+M8Cq8iKQGuvnE601FNZl2pY/\n\tieIQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=pYpFkwn3PYDZLJ9r3bZjVIZ6dJdzqEXaML5njxMop4M=;\n\tb=U5qUN+l4bJ3OYaU8tDWj4OcEJQW4jWbTiZaaulkCT/EMOhfX1J524QzHwSgGByO/Pe\n\tncK6mlubThqv5/jEnYRwTio++Cjzz9MLmK5iyNmrlL8kzmZ1opDUFezj7sQ1hLK5nsV0\n\tJnf5PAolcKv+B5mHIWQAajnaMNvYF02IPm7qD2riMFrnx0H1Ro78WDQV5Bk8znWJ+8Dz\n\tPbfoDeN4QcifHAujUDXC5RFUziZvM84uOvzlL9Ey9NNZh4DIWzQVN6CafiEIepCcllNS\n\tVZRGbxk3kqwNy5suKdbCPsEfkF8kpMfvK06Dkq40TRrKOVry0AkZpL5aFRXtdoKZSNQe\n\tFTZg==", "X-Gm-Message-State": "AKGB3mLU8hfNkMDDaFYdKNq2U1CdyYP96KQK1pvovFKfv77Q+UDzVXjA\n\tjHcTUNdx/oL4KblITnlgxJW5MSYQcc0=", "X-Google-Smtp-Source": "ACJfBouhbtfNv/cjefGPG+UonA6QzKQOGdkk1XPkanMMKn1JW/oC8C1tV7xRe6KqjJ7c3LnvpmBd9A==", "X-Received": "by 10.98.147.28 with SMTP id b28mr7563850pfe.5.1513789587037;\n\tWed, 20 Dec 2017 09:06:27 -0800 (PST)", "From": "Lorenzo Colitti <lorenzo@google.com>", "To": "netdev@vger.kernel.org", "Cc": "steffen.klassert@secunet.com, subashab@codeaurora.org,\n\tnharold@google.com, davem@davemloft.net,\n\tLorenzo Colitti <lorenzo@google.com>", "Subject": "[PATCH ipsec-next 1/7] net: xfrm: Don't check for TUNNEL_KEY when\n\thashing VTI tunnels.", "Date": "Thu, 21 Dec 2017 02:06:01 +0900", "Message-Id": "<20171220170607.41516-2-lorenzo@google.com>", "X-Mailer": "git-send-email 2.15.1.620.gb9897f4670-goog", "In-Reply-To": "<20171220170607.41516-1-lorenzo@google.com>", "References": "<20171220170607.41516-1-lorenzo@google.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Currently, ip_bucket sets the lookup i_key to 0 if the tunnel's\ni_flags have VTI_ISVTI flag set but not TUNNEL_KEY. However, it\ncan can never happen that TUNNEL_KEY is set if VTI_ISVTI is also\nset (see below). Therefore, just drop the check for TUNNEL_KEY\nand only set i_key to 0 on VTI_ISVTI.\n\nThis will allow the VTI code to set TUNNEL_KEY on certain\ntunnels in a future change.\n\nNone of the callers of ip_bucket pass in TUNNEL_KEY | VTI_ISVTI.\nThe call graph is as follows:\n\n- ip_tunnel_add\n - ip_tunnel_create\n - ip_tunnel_ioctl\n - ipgre_tunnel_ioctl: can set TUNNEL_KEY but not VTI_ISVTI\n - ipip_tunnel_ioctl: hardcodes i_flags to 0\n - vti_tunnel_ioctl: hardcodes i_flags to VTI_ISVTI\n - ip_tunnel_update: doesn't touch i_flags\n - ip_tunnel_init_net: memsets flags to 0\n - ip_tunnel_newlink\n - ipgre_newlink\n - ipgre_netlink_parms: can set TUNNEL_KEY but not VTI_ISVTI\n - vti_newlink: hardcodes i_flags to VTI_ISVTI\n - ip_tunnel_changelink: doesn't set flags\n- ip_tunnel_find\n - ip_tunnel_ioctl (see above)\n - ip_tunnel_newlink (see above)\n - ip_tunnel_changelink (see above)\n\nVTI_ISVTI has the same value as TUNNEL_DONT_FRAGMENT, but that\nis never set into tunnel parameters.\n\nSigned-off-by: Lorenzo Colitti <lorenzo@google.com>\n---\n net/ipv4/ip_tunnel.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c\nindex 5ddb1cb52b..539c8f22c4 100644\n--- a/net/ipv4/ip_tunnel.c\n+++ b/net/ipv4/ip_tunnel.c\n@@ -198,7 +198,7 @@ static struct hlist_head *ip_bucket(struct ip_tunnel_net *itn,\n \telse\n \t\tremote = 0;\n \n-\tif (!(parms->i_flags & TUNNEL_KEY) && (parms->i_flags & VTI_ISVTI))\n+\tif (parms->i_flags & VTI_ISVTI)\n \t\ti_key = 0;\n \n \th = ip_tunnel_hash(i_key, remote);\n", "prefixes": [ "ipsec-next", "1/7" ] }