Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/850295/?format=api
{ "id": 850295, "url": "http://patchwork.ozlabs.org/api/patches/850295/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171218101703.75823-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171218101703.75823-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-18T10:17:03", "name": "[next,S83-V5,5/9] i40e: Fix for blinking activity instead of link LEDs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "448eef1d1e459d6438760a05ebec31c0f03d6f60", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171218101703.75823-1-alice.michael@intel.com/mbox/", "series": [ { "id": 19211, "url": "http://patchwork.ozlabs.org/api/series/19211/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=19211", "date": "2017-12-18T10:14:44", "name": "[next,S83-V5,1/9] i40e/i40evf: Enable NVMUpdate to retrieve AdminQ and add preservation flags for NVM update", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/19211/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/850295/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/850295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z0qDT5BVyz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Dec 2017 05:23:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6EF598849F;\n\tMon, 18 Dec 2017 18:23:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 33xTPve83Rir; Mon, 18 Dec 2017 18:23:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8D34488494;\n\tMon, 18 Dec 2017 18:23:49 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id CE29D1C2092\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CA39987B07\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1uiq8kf61UVb for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:47 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 428B787AF8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:47 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Dec 2017 10:23:46 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby fmsmga008.fm.intel.com with ESMTP; 18 Dec 2017 10:23:46 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,422,1508828400\"; d=\"scan'208\";a=\"3515060\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 18 Dec 2017 05:17:03 -0500", "Message-Id": "<20171218101703.75823-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S83-V5 5/9] i40e: Fix for blinking\n\tactivity instead of link LEDs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Michal Kuchta <michal.kuchta@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Michal Kuchta <michal.kuchta@intel.com>\n\nThis fix solves an issue occurring while calling i40e_led_set function\nfrom the driver with \"blink\" parameter set as TRUE. This call resulted\nin Activity LED blinking instead of Link LED, which may lead to errors\nin physically identyfying the port, since Activity LED may be blinking\nfor different reasons aswell.\n\nSigned-off-by: Michal Kuchta <michal.kuchta@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex cf929cc..ee6052e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1486,6 +1486,7 @@ u32 i40e_led_get(struct i40e_hw *hw)\n \t\tcase I40E_COMBINED_ACTIVITY:\n \t\tcase I40E_FILTER_ACTIVITY:\n \t\tcase I40E_MAC_ACTIVITY:\n+\t\tcase I40E_LINK_ACTIVITY:\n \t\t\tcontinue;\n \t\tdefault:\n \t\t\tbreak;\n@@ -1534,6 +1535,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n \t\tcase I40E_COMBINED_ACTIVITY:\n \t\tcase I40E_FILTER_ACTIVITY:\n \t\tcase I40E_MAC_ACTIVITY:\n+\t\tcase I40E_LINK_ACTIVITY:\n \t\t\tcontinue;\n \t\tdefault:\n \t\t\tbreak;\n@@ -1544,9 +1546,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n \t\tgpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) &\n \t\t\t I40E_GLGEN_GPIO_CTL_LED_MODE_MASK);\n \n-\t\tif (mode == I40E_LINK_ACTIVITY)\n-\t\t\tblink = false;\n-\n \t\tif (blink)\n \t\t\tgpio_val |= BIT(I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT);\n \t\telse\n", "prefixes": [ "next", "S83-V5", "5/9" ] }