Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/850291/?format=api
{ "id": 850291, "url": "http://patchwork.ozlabs.org/api/patches/850291/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171218101643.75775-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171218101643.75775-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-18T10:16:43", "name": "[next,S83-V5,4/9] i40evf: Don't schedule reset_task when device is being removed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "455e191ee81933073281a59a2e325cc3b9d30d1e", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171218101643.75775-1-alice.michael@intel.com/mbox/", "series": [ { "id": 19211, "url": "http://patchwork.ozlabs.org/api/series/19211/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=19211", "date": "2017-12-18T10:14:44", "name": "[next,S83-V5,1/9] i40e/i40evf: Enable NVMUpdate to retrieve AdminQ and add preservation flags for NVM update", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/19211/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/850291/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/850291/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z0qD35KRyz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Dec 2017 05:23:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EAE112FE88;\n\tMon, 18 Dec 2017 18:23:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XPPLlVBkIQ35; Mon, 18 Dec 2017 18:23:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 390E22FE37;\n\tMon, 18 Dec 2017 18:23:29 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9DB7D1C2092\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 99E432FE37\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:27 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WeQGPKcHeAjE for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:27 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 0DBE22FDFC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:23:27 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Dec 2017 10:23:26 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Dec 2017 10:23:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,422,1508828400\"; d=\"scan'208\";a=\"14612213\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 18 Dec 2017 05:16:43 -0500", "Message-Id": "<20171218101643.75775-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S83-V5 4/9] i40evf: Don't schedule\n\treset_task when device is being removed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Avinash Dayanand <avinash.dayanand@intel.com>\n\nWhen a host disables and enables a PF device, all the associated\nVFs are removed and added back in. It also generates a PFR which in turn\nresets all the connected VFs. This behaviour is different from that of\nLinux guest on Linux host. Hence we end up in a situation where there's\na PFR and device removal at the same time. And watchdog doesn't have a\nclue about this and schedules a reset_task. This patch adds code to send\nsignal to reset_task that the device is currently being removed.\n\nSigned-off-by: Avinash Dayanand <avinash.dayanand@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf.h | 1 +\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 9 ++++++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h\nindex 47040ab..33c0ffc 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h\n@@ -187,6 +187,7 @@ enum i40evf_state_t {\n enum i40evf_critical_section_t {\n \t__I40EVF_IN_CRITICAL_TASK,\t/* cannot be interrupted */\n \t__I40EVF_IN_CLIENT_TASK,\n+\t__I40EVF_IN_REMOVE_TASK,\t/* device being removed */\n };\n \n /* board specific private data structure */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 6472116..0e5df19 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1803,6 +1803,12 @@ static void i40evf_reset_task(struct work_struct *work)\n \tint i = 0, err;\n \tbool running;\n \n+\t/* When device is being removed it doesn't make sense to run the reset\n+\t * task, just return in such a case.\n+\t */\n+\tif (test_bit(__I40EVF_IN_REMOVE_TASK, &adapter->crit_section))\n+\t\treturn;\n+\n \twhile (test_and_set_bit(__I40EVF_IN_CLIENT_TASK,\n \t\t\t\t&adapter->crit_section))\n \t\tusleep_range(500, 1000);\n@@ -3053,7 +3059,8 @@ static void i40evf_remove(struct pci_dev *pdev)\n \tstruct i40evf_mac_filter *f, *ftmp;\n \tstruct i40e_hw *hw = &adapter->hw;\n \tint err;\n-\n+\t/* Indicate we are in remove and not to run reset_task */\n+\tset_bit(__I40EVF_IN_REMOVE_TASK, &adapter->crit_section);\n \tcancel_delayed_work_sync(&adapter->init_task);\n \tcancel_work_sync(&adapter->reset_task);\n \tcancel_delayed_work_sync(&adapter->client_task);\n", "prefixes": [ "next", "S83-V5", "4/9" ] }