Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/850288/?format=api
{ "id": 850288, "url": "http://patchwork.ozlabs.org/api/patches/850288/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171218101525.75683-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171218101525.75683-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-12-18T10:15:25", "name": "[next,S83-V5,2/9] i40e: avoid divide by zero", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5a3710d1cc75dc246f24f6cbc45ce5395654c895", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171218101525.75683-1-alice.michael@intel.com/mbox/", "series": [ { "id": 19211, "url": "http://patchwork.ozlabs.org/api/series/19211/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=19211", "date": "2017-12-18T10:14:44", "name": "[next,S83-V5,1/9] i40e/i40evf: Enable NVMUpdate to retrieve AdminQ and add preservation flags for NVM update", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/19211/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/850288/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/850288/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z0qBd0cjFz9t3G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Dec 2017 05:22:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 990C2885E3;\n\tMon, 18 Dec 2017 18:22:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bMcnnwIOsGkA; Mon, 18 Dec 2017 18:22:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 478BA885B8;\n\tMon, 18 Dec 2017 18:22:14 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B44151C4372\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:22:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AF98587F85\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:22:12 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yniv4sA-QHJS for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:22:11 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1154887FCF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 18 Dec 2017 18:22:10 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Dec 2017 10:22:10 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga008.jf.intel.com with ESMTP; 18 Dec 2017 10:22:10 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,422,1508828400\"; d=\"scan'208\";a=\"3803316\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 18 Dec 2017 05:15:25 -0500", "Message-Id": "<20171218101525.75683-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S83-V5 2/9] i40e: avoid divide by zero", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nIn some weird circumstances with DCB enabled, the firmware can fail to\nconfigure the VSI, leaving us with zero traffic classes. Check for this\nstate when we configure RSS to avoid a panic.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4f74156..7a882d7 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -10839,8 +10839,13 @@ static int i40e_pf_config_rss(struct i40e_pf *pf)\n \t/* Determine the RSS size of the VSI */\n \tif (!vsi->rss_size) {\n \t\tu16 qcount;\n-\n-\t\tqcount = vsi->num_queue_pairs / vsi->tc_config.numtc;\n+\t\t/* If the firmware does something weird during VSI init, we\n+\t\t * could end up with zero TCs. Check for that to avoid\n+\t\t * divide-by-zero. It probably won't pass traffic, but it also\n+\t\t * won't panic.\n+\t\t */\n+\t\tqcount = vsi->num_queue_pairs /\n+\t\t\t (vsi->tc_config.numtc ? vsi->tc_config.numtc : 1);\n \t\tvsi->rss_size = min_t(int, pf->alloc_rss_size, qcount);\n \t}\n \tif (!vsi->rss_size)\n", "prefixes": [ "next", "S83-V5", "2/9" ] }