Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/847679/?format=api
{ "id": 847679, "url": "http://patchwork.ozlabs.org/api/patches/847679/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1513121823-27944-11-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1513121823-27944-11-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2017-12-12T23:37:03", "name": "[v2,next-queue,10/10] ixgbe: register ipsec offload with the xfrm subsystem", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b3c9b706e05a20719ffde77372f00f66cfcd3dab", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1513121823-27944-11-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 18198, "url": "http://patchwork.ozlabs.org/api/series/18198/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=18198", "date": "2017-12-12T23:36:53", "name": "ixgbe: Add ipsec offload", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/18198/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/847679/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/847679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"dcd5oaWl\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yxGTG2BGQz9t2W\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Dec 2017 10:37:38 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8D6DB2FCDB;\n\tTue, 12 Dec 2017 23:37:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id V3Un+HM1Fe3D; Tue, 12 Dec 2017 23:37:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 472972FD0C;\n\tTue, 12 Dec 2017 23:37:35 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A86D91BF54B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Dec 2017 23:37:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 899EF87F45\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Dec 2017 23:37:33 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eYrEZ-RstZAK for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Dec 2017 23:37:32 +0000 (UTC)", "from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 39EA387F3B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Dec 2017 23:37:32 +0000 (UTC)", "from pps.filterd (aserp2130.oracle.com [127.0.0.1])\n\tby aserp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id\n\tvBCNQfDN148581; Tue, 12 Dec 2017 23:37:30 GMT", "from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby aserp2130.oracle.com with ESMTP id 2etrs8r2jj-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 12 Dec 2017 23:37:29 +0000", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tvBCNbTaj028900\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 12 Dec 2017 23:37:29 GMT", "from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBCNbT1S024656; \n\tTue, 12 Dec 2017 23:37:29 GMT", "from slnelson-mint18.us.oracle.com (/10.159.225.160)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 12 Dec 2017 15:37:29 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references;\n\ts=corp-2017-10-26; \n\tbh=TdNuWfQK/wNojb0j9kvzqJnM8uR7JUsKx6f7Re2/TRo=;\n\tb=dcd5oaWl2/ySDITCIzcKaHj5W9BMVJVDMJpi18SmQ4QfJsPVkeypeVGUHu7MhpqmMxOK\n\tzOpGeaebGftH2ybacZ9XCMRGL3xIsA/P6945d9l1k3mvGLKorkMifZVSI91SKtCGoFlr\n\tMOzeDNtZQOZojGdzie94iCncgi0jvic4/pArex2ZxnThTscdOMvzftNFCGPFwDgl9Xpq\n\tEUYo4VZd827uHIC+SH9CKPtJfjIKP1Ghi5ER/w7IuGPMc0j3SwJHunwX8xgPaH5Ad2xv\n\tv85MvyI30yvw1JBSiB3IwBXglOXqWlLeKtSxJJJfGU3ywgpnSnrrit+ZOKI4Mf50hJDq\n\ttA== ", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Tue, 12 Dec 2017 15:37:03 -0800", "Message-Id": "<1513121823-27944-11-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1513121823-27944-1-git-send-email-shannon.nelson@oracle.com>", "References": "<1513121823-27944-1-git-send-email-shannon.nelson@oracle.com>", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=8743\n\tsignatures=668646", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=2\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1711220000 definitions=main-1712120331", "Subject": "[Intel-wired-lan] [PATCH v2 next-queue 10/10] ixgbe: register ipsec\n\toffload with the xfrm subsystem", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "steffen.klassert@secunet.com, netdev@vger.kernel.org,\n\tsowmini.varadhan@oracle.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "With all the support code in place we can now link in the ipsec\noffload operations and set the ESP feature flag for the XFRM\nsubsystem to see.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\nv2: added the xdo_dev_state_free callback to make XFRM happy\n changed use of NETIF_F_HW_CSUM_BIT to NETIF_F_HW_CSUM\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 17 +++++++++++++++++\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++++\n 2 files changed, 21 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex ed3a4c8..4949ea9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -715,10 +715,23 @@ static bool ixgbe_ipsec_offload_ok(struct sk_buff *skb, struct xfrm_state *xs)\n \treturn true;\n }\n \n+/**\n+ * ixgbe_ipsec_free - called by xfrm garbage collections\n+ * @xs: pointer to transformer state struct\n+ *\n+ * We don't have any garbage to collect, so we shouldn't bother\n+ * implementing this function, but the XFRM code doesn't check for\n+ * existence before calling the API callback.\n+ **/\n+static void ixgbe_ipsec_free(struct xfrm_state *xs)\n+{\n+}\n+\n static const struct xfrmdev_ops ixgbe_xfrmdev_ops = {\n \t.xdo_dev_state_add = ixgbe_ipsec_add_sa,\n \t.xdo_dev_state_delete = ixgbe_ipsec_del_sa,\n \t.xdo_dev_offload_ok = ixgbe_ipsec_offload_ok,\n+\t.xdo_dev_state_free = ixgbe_ipsec_free,\n };\n \n /**\n@@ -877,6 +890,10 @@ void ixgbe_init_ipsec_offload(struct ixgbe_adapter *adapter)\n \tixgbe_ipsec_stop_engine(adapter);\n \tixgbe_ipsec_clear_hw_tables(adapter);\n \n+\tadapter->netdev->xfrmdev_ops = &ixgbe_xfrmdev_ops;\n+\tadapter->netdev->features |= NETIF_F_HW_ESP;\n+\tadapter->netdev->hw_enc_features |= NETIF_F_HW_ESP;\n+\n \treturn;\n \n err2:\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 814268f..2e5d0a2 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9796,6 +9796,10 @@ ixgbe_features_check(struct sk_buff *skb, struct net_device *dev,\n \tif (skb->encapsulation && !(features & NETIF_F_TSO_MANGLEID))\n \t\tfeatures &= ~NETIF_F_TSO;\n \n+\t/* IPsec offload doesn't get along well with others *yet* */\n+\tif (skb->sp)\n+\t\tfeatures &= ~(NETIF_F_TSO | NETIF_F_HW_CSUM);\n+\n \treturn features;\n }\n \n", "prefixes": [ "v2", "next-queue", "10/10" ] }