Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/847158/?format=api
{ "id": 847158, "url": "http://patchwork.ozlabs.org/api/patches/847158/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171211183659.21524.88045.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171211183659.21524.88045.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2017-12-11T18:36:59", "name": "[3/9] ixgbevf: use length to determine if descriptor is done", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "88a88d0cf7cdfe92501ae193f38ddc21d8b4ac13", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171211183659.21524.88045.stgit@localhost6.localdomain6/mbox/", "series": [ { "id": 17925, "url": "http://patchwork.ozlabs.org/api/series/17925/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=17925", "date": "2017-12-11T18:36:44", "name": "ixgbevf: update Rx/Tx code path for build_skb", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/17925/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/847158/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/847158/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ywWm84FnBz9s03\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Dec 2017 05:32:56 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9AB8287277;\n\tMon, 11 Dec 2017 18:32:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id w79BYQXYt8IJ; Mon, 11 Dec 2017 18:32:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DED0487268;\n\tMon, 11 Dec 2017 18:32:51 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1B5B51BFA4B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 18:32:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 17DF825D87\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 18:32:50 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id i-XRWsxPvr3N for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 18:32:49 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 1150225D72\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 18:32:49 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Dec 2017 10:32:48 -0800", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.177.96])\n\tby FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2017 10:32:48 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,392,1508828400\"; d=\"scan'208\";a=\"10991727\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 11 Dec 2017 10:36:59 -0800", "Message-ID": "<20171211183659.21524.88045.stgit@localhost6.localdomain6>", "In-Reply-To": "<20171211183537.21524.10133.stgit@localhost6.localdomain6>", "References": "<20171211183537.21524.10133.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 3/9] ixgbevf: use length to determine if\n\tdescriptor is done", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Based on:\ncommit 7ec0116c9131 (\"igb: Use length to determine if descriptor is done\")\n\nThis change makes it so that we use the length of the packet instead of the\nDD status bit to determine if a new descriptor is ready to be processed.\nThe obvious advantage is that it cuts down on reads as we don't really even\nneed the DD bit if going from a 0 to a non-zero value on size is enough to\ninform us that the packet has been completed.\n\nIn addition we only reset the Rx descriptor length for descriptor zero when\nresetting a ring instead of having to do a memset with 0 over the entire\nring. By doing this we can save some time on initialization.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 0cc2688..725fe2d 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -653,8 +653,8 @@ static void ixgbevf_alloc_rx_buffers(struct ixgbevf_ring *rx_ring,\n \t\t\ti -= rx_ring->count;\n \t\t}\n \n-\t\t/* clear the hdr_addr for the next_to_use descriptor */\n-\t\trx_desc->read.hdr_addr = 0;\n+\t\t/* clear the length for the next_to_use descriptor */\n+\t\trx_desc->wb.upper.length = 0;\n \n \t\tcleaned_count--;\n \t} while (cleaned_count);\n@@ -938,7 +938,7 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,\n \n \t\trx_desc = IXGBEVF_RX_DESC(rx_ring, rx_ring->next_to_clean);\n \n-\t\tif (!ixgbevf_test_staterr(rx_desc, IXGBE_RXD_STAT_DD))\n+\t\tif (!rx_desc->wb.upper.length)\n \t\t\tbreak;\n \n \t\t/* This memory barrier is needed to keep us from reading\n@@ -1729,6 +1729,7 @@ static void ixgbevf_configure_rx_ring(struct ixgbevf_adapter *adapter,\n \t\t\t\t struct ixgbevf_ring *ring)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n+\tunion ixgbe_adv_rx_desc *rx_desc;\n \tu64 rdba = ring->dma;\n \tu32 rxdctl;\n \tu8 reg_idx = ring->reg_idx;\n@@ -1757,6 +1758,10 @@ static void ixgbevf_configure_rx_ring(struct ixgbevf_adapter *adapter,\n \tIXGBE_WRITE_REG(hw, IXGBE_VFRDT(reg_idx), 0);\n \tring->tail = adapter->io_addr + IXGBE_VFRDT(reg_idx);\n \n+\t/* initialize Rx descriptor 0 */\n+\trx_desc = IXGBEVF_RX_DESC(ring, 0);\n+\trx_desc->wb.upper.length = 0;\n+\n \t/* reset ntu and ntc to place SW in sync with hardwdare */\n \tring->next_to_clean = 0;\n \tring->next_to_use = 0;\n@@ -2141,9 +2146,6 @@ static void ixgbevf_clean_rx_ring(struct ixgbevf_ring *rx_ring)\n \n \tsize = sizeof(struct ixgbevf_rx_buffer) * rx_ring->count;\n \tmemset(rx_ring->rx_buffer_info, 0, size);\n-\n-\t/* Zero out the descriptor ring */\n-\tmemset(rx_ring->desc, 0, rx_ring->size);\n }\n \n /**\n", "prefixes": [ "3/9" ] }