Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/846825/?format=api
{ "id": 846825, "url": "http://patchwork.ozlabs.org/api/patches/846825/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171211072640.7935-1-bpoirier@suse.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171211072640.7935-1-bpoirier@suse.com>", "list_archive_url": null, "date": "2017-12-11T07:26:40", "name": "e1000e: Fix e1000_check_for_copper_link_ich8lan return value.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cbe5500416e2c1afaaa3c48edf0bf1d4e71e0bd8", "submitter": { "id": 67008, "url": "http://patchwork.ozlabs.org/api/people/67008/?format=api", "name": "Benjamin Poirier", "email": "bpoirier@suse.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171211072640.7935-1-bpoirier@suse.com/mbox/", "series": [ { "id": 17801, "url": "http://patchwork.ozlabs.org/api/series/17801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=17801", "date": "2017-12-11T07:26:40", "name": "e1000e: Fix e1000_check_for_copper_link_ich8lan return value.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/17801/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/846825/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/846825/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ywF0c045zz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Dec 2017 18:27:42 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 528BB2FFFE;\n\tMon, 11 Dec 2017 07:27:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DKuNCLv40cwx; Mon, 11 Dec 2017 07:27:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 051102FFB2;\n\tMon, 11 Dec 2017 07:27:36 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 181B91C11F8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 07:27:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 13A7D88F19\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 07:27:35 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id n9YgwQG6k8uc for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 07:27:34 +0000 (UTC)", "from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id D91CD88F18\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Dec 2017 07:27:33 +0000 (UTC)", "from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id A2830ABD0;\n\tMon, 11 Dec 2017 07:27:30 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "by amavisd-new at test-mx.suse.de" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Benjamin Poirier <bpoirier@suse.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Mon, 11 Dec 2017 16:26:40 +0900", "Message-Id": "<20171211072640.7935-1-bpoirier@suse.com>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20171208114552.5f517fd3@leda>", "References": "<20171208114552.5f517fd3@leda>", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Fix\n\te1000_check_for_copper_link_ich8lan return value.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Ben Hutchings <ben.hutchings@codethink.co.uk>,\n\tGabriel C <nix.or.die@gmail.com>, netdev@vger.kernel.org,\n\tChristian Hesse <list@eworm.de>, stable@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "e1000e_check_for_copper_link() and e1000_check_for_copper_link_ich8lan()\nare the two functions that may be assigned to mac.ops.check_for_link when\nphy.media_type == e1000_media_type_copper. Commit 19110cfbb34d (\"e1000e:\nSeparate signaling for link check/link up\") changed the meaning of the\nreturn value of check_for_link for copper media but only adjusted the first\nfunction. This patch adjusts the second function likewise.\n\nReported-by: Christian Hesse <list@eworm.de>\nReported-by: Gabriel C <nix.or.die@gmail.com>\nLink: https://bugzilla.kernel.org/show_bug.cgi?id=198047\nFixes: 19110cfbb34d (\"e1000e: Separate signaling for link check/link up\")\nTested-by: Christian Hesse <list@eworm.de>\nSigned-off-by: Benjamin Poirier <bpoirier@suse.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex d6d4ed7acf03..31277d3bb7dc 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -1367,6 +1367,9 @@ static s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force)\n * Checks to see of the link status of the hardware has changed. If a\n * change in link status has been detected, then we read the PHY registers\n * to get the current speed/duplex if link exists.\n+ *\n+ * Returns a negative error code (-E1000_ERR_*) or 0 (link down) or 1 (link\n+ * up).\n **/\n static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n {\n@@ -1382,7 +1385,7 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n \t * Change or Rx Sequence Error interrupt.\n \t */\n \tif (!mac->get_link_status)\n-\t\treturn 0;\n+\t\treturn 1;\n \n \t/* First we want to see if the MII Status Register reports\n \t * link. If so, then we want to get the current speed/duplex\n@@ -1613,10 +1616,12 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n \t * different link partner.\n \t */\n \tret_val = e1000e_config_fc_after_link_up(hw);\n-\tif (ret_val)\n+\tif (ret_val) {\n \t\te_dbg(\"Error configuring flow control\\n\");\n+\t\treturn ret_val;\n+\t}\n \n-\treturn ret_val;\n+\treturn 1;\n }\n \n static s32 e1000_get_variants_ich8lan(struct e1000_adapter *adapter)\n", "prefixes": [] }