Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/845268/?format=api
{ "id": 845268, "url": "http://patchwork.ozlabs.org/api/patches/845268/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171206172515.37577-3-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171206172515.37577-3-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-12-06T17:25:12", "name": "[3/6] fm10k: stop adding VLAN 0 to the VLAN table", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a37552c0f217b462abf543690a16e8288fca79fb", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171206172515.37577-3-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 17078, "url": "http://patchwork.ozlabs.org/api/series/17078/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=17078", "date": "2017-12-06T17:25:12", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/17078/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/845268/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/845268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ysQVy15syz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Dec 2017 04:25:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7696B2FE65;\n\tWed, 6 Dec 2017 17:25:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vVrkyA7C8Dlw; Wed, 6 Dec 2017 17:25:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E4CDD2FE32;\n\tWed, 6 Dec 2017 17:25:42 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A38F41C3E85\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Dec 2017 17:25:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9E1518805C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Dec 2017 17:25:40 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CWyFwu5luHvv for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Dec 2017 17:25:39 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E072A8812C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Dec 2017 17:25:38 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Dec 2017 09:25:38 -0800", "from jtkirshe-desk.jf.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([134.134.177.65])\n\tby orsmga002.jf.intel.com with ESMTP; 06 Dec 2017 09:25:37 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,369,1508828400\"; d=\"scan'208\";a=\"16002185\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 6 Dec 2017 09:25:12 -0800", "Message-Id": "<20171206172515.37577-3-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20171206172515.37577-1-jeffrey.t.kirsher@intel.com>", "References": "<20171206172515.37577-1-jeffrey.t.kirsher@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 3/6] fm10k: stop adding VLAN 0 to the VLAN\n\ttable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nCurrently, when the driver loads, it sends a request to add VLAN 0 to the\nVLAN table. For the PF, this is honored, and VLAN 0 is indeed set. For\nthe VF, this request is silently converted into a request for the\ndefault VLAN as defined by either the switch vid or the PF vid.\n\nThis results in the odd behavior that the VLAN table doesn't appear\nconsistent between the PF and the VF.\n\nFurthermore, setting a MAC filter with VLAN 0 is generally considered an\ninvalid configuration by the switch, and since commit 856dfd69e84f\n(\"fm10k: Fix multicast mode synch issues\", 2016-03-03) we've had code\nwhich prevents us from ever sending such a request.\n\nSince there's not really a good reason to keep VLAN 0 in the VLAN table,\nstop requesting it in fm10k_restore_rx_state().\n\nThis might seem to indicate that we would no longer properly configure\nthe MAC and VLAN tables for the default vid. However, due to the way\nthat fm10k_find_next_vlan() behaves, it will always return the\ndefault_vid as enabled.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex f8e2d1804a17..d79bff7c23f7 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -1221,9 +1221,6 @@ void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n \tfm10k_queue_vlan_request(interface, FM10K_VLAN_ALL, 0,\n \t\t\t\t xcast_mode == FM10K_XCAST_MODE_PROMISC);\n \n-\t/* Add filter for VLAN 0 */\n-\tfm10k_queue_vlan_request(interface, 0, 0, true);\n-\n \t/* update table with current entries */\n \tfor (vid = hw->mac.default_vid ? fm10k_find_next_vlan(interface, 0) : 1;\n \t vid < VLAN_N_VID;\n", "prefixes": [ "3/6" ] }