Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/844381/?format=api
{ "id": 844381, "url": "http://patchwork.ozlabs.org/api/patches/844381/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171204192831.18344-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171204192831.18344-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2017-12-04T19:28:30", "name": "[1/2] ixgbe: Fix kernel-doc format warnings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce54fda54b5f7ad20cefd79c504c70e0fc21fb62", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171204192831.18344-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 16662, "url": "http://patchwork.ozlabs.org/api/series/16662/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=16662", "date": "2017-12-04T19:28:31", "name": "[1/2] ixgbe: Fix kernel-doc format warnings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/16662/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/844381/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/844381/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yrFRm5gNQz9s1h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Dec 2017 06:33:56 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 56BB489329;\n\tMon, 4 Dec 2017 19:33:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dNRXyRFz4bS5; Mon, 4 Dec 2017 19:33:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DEC0E88DBD;\n\tMon, 4 Dec 2017 19:33:51 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 29FCB1C0AE4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Dec 2017 19:33:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 252D2873A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Dec 2017 19:33:49 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dXAYiFGDlC8P for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Dec 2017 19:33:47 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id ED7C6873A0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Dec 2017 19:33:46 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Dec 2017 11:33:46 -0800", "from unknown (HELO anguy11-linux.jf.intel.com) ([10.165.248.57])\n\tby FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2017 11:33:45 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,361,1508828400\"; d=\"scan'208\";a=\"8981171\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 4 Dec 2017 11:28:30 -0800", "Message-Id": "<20171204192831.18344-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [PATCH 1/2] ixgbe: Fix kernel-doc format warnings", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Recent checks added for formatting kernel-doc comments are causing warnings\nif W= is run with a non-zero value. This patch fixes function comments to\nresolve warnings when W=1 is used.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c | 3 ++-\n drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 11 +++++---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 9 ++++---\n drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.c | 10 +++++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c | 22 +++++++++++----\n drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82599.c | 5 +++-\n drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 3 ++-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 31 ++++++++++++++--------\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 15 +++++++++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 8 +++---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 19 ++++++++++---\n 12 files changed, 99 insertions(+), 39 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\nindex 8a32eb7..a0ebd9e 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n@@ -431,6 +431,7 @@ static s32 ixgbe_fc_enable_82598(struct ixgbe_hw *hw)\n /**\n * ixgbe_start_mac_link_82598 - Configures MAC link settings\n * @hw: pointer to hardware structure\n+ * @autoneg_wait_to_complete: true when waiting for completion is needed\n *\n * Configures link settings based on values in the ixgbe_hw struct.\n * Restarts the link. Performs autonegotiation if needed.\n@@ -1054,7 +1055,7 @@ static s32 ixgbe_read_i2c_eeprom_82598(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_read_i2c_sff8472_82598 - Reads 8 bit word over I2C interface.\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset at address 0xA2\n- * @eeprom_data: value read\n+ * @sff8472_data: value read\n *\n * Performs 8 byte read operation to SFP module's SFF-8472 data over I2C\n **/\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\nindex d602637..4dfc81d 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n@@ -221,7 +221,7 @@ static s32 prot_autoc_read_82599(struct ixgbe_hw *hw, bool *locked,\n /**\n * prot_autoc_write_82599 - Hides MAC differences needed for AUTOC write\n * @hw: pointer to hardware structure\n- * @reg_val: value to write to AUTOC\n+ * @autoc: value to write to AUTOC\n * @locked: bool to indicate whether the SW/FW lock was already taken by\n *\t previous proc_autoc_read_82599.\n *\n@@ -1310,10 +1310,11 @@ do { \\\n \n /**\n * ixgbe_atr_compute_sig_hash_82599 - Compute the signature hash\n- * @stream: input bitstream to compute the hash on\n+ * @input: input bitstream to compute the hash on\n+ * @common: compressed common input dword\n *\n * This function is almost identical to the function above but contains\n- * several optomizations such as unwinding all of the loops, letting the\n+ * several optimizations such as unwinding all of the loops, letting the\n * compiler work out all of the conditional ifs since the keys are static\n * defines, and computing two keys at once since the hashed dword stream\n * will be the same for both keys.\n@@ -1446,7 +1447,7 @@ do { \\\n \n /**\n * ixgbe_atr_compute_perfect_hash_82599 - Compute the perfect filter hash\n- * @atr_input: input bitstream to compute the hash on\n+ * @input: input bitstream to compute the hash on\n * @input_mask: mask for the input bitstream\n *\n * This function serves two main purposes. First it applies the input_mask\n@@ -2078,6 +2079,7 @@ static s32 ixgbe_reset_pipeline_82599(struct ixgbe_hw *hw)\n * ixgbe_read_i2c_byte_82599 - Reads 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to read\n+ * @dev_addr: address to read from\n * @data: value read\n *\n * Performs byte read operation to SFP module's EEPROM over I2C interface at\n@@ -2131,6 +2133,7 @@ static s32 ixgbe_read_i2c_byte_82599(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_write_i2c_byte_82599 - Writes 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to write\n+ * @dev_addr: address to write to\n * @data: value to write\n *\n * Performs byte write operation to SFP module's EEPROM over I2C interface at\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 1948e42..7ac7ef9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -1613,6 +1613,7 @@ static void ixgbe_shift_out_eeprom_bits(struct ixgbe_hw *hw, u16 data,\n /**\n * ixgbe_shift_in_eeprom_bits - Shift data bits in from the EEPROM\n * @hw: pointer to hardware structure\n+ * @count: number of bits to shift\n **/\n static u16 ixgbe_shift_in_eeprom_bits(struct ixgbe_hw *hw, u16 count)\n {\n@@ -1667,7 +1668,7 @@ static void ixgbe_raise_eeprom_clk(struct ixgbe_hw *hw, u32 *eec)\n /**\n * ixgbe_lower_eeprom_clk - Lowers the EEPROM's clock input.\n * @hw: pointer to hardware structure\n- * @eecd: EECD's current value\n+ * @eec: EEC's current value\n **/\n static void ixgbe_lower_eeprom_clk(struct ixgbe_hw *hw, u32 *eec)\n {\n@@ -2037,7 +2038,7 @@ static s32 ixgbe_mta_vector(struct ixgbe_hw *hw, u8 *mc_addr)\n /**\n * ixgbe_set_mta - Set bit-vector in multicast table\n * @hw: pointer to hardware structure\n- * @hash_value: Multicast address hash value\n+ * @mc_addr: Multicast address\n *\n * Sets the bit-vector in the multicast table.\n **/\n@@ -3086,6 +3087,8 @@ s32 ixgbe_init_uta_tables_generic(struct ixgbe_hw *hw)\n * ixgbe_find_vlvf_slot - find the vlanid or the first empty slot\n * @hw: pointer to hardware structure\n * @vlan: VLAN id to write to VLAN filter\n+ * @vlvf_bypass: true to find vlanid only, false returns first empty slot if\n+ *\t\t vlanid not found\n *\n * return the VLVF index where this VLAN id should be placed\n *\n@@ -3476,7 +3479,7 @@ void ixgbe_set_mac_anti_spoofing(struct ixgbe_hw *hw, bool enable, int vf)\n * ixgbe_set_vlan_anti_spoofing - Enable/Disable VLAN anti-spoofing\n * @hw: pointer to hardware structure\n * @enable: enable or disable switch for VLAN anti-spoofing\n- * @pf: Virtual Function pool - VF Pool to set for VLAN anti-spoofing\n+ * @vf: Virtual Function pool - VF Pool to set for VLAN anti-spoofing\n *\n **/\n void ixgbe_set_vlan_anti_spoofing(struct ixgbe_hw *hw, bool enable, int vf)\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.c\nindex 072ef3b..aaea828 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.c\n@@ -39,6 +39,10 @@\n * are the smallest unit programmable into the underlying\n * hardware. The IEEE 802.1Qaz specification do not use bandwidth\n * groups so this is much simplified from the CEE case.\n+ * @bw: bandwidth index by traffic class\n+ * @refill: refill credits index by traffic class\n+ * @max: max credits by traffic class\n+ * @max_frame: maximum frame size\n */\n static s32 ixgbe_ieee_credits(__u8 *bw, __u16 *refill,\n \t\t\t __u16 *max, int max_frame)\n@@ -72,8 +76,10 @@ static s32 ixgbe_ieee_credits(__u8 *bw, __u16 *refill,\n \n /**\n * ixgbe_dcb_calculate_tc_credits - Calculates traffic class credits\n- * @ixgbe_dcb_config: Struct containing DCB settings.\n- * @direction: Configuring either Tx or Rx.\n+ * @hw: pointer to hardware structure\n+ * @dcb_config: Struct containing DCB settings\n+ * @max_frame: Maximum frame size\n+ * @direction: Configuring either Tx or Rx\n *\n * This function calculates the credits allocated to each traffic class.\n * It should be called only after the rules are checked by\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c\nindex b79e93a..f94c7e8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c\n@@ -34,7 +34,9 @@\n /**\n * ixgbe_dcb_config_rx_arbiter_82598 - Config Rx data arbiter\n * @hw: pointer to hardware structure\n- * @dcb_config: pointer to ixgbe_dcb_config structure\n+ * @refill: refill credits index by traffic class\n+ * @max: max credits index by traffic class\n+ * @prio_type: priority type indexed by traffic class\n *\n * Configure Rx Data Arbiter and credits for each traffic class.\n */\n@@ -91,7 +93,10 @@ s32 ixgbe_dcb_config_rx_arbiter_82598(struct ixgbe_hw *hw,\n /**\n * ixgbe_dcb_config_tx_desc_arbiter_82598 - Config Tx Desc. arbiter\n * @hw: pointer to hardware structure\n- * @dcb_config: pointer to ixgbe_dcb_config structure\n+ * @refill: refill credits index by traffic class\n+ * @max: max credits index by traffic class\n+ * @bwg_id: bandwidth grouping indexed by traffic class\n+ * @prio_type: priority type indexed by traffic class\n *\n * Configure Tx Descriptor Arbiter and credits for each traffic class.\n */\n@@ -137,7 +142,10 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw,\n /**\n * ixgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter\n * @hw: pointer to hardware structure\n- * @dcb_config: pointer to ixgbe_dcb_config structure\n+ * @refill: refill credits index by traffic class\n+ * @max: max credits index by traffic class\n+ * @bwg_id: bandwidth grouping indexed by traffic class\n+ * @prio_type: priority type indexed by traffic class\n *\n * Configure Tx Data Arbiter and credits for each traffic class.\n */\n@@ -184,7 +192,7 @@ s32 ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw,\n /**\n * ixgbe_dcb_config_pfc_82598 - Config priority flow control\n * @hw: pointer to hardware structure\n- * @dcb_config: pointer to ixgbe_dcb_config structure\n+ * @pfc_en: enabled pfc bitmask\n *\n * Configure Priority Flow Control for each traffic class.\n */\n@@ -269,7 +277,11 @@ static s32 ixgbe_dcb_config_tc_stats_82598(struct ixgbe_hw *hw)\n /**\n * ixgbe_dcb_hw_config_82598 - Config and enable DCB\n * @hw: pointer to hardware structure\n- * @dcb_config: pointer to ixgbe_dcb_config structure\n+ * @pfc_en: enabled pfc bitmask\n+ * @refill: refill credits index by traffic class\n+ * @max: max credits index by traffic class\n+ * @bwg_id: bandwidth grouping indexed by traffic class\n+ * @prio_type: priority type indexed by traffic class\n *\n * Configure dcb settings and enable dcb mode.\n */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82599.c\nindex 1011d64..1eed681 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82599.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82599.c\n@@ -38,6 +38,7 @@\n * @max: max credits index by traffic class\n * @bwg_id: bandwidth grouping indexed by traffic class\n * @prio_type: priority type indexed by traffic class\n+ * @prio_tc: priority to tc assignments indexed by priority\n *\n * Configure Rx Packet Arbiter and credits for each traffic class.\n */\n@@ -148,6 +149,7 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82599(struct ixgbe_hw *hw,\n * @max: max credits index by traffic class\n * @bwg_id: bandwidth grouping indexed by traffic class\n * @prio_type: priority type indexed by traffic class\n+ * @prio_tc: priority to tc assignments indexed by priority\n *\n * Configure Tx Packet Arbiter and credits for each traffic class.\n */\n@@ -344,11 +346,12 @@ static s32 ixgbe_dcb_config_tc_stats_82599(struct ixgbe_hw *hw)\n /**\n * ixgbe_dcb_hw_config_82599 - Configure and enable DCB\n * @hw: pointer to hardware structure\n+ * @pfc_en: enabled pfc bitmask\n * @refill: refill credits index by traffic class\n * @max: max credits index by traffic class\n * @bwg_id: bandwidth grouping indexed by traffic class\n * @prio_type: priority type indexed by traffic class\n- * @pfc_en: enabled pfc bitmask\n+ * @prio_tc: priority to tc assignments indexed by priority\n *\n * Configure dcb settings and enable dcb mode.\n */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c\nindex 5e2c1e3..ad54080 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c\n@@ -249,7 +249,7 @@ void ixgbe_dbg_adapter_init(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_dbg_adapter_exit - clear out the adapter's debugfs entries\n- * @pf: the pf that is stopping\n+ * @adapter: the adapter that is exiting\n **/\n void ixgbe_dbg_adapter_exit(struct ixgbe_adapter *adapter)\n {\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c\nindex 6e6b3c1..7a09a40 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c\n@@ -150,6 +150,7 @@ int ixgbe_fcoe_ddp_put(struct net_device *netdev, u16 xid)\n * @xid: the exchange id requesting ddp\n * @sgl: the scatter-gather list for this request\n * @sgc: the number of scatter-gather items\n+ * @target_mode: 1 to setup target mode, 0 to setup initiator mode\n *\n * Returns : 1 for success and 0 for no ddp\n */\n@@ -1063,7 +1064,7 @@ int ixgbe_fcoe_get_hbainfo(struct net_device *netdev,\n \n /**\n * ixgbe_fcoe_get_tc - get the current TC that fcoe is mapped to\n- * @adapter - pointer to the device adapter structure\n+ * @adapter: pointer to the device adapter structure\n *\n * Return : TC that FCoE is mapped to\n */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 9500d2a..8125df1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1128,6 +1128,9 @@ static void ixgbe_tx_timeout_reset(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_tx_maxrate - callback to set the maximum per-queue bitrate\n+ * @netdev: network interface device structure\n+ * @queue_index: Tx queue to set\n+ * @maxrate: desired maximum transmit bitrate\n **/\n static int ixgbe_tx_maxrate(struct net_device *netdev,\n \t\t\t int queue_index, u32 maxrate)\n@@ -2025,8 +2028,8 @@ static bool ixgbe_can_reuse_rx_page(struct ixgbe_rx_buffer *rx_buffer)\n * ixgbe_add_rx_frag - Add contents of Rx buffer to sk_buff\n * @rx_ring: rx descriptor ring to transact packets on\n * @rx_buffer: buffer containing page to add\n- * @rx_desc: descriptor containing length of buffer written by hardware\n * @skb: sk_buff to place the data into\n+ * @size: size of data in rx_buffer\n *\n * This function will add the data contained in rx_buffer->page to the skb.\n * This is done either through a direct copy if the data in the buffer is\n@@ -3015,6 +3018,8 @@ static inline void ixgbe_irq_disable_queues(struct ixgbe_adapter *adapter,\n /**\n * ixgbe_irq_enable - Enable default interrupt generation settings\n * @adapter: board private structure\n+ * @queues: enable irqs for queues\n+ * @flush: flush register write\n **/\n static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter, bool queues,\n \t\t\t\t bool flush)\n@@ -3470,6 +3475,7 @@ static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_configure_msi_and_legacy - Initialize PIN (INTA...) and MSI interrupts\n+ * @adapter: board private structure\n *\n **/\n static void ixgbe_configure_msi_and_legacy(struct ixgbe_adapter *adapter)\n@@ -3998,8 +4004,8 @@ static void ixgbe_setup_mrqc(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_configure_rscctl - enable RSC for the indicated ring\n- * @adapter: address of board private structure\n- * @index: index of ring to set\n+ * @adapter: address of board private structure\n+ * @ring: structure containing ring specific data\n **/\n static void ixgbe_configure_rscctl(struct ixgbe_adapter *adapter,\n \t\t\t\t struct ixgbe_ring *ring)\n@@ -4855,9 +4861,11 @@ int ixgbe_del_mac_filter(struct ixgbe_adapter *adapter,\n \n \treturn -ENOMEM;\n }\n+\n /**\n * ixgbe_write_uc_addr_list - write unicast addresses to RAR table\n * @netdev: network interface device structure\n+ * @vfn: pool to associate with unicast addresses\n *\n * Writes unicast address list to the RAR table.\n * Returns: -ENOMEM on failure/insufficient address space\n@@ -6035,6 +6043,7 @@ static void ixgbe_init_dcb(struct ixgbe_adapter *adapter)\n /**\n * ixgbe_sw_init - Initialize general software structures (struct ixgbe_adapter)\n * @adapter: board private structure to initialize\n+ * @ii: pointer to ixgbe_info for device\n *\n * ixgbe_sw_init initializes the Adapter private data structure.\n * Fields are initialized based on PCI device information and\n@@ -6319,6 +6328,7 @@ static int ixgbe_setup_all_tx_resources(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_setup_rx_resources - allocate Rx resources (Descriptors)\n+ * @adapter: pointer to ixgbe_adapter\n * @rx_ring: rx descriptor ring (for a specific queue) to setup\n *\n * Returns 0 on success, negative on failure\n@@ -7125,7 +7135,6 @@ static void ixgbe_check_hang_subtask(struct ixgbe_adapter *adapter)\n /**\n * ixgbe_watchdog_update_link - update the link status\n * @adapter: pointer to the device adapter structure\n- * @link_speed: pointer to a u32 to store the link_speed\n **/\n static void ixgbe_watchdog_update_link(struct ixgbe_adapter *adapter)\n {\n@@ -7578,7 +7587,7 @@ static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_service_timer - Timer Call-back\n- * @data: pointer to adapter cast into an unsigned long\n+ * @t: pointer to timer_list structure\n **/\n static void ixgbe_service_timer(struct timer_list *t)\n {\n@@ -8566,7 +8575,7 @@ static int ixgbe_ioctl(struct net_device *netdev, struct ifreq *req, int cmd)\n /**\n * ixgbe_add_sanmac_netdev - Add the SAN MAC address to the corresponding\n * netdev->dev_addrs\n- * @netdev: network interface device structure\n+ * @dev: network interface device structure\n *\n * Returns non-zero on failure\n **/\n@@ -8590,7 +8599,7 @@ static int ixgbe_add_sanmac_netdev(struct net_device *dev)\n /**\n * ixgbe_del_sanmac_netdev - Removes the SAN MAC address to the corresponding\n * netdev->dev_addrs\n- * @netdev: network interface device structure\n+ * @dev: network interface device structure\n *\n * Returns non-zero on failure\n **/\n@@ -8757,7 +8766,7 @@ static void ixgbe_set_prio_tc_map(struct ixgbe_adapter *adapter)\n /**\n * ixgbe_setup_tc - configure net_device for multiple traffic classes\n *\n- * @netdev: net device to configure\n+ * @dev: net device to configure\n * @tc: number of traffic classes to enable\n */\n int ixgbe_setup_tc(struct net_device *dev, u8 tc)\n@@ -9592,8 +9601,8 @@ static int ixgbe_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],\n \n /**\n * ixgbe_configure_bridge_mode - set various bridge modes\n- * @adapter - the private structure\n- * @mode - requested bridge mode\n+ * @adapter: the private structure\n+ * @mode: requested bridge mode\n *\n * Configure some settings require for various bridge modes.\n **/\n@@ -10061,7 +10070,7 @@ static inline int ixgbe_enumerate_functions(struct ixgbe_adapter *adapter)\n * ixgbe_wol_supported - Check whether device supports WoL\n * @adapter: the adapter private structure\n * @device_id: the device ID\n- * @subdev_id: the subsystem device ID\n+ * @subdevice_id: the subsystem device ID\n *\n * This function is used by probe and ethtool to determine\n * which devices have WoL support\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex 654a402..91bde90 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -378,7 +378,7 @@ static s32 ixgbe_get_phy_id(struct ixgbe_hw *hw)\n \n /**\n * ixgbe_get_phy_type_from_id - Get the phy type\n- * @hw: pointer to hardware structure\n+ * @phy_id: hardware phy id\n *\n **/\n static enum ixgbe_phy_type ixgbe_get_phy_type_from_id(u32 phy_id)\n@@ -489,6 +489,7 @@ s32 ixgbe_reset_phy_generic(struct ixgbe_hw *hw)\n * the SWFW lock\n * @hw: pointer to hardware structure\n * @reg_addr: 32 bit address of PHY register to read\n+ * @device_type: 5 bit device type\n * @phy_data: Pointer to read data from PHY register\n **/\n s32 ixgbe_read_phy_reg_mdi(struct ixgbe_hw *hw, u32 reg_addr, u32 device_type,\n@@ -564,6 +565,7 @@ s32 ixgbe_read_phy_reg_mdi(struct ixgbe_hw *hw, u32 reg_addr, u32 device_type,\n * using the SWFW lock - this function is needed in most cases\n * @hw: pointer to hardware structure\n * @reg_addr: 32 bit address of PHY register to read\n+ * @device_type: 5 bit device type\n * @phy_data: Pointer to read data from PHY register\n **/\n s32 ixgbe_read_phy_reg_generic(struct ixgbe_hw *hw, u32 reg_addr,\n@@ -763,6 +765,7 @@ s32 ixgbe_setup_phy_link_generic(struct ixgbe_hw *hw)\n * ixgbe_setup_phy_link_speed_generic - Sets the auto advertised capabilities\n * @hw: pointer to hardware structure\n * @speed: new link speed\n+ * @autoneg_wait_to_complete: unused\n **/\n s32 ixgbe_setup_phy_link_speed_generic(struct ixgbe_hw *hw,\n \t\t\t\t ixgbe_link_speed speed,\n@@ -861,6 +864,8 @@ s32 ixgbe_get_copper_link_capabilities_generic(struct ixgbe_hw *hw,\n /**\n * ixgbe_check_phy_link_tnx - Determine link and speed status\n * @hw: pointer to hardware structure\n+ * @speed: link speed\n+ * @link_up: status of link\n *\n * Reads the VS1 register to determine if link is up and the current speed for\n * the PHY.\n@@ -1667,7 +1672,7 @@ s32 ixgbe_read_i2c_eeprom_generic(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_read_i2c_sff8472_generic - Reads 8 bit word over I2C interface\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset at address 0xA2\n- * @eeprom_data: value read\n+ * @sff8472_data: value read\n *\n * Performs byte read operation to SFP module's SFF-8472 data over I2C\n **/\n@@ -1714,6 +1719,7 @@ static bool ixgbe_is_sfp_probe(struct ixgbe_hw *hw, u8 offset, u8 addr)\n * ixgbe_read_i2c_byte_generic_int - Reads 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to read\n+ * @dev_addr: device address\n * @data: value read\n * @lock: true if to take and release semaphore\n *\n@@ -1804,6 +1810,7 @@ static s32 ixgbe_read_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_read_i2c_byte_generic - Reads 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to read\n+ * @dev_addr: device address\n * @data: value read\n *\n * Performs byte read operation to SFP module's EEPROM over I2C interface at\n@@ -1820,6 +1827,7 @@ s32 ixgbe_read_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_read_i2c_byte_generic_unlocked - Reads 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to read\n+ * @dev_addr: device address\n * @data: value read\n *\n * Performs byte read operation to SFP module's EEPROM over I2C interface at\n@@ -1836,6 +1844,7 @@ s32 ixgbe_read_i2c_byte_generic_unlocked(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_write_i2c_byte_generic_int - Writes 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to write\n+ * @dev_addr: device address\n * @data: value to write\n * @lock: true if to take and release semaphore\n *\n@@ -1904,6 +1913,7 @@ static s32 ixgbe_write_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_write_i2c_byte_generic - Writes 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to write\n+ * @dev_addr: device address\n * @data: value to write\n *\n * Performs byte write operation to SFP module's EEPROM over I2C interface at\n@@ -1920,6 +1930,7 @@ s32 ixgbe_write_i2c_byte_generic(struct ixgbe_hw *hw, u8 byte_offset,\n * ixgbe_write_i2c_byte_generic_unlocked - Writes 8 bit word over I2C\n * @hw: pointer to hardware structure\n * @byte_offset: byte offset to write\n+ * @dev_addr: device address\n * @data: value to write\n *\n * Performs byte write operation to SFP module's EEPROM over I2C interface at\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\nindex ae312c4..f6cc916 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\n@@ -166,7 +166,7 @@\n \n /**\n * ixgbe_ptp_setup_sdp_x540\n- * @hw: the hardware private structure\n+ * @adapter: private adapter structure\n *\n * this function enables or disables the clock out feature on SDP0 for\n * the X540 device. It will create a 1second periodic output that can\n@@ -299,7 +299,7 @@ static u64 ixgbe_ptp_read_82599(const struct cyclecounter *cc)\n * ixgbe_ptp_convert_to_hwtstamp - convert register value to hw timestamp\n * @adapter: private adapter structure\n * @hwtstamp: stack timestamp structure\n- * @systim: unsigned 64bit system time value\n+ * @timestamp: unsigned 64bit system time value\n *\n * We need to convert the adapter's RX/TXSTMP registers into a hwtstamp value\n * which can be used by the stack's ptp functions.\n@@ -1015,7 +1015,7 @@ static int ixgbe_ptp_set_timestamp_mode(struct ixgbe_adapter *adapter,\n /**\n * ixgbe_ptp_set_ts_config - user entry point for timestamp mode\n * @adapter: pointer to adapter struct\n- * @ifreq: ioctl data\n+ * @ifr: ioctl data\n *\n * Set hardware to requested mode. If unsupported, return an error with no\n * changes. Otherwise, store the mode for future reference.\n@@ -1338,7 +1338,7 @@ void ixgbe_ptp_init(struct ixgbe_adapter *adapter)\n \n /**\n * ixgbe_ptp_suspend - stop PTP work items\n- * @ adapter: pointer to adapter struct\n+ * @adapter: pointer to adapter struct\n *\n * this function suspends PTP activity, and prevents more PTP work from being\n * generated, but does not destroy the PTP clock device.\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex cb7da5f..3bce26e 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1642,10 +1642,12 @@ static s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)\n }\n \n /**\n- * ixgbe_setup_mac_link_sfp_x550em - Configure the KR PHY for SFP.\n- * @hw: pointer to hardware structure\n+ * ixgbe_setup_mac_link_sfp_x550em - Configure the KR PHY for SFP.\n+ * @hw: pointer to hardware structure\n+ * @speed: the link speed to force\n+ * @autoneg_wait_to_complete: unused\n *\n- * Configures the extern PHY and the integrated KR PHY for SFP support.\n+ * Configures the extern PHY and the integrated KR PHY for SFP support.\n */\n static s32\n ixgbe_setup_mac_link_sfp_x550em(struct ixgbe_hw *hw,\n@@ -1737,6 +1739,8 @@ static s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)\n /**\n * ixgbe_setup_mac_link_sfp_n - Setup internal PHY for native SFP\n * @hw: pointer to hardware structure\n+ * @speed: link speed\n+ * @autoneg_wait_to_complete: unused\n *\n * Configure the the integrated PHY for native SFP support.\n */\n@@ -1784,6 +1788,8 @@ ixgbe_setup_mac_link_sfp_n(struct ixgbe_hw *hw, ixgbe_link_speed speed,\n /**\n * ixgbe_setup_mac_link_sfp_x550a - Setup internal PHY for SFP\n * @hw: pointer to hardware structure\n+ * @speed: link speed\n+ * @autoneg_wait_to_complete: unused\n *\n * Configure the the integrated PHY for SFP support.\n */\n@@ -1859,7 +1865,7 @@ ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw, ixgbe_link_speed speed,\n * ixgbe_setup_mac_link_t_X550em - Sets the auto advertised link speed\n * @hw: pointer to hardware structure\n * @speed: new link speed\n- * @autoneg_wait_to_complete: true when waiting for completion is needed\n+ * @autoneg_wait: true when waiting for completion is needed\n *\n * Setup internal/external PHY link speed based on link speed, then set\n * external PHY auto advertised link speed.\n@@ -1943,6 +1949,8 @@ static s32 ixgbe_check_link_t_X550em(struct ixgbe_hw *hw,\n /**\n * ixgbe_setup_sgmii - Set up link for sgmii\n * @hw: pointer to hardware structure\n+ * @speed: unused\n+ * @autoneg_wait_to_complete: unused\n */\n static s32\n ixgbe_setup_sgmii(struct ixgbe_hw *hw, __always_unused ixgbe_link_speed speed,\n@@ -2014,6 +2022,8 @@ ixgbe_setup_sgmii(struct ixgbe_hw *hw, __always_unused ixgbe_link_speed speed,\n /**\n * ixgbe_setup_sgmii_fw - Set up link for sgmii with firmware-controlled PHYs\n * @hw: pointer to hardware structure\n+ * @speed: the link speed to force\n+ * @autoneg_wait: true when waiting for completion is needed\n */\n static s32 ixgbe_setup_sgmii_fw(struct ixgbe_hw *hw, ixgbe_link_speed speed,\n \t\t\t\tbool autoneg_wait)\n@@ -3735,6 +3745,7 @@ static void ixgbe_release_swfw_sync_x550em_a(struct ixgbe_hw *hw, u32 mask)\n * ixgbe_read_phy_reg_x550a - Reads specified PHY register\n * @hw: pointer to hardware structure\n * @reg_addr: 32 bit address of PHY register to read\n+ * @device_type: 5 bit device type\n * @phy_data: Pointer to read data from PHY register\n *\n * Reads a value from a specified PHY register using the SWFW lock and PHY\n", "prefixes": [ "1/2" ] }