Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 842653,
    "url": "http://patchwork.ozlabs.org/api/patches/842653/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/kvm-ppc/patch/20171129164116.16167-13-christoffer.dall@linaro.org/",
    "project": {
        "id": 23,
        "url": "http://patchwork.ozlabs.org/api/projects/23/?format=api",
        "name": "KVM PowerPC development",
        "link_name": "kvm-ppc",
        "list_id": "kvm-ppc.vger.kernel.org",
        "list_email": "kvm-ppc@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20171129164116.16167-13-christoffer.dall@linaro.org>",
    "list_archive_url": null,
    "date": "2017-11-29T16:41:12",
    "name": "[v2,12/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_get_fpu",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "ed91ad3b14b20a12495603a634e9cec87e2b1cb0",
    "submitter": {
        "id": 26352,
        "url": "http://patchwork.ozlabs.org/api/people/26352/?format=api",
        "name": "Christoffer Dall",
        "email": "christoffer.dall@linaro.org"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/kvm-ppc/patch/20171129164116.16167-13-christoffer.dall@linaro.org/mbox/",
    "series": [
        {
            "id": 15778,
            "url": "http://patchwork.ozlabs.org/api/series/15778/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/kvm-ppc/list/?series=15778",
            "date": "2017-11-29T16:41:00",
            "name": "Move vcpu_load and vcpu_put calls to arch code",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/15778/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/842653/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/842653/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<kvm-ppc-owner@vger.kernel.org>",
        "X-Original-To": "incoming@patchwork.ozlabs.org",
        "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"IwSwInD3\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yn5sV3Np4z9t3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 Nov 2017 03:41:50 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932202AbdK2Qls (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 29 Nov 2017 11:41:48 -0500",
            "from mail-wm0-f68.google.com ([74.125.82.68]:45572 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933782AbdK2Qlk (ORCPT\n\t<rfc822;kvm-ppc@vger.kernel.org>); Wed, 29 Nov 2017 11:41:40 -0500",
            "by mail-wm0-f68.google.com with SMTP id 9so7568404wme.4\n\tfor <kvm-ppc@vger.kernel.org>; Wed, 29 Nov 2017 08:41:40 -0800 (PST)",
            "from localhost.localdomain (x50d2404e.cust.hiper.dk.\n\t[80.210.64.78]) by smtp.gmail.com with ESMTPSA id\n\te71sm2080765wma.13.2017.11.29.08.41.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 29 Nov 2017 08:41:38 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bXfLhAEXBmFfhF4Y9EDpbD2ojmAQNtJrWASQpFnQlEs=;\n\tb=IwSwInD36GPInvsJ0rPss88a+UA6wsQ8lggIfAwjr3lAtr/3k5WXNcg9GNkbu4ca0f\n\tp96o1AHcYIPWFYraqTzXnq/hiGimLCq8/FfIWYtm5bG/aSWv9+3EKj+/lQ9+Vm3sMT0y\n\t6QKLG7P9R8wkxOdHl53Jzmj2GdKyWalPeTD2U=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bXfLhAEXBmFfhF4Y9EDpbD2ojmAQNtJrWASQpFnQlEs=;\n\tb=rmNOChbufeWyQb+JTV9GTU1qGe78akOFtKjK2HU11Y7BeBjkIP60sbMzXpmOgGDCxn\n\tJhUJ6g29wjSOGhkQjiKKWuxTmg9PBu5ccFx6h57tFZyX2Xc3sqbADoUsmT9pcz0TqTSW\n\tMe41YFKOV+oN3YUQxnXlJYrdEqs2OTuIHRXtotRkWMwNPv/iY4le+iqpO6G1oHs6cGoN\n\tbxNhE3WVRkVmtBwWkkwBCxhN9iMpLvqoTQ5Y2vBSw2CbLVMXpQKc6KqdGthUIhCLPi9w\n\t44ZKPWar8iY4/3l1k28Mh4hXrfCLfUVoetpFn8oveI8hH++zDdtzatrwXvjcI5+emjNd\n\tymYA==",
        "X-Gm-Message-State": "AJaThX4eP+F1IGhsi4p8fUwG5uc506vcouuZjM7u5qg4Al1/uKInJhhn\n\tnFXLnzZdXJvNBYrq4+uShKL3lg==",
        "X-Google-Smtp-Source": "AGs4zMbv+G1mcEGiWdi3mpvG9Runv4gYfnIkUrUzinx+nm7bxOIVZQoI1SLzwC/GXbalj4pstlCC2g==",
        "X-Received": "by 10.28.46.136 with SMTP id u130mr2680657wmu.127.1511973699600; \n\tWed, 29 Nov 2017 08:41:39 -0800 (PST)",
        "From": "Christoffer Dall <christoffer.dall@linaro.org>",
        "To": "kvm@vger.kernel.org",
        "Cc": "Andrew Jones <drjones@redhat.com>, Christoffer Dall\n\t<christoffer.dall@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,\n\tMarc Zyngier <marc.zyngier@arm.com>, kvmarm@lists.cs.columbia.edu,\n\tlinux-arm-kernel@lists.infradead.org, James Hogan <jhogan@kernel.org>,\n\tlinux-mips@linux-mips.org, Alexander Graf <agraf@suse.com>,\n\tkvm-ppc@vger.kernel.org, \n\tChristian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck\n\t<cohuck@redhat.com>, linux-s390@vger.kernel.org",
        "Subject": "[PATCH v2 12/16] KVM: Move vcpu_load to arch-specific\n\tkvm_arch_vcpu_ioctl_get_fpu",
        "Date": "Wed, 29 Nov 2017 17:41:12 +0100",
        "Message-Id": "<20171129164116.16167-13-christoffer.dall@linaro.org>",
        "X-Mailer": "git-send-email 2.14.2",
        "In-Reply-To": "<20171129164116.16167-1-christoffer.dall@linaro.org>",
        "References": "<20171129164116.16167-1-christoffer.dall@linaro.org>",
        "Sender": "kvm-ppc-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<kvm-ppc.vger.kernel.org>",
        "X-Mailing-List": "kvm-ppc@vger.kernel.org"
    },
    "content": "Move vcpu_load() and vcpu_put() into the architecture specific\nimplementations of kvm_arch_vcpu_ioctl_get_fpu().\n\nSigned-off-by: Christoffer Dall <christoffer.dall@linaro.org>\n---\n arch/s390/kvm/kvm-s390.c | 4 ++++\n arch/x86/kvm/x86.c       | 7 +++++--\n virt/kvm/kvm_main.c      | 2 --\n 3 files changed, 9 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c\nindex 4bf80b5..88dcb89 100644\n--- a/arch/s390/kvm/kvm-s390.c\n+++ b/arch/s390/kvm/kvm-s390.c\n@@ -2765,6 +2765,8 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)\n \n int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)\n {\n+\tvcpu_load(vcpu);\n+\n \t/* make sure we have the latest values */\n \tsave_fpu_regs();\n \tif (MACHINE_HAS_VX)\n@@ -2773,6 +2775,8 @@ int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)\n \telse\n \t\tmemcpy(fpu->fprs, vcpu->run->s.regs.fprs, sizeof(fpu->fprs));\n \tfpu->fpc = vcpu->run->s.regs.fpc;\n+\n+\tvcpu_put(vcpu);\n \treturn 0;\n }\n \ndiff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c\nindex a074b0bd..8b54567 100644\n--- a/arch/x86/kvm/x86.c\n+++ b/arch/x86/kvm/x86.c\n@@ -7679,9 +7679,11 @@ int kvm_arch_vcpu_ioctl_translate(struct kvm_vcpu *vcpu,\n \n int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)\n {\n-\tstruct fxregs_state *fxsave =\n-\t\t\t&vcpu->arch.guest_fpu.state.fxsave;\n+\tstruct fxregs_state *fxsave;\n \n+\tvcpu_load(vcpu);\n+\n+\tfxsave = &vcpu->arch.guest_fpu.state.fxsave;\n \tmemcpy(fpu->fpr, fxsave->st_space, 128);\n \tfpu->fcw = fxsave->cwd;\n \tfpu->fsw = fxsave->swd;\n@@ -7691,6 +7693,7 @@ int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)\n \tfpu->last_dp = fxsave->rdp;\n \tmemcpy(fpu->xmm, fxsave->xmm_space, sizeof fxsave->xmm_space);\n \n+\tvcpu_put(vcpu);\n \treturn 0;\n }\n \ndiff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c\nindex c688eb7..73ad70a 100644\n--- a/virt/kvm/kvm_main.c\n+++ b/virt/kvm/kvm_main.c\n@@ -2673,9 +2673,7 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tr = -ENOMEM;\n \t\tif (!fpu)\n \t\t\tgoto out;\n-\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_get_fpu(vcpu, fpu);\n-\t\tvcpu_put(vcpu);\n \t\tif (r)\n \t\t\tgoto out;\n \t\tr = -EFAULT;\n",
    "prefixes": [
        "v2",
        "12/16"
    ]
}