Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/842651/?format=api
{ "id": 842651, "url": "http://patchwork.ozlabs.org/api/patches/842651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/kvm-ppc/patch/20171129164116.16167-3-christoffer.dall@linaro.org/", "project": { "id": 23, "url": "http://patchwork.ozlabs.org/api/projects/23/?format=api", "name": "KVM PowerPC development", "link_name": "kvm-ppc", "list_id": "kvm-ppc.vger.kernel.org", "list_email": "kvm-ppc@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171129164116.16167-3-christoffer.dall@linaro.org>", "list_archive_url": null, "date": "2017-11-29T16:41:02", "name": "[v2,02/16] KVM: Prepare for moving vcpu_load/vcpu_put into arch specific code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7c0d1f48f0e7be259a25e3a5ca6097d4281b1e72", "submitter": { "id": 26352, "url": "http://patchwork.ozlabs.org/api/people/26352/?format=api", "name": "Christoffer Dall", "email": "christoffer.dall@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/kvm-ppc/patch/20171129164116.16167-3-christoffer.dall@linaro.org/mbox/", "series": [ { "id": 15778, "url": "http://patchwork.ozlabs.org/api/series/15778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/kvm-ppc/list/?series=15778", "date": "2017-11-29T16:41:00", "name": "Move vcpu_load and vcpu_put calls to arch code", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/15778/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/842651/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/842651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<kvm-ppc-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OpqNoJ2V\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yn5s44jvVz9t2x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 Nov 2017 03:41:28 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933741AbdK2QlZ (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 29 Nov 2017 11:41:25 -0500", "from mail-wr0-f194.google.com ([209.85.128.194]:37796 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933730AbdK2QlX (ORCPT\n\t<rfc822;kvm-ppc@vger.kernel.org>); Wed, 29 Nov 2017 11:41:23 -0500", "by mail-wr0-f194.google.com with SMTP id k61so3973594wrc.4\n\tfor <kvm-ppc@vger.kernel.org>; Wed, 29 Nov 2017 08:41:22 -0800 (PST)", "from localhost.localdomain (x50d2404e.cust.hiper.dk.\n\t[80.210.64.78]) by smtp.gmail.com with ESMTPSA id\n\te71sm2080765wma.13.2017.11.29.08.41.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 29 Nov 2017 08:41:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=vQKM0/Gu292loDot66k/qAH5+IOr51INpBaAjS9mtz8=;\n\tb=OpqNoJ2V4UZSn3ezn9Grxe7KvmaA5Uy6XbBGfsjHiCSEFHcJjhW4HMpWznn3rnM7B8\n\t2+8ehaUidnC6gFetbbVqO4+03gEIxnoogKOa7zGCCrlz3CEIOkZy4tQsIce78w6DXhi6\n\tgElAGewzQ5XZZSdBuvtfW4uIxb/2f9gVDuJgo=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vQKM0/Gu292loDot66k/qAH5+IOr51INpBaAjS9mtz8=;\n\tb=hsi0N7lZycZ9nH2CL7NLZBkGKNi3hDwnGE6KiksdzkSN7qoQq0tMMeHHvObDFhqt0W\n\tDGaPakc34VjLB9tMjuHzUle0Am8b3uXHuHykQPdGcopUfIwChhY0UUwMsK0dyWYz91Y6\n\t8+DZvZiid1wQNs8sZZrvH+FHbTvKa+uF/M+4HhSmCUsWBWYgt3wgZjc2xDD5OMXMTO9B\n\tehIPDayX0Z3RKWznOx9DPaLMtVgvC9ksouH4WKuJgPqYlgY7A+nP45c223i5brOro6BT\n\tCL2oSAifb2ur0lKNAivgjWxGHmddbjW178gWDeqeDLWs89TKDZN8Ihj3DGRG/nWxdLVL\n\tOXng==", "X-Gm-Message-State": "AJaThX6z6NoKmGvlzr4G8v+7fY8MD53YNRy0x4QYCOh4S4wmxkOHM7X/\n\tV4yS8qRLFuw0Lmyp3Yn+X9BKeQ==", "X-Google-Smtp-Source": "AGs4zMbnjmEm+Db1MsMtCIQmwfZCndT1oFJaKl3wE+SB9ciClG16dtYWZMjJZUnii0ifSMOIDtRG4w==", "X-Received": "by 10.223.167.76 with SMTP id e12mr2677520wrd.204.1511973682256; \n\tWed, 29 Nov 2017 08:41:22 -0800 (PST)", "From": "Christoffer Dall <christoffer.dall@linaro.org>", "To": "kvm@vger.kernel.org", "Cc": "Andrew Jones <drjones@redhat.com>, Christoffer Dall\n\t<christoffer.dall@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,\n\tMarc Zyngier <marc.zyngier@arm.com>, kvmarm@lists.cs.columbia.edu,\n\tlinux-arm-kernel@lists.infradead.org, James Hogan <jhogan@kernel.org>,\n\tlinux-mips@linux-mips.org, Alexander Graf <agraf@suse.com>,\n\tkvm-ppc@vger.kernel.org, \n\tChristian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck\n\t<cohuck@redhat.com>, linux-s390@vger.kernel.org", "Subject": "[PATCH v2 02/16] KVM: Prepare for moving vcpu_load/vcpu_put into\n\tarch specific code", "Date": "Wed, 29 Nov 2017 17:41:02 +0100", "Message-Id": "<20171129164116.16167-3-christoffer.dall@linaro.org>", "X-Mailer": "git-send-email 2.14.2", "In-Reply-To": "<20171129164116.16167-1-christoffer.dall@linaro.org>", "References": "<20171129164116.16167-1-christoffer.dall@linaro.org>", "Sender": "kvm-ppc-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<kvm-ppc.vger.kernel.org>", "X-Mailing-List": "kvm-ppc@vger.kernel.org" }, "content": "In preparation for moving calls to vcpu_load() and vcpu_put() into the\narchitecture specific implementations of the KVM vcpu ioctls, move the\ncalls in the main kvm_vcpu_ioctl() dispatcher function to each case\nof the ioctl select statement. This allows us to move the vcpu_load()\nand vcpu_put() calls into architecture specific implementations of vcpu\nioctls, one by one.\n\nSigned-off-by: Christoffer Dall <christoffer.dall@linaro.org>\n---\n virt/kvm/kvm_main.c | 26 ++++++++++++++++++++++++--\n 1 file changed, 24 insertions(+), 2 deletions(-)", "diff": "diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c\nindex 39961fb..480b16c 100644\n--- a/virt/kvm/kvm_main.c\n+++ b/virt/kvm/kvm_main.c\n@@ -2525,13 +2525,13 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \n \tif (mutex_lock_killable(&vcpu->mutex))\n \t\treturn -EINTR;\n-\tvcpu_load(vcpu);\n \tswitch (ioctl) {\n \tcase KVM_RUN: {\n \t\tstruct pid *oldpid;\n \t\tr = -EINVAL;\n \t\tif (arg)\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\toldpid = rcu_access_pointer(vcpu->pid);\n \t\tif (unlikely(oldpid != current->pids[PIDTYPE_PID].pid)) {\n \t\t\t/* The thread running this VCPU changed. */\n@@ -2543,6 +2543,7 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\t\tput_pid(oldpid);\n \t\t}\n \t\tr = kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run);\n+\t\tvcpu_put(vcpu);\n \t\ttrace_kvm_userspace_exit(vcpu->run->exit_reason, r);\n \t\tbreak;\n \t}\n@@ -2553,7 +2554,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tkvm_regs = kzalloc(sizeof(struct kvm_regs), GFP_KERNEL);\n \t\tif (!kvm_regs)\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_get_regs(vcpu, kvm_regs);\n+\t\tvcpu_put(vcpu);\n \t\tif (r)\n \t\t\tgoto out_free1;\n \t\tr = -EFAULT;\n@@ -2573,7 +2576,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\t\tr = PTR_ERR(kvm_regs);\n \t\t\tgoto out;\n \t\t}\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_set_regs(vcpu, kvm_regs);\n+\t\tvcpu_put(vcpu);\n \t\tkfree(kvm_regs);\n \t\tbreak;\n \t}\n@@ -2582,7 +2587,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tr = -ENOMEM;\n \t\tif (!kvm_sregs)\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_get_sregs(vcpu, kvm_sregs);\n+\t\tvcpu_put(vcpu);\n \t\tif (r)\n \t\t\tgoto out;\n \t\tr = -EFAULT;\n@@ -2598,13 +2605,17 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\t\tkvm_sregs = NULL;\n \t\t\tgoto out;\n \t\t}\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_set_sregs(vcpu, kvm_sregs);\n+\t\tvcpu_put(vcpu);\n \t\tbreak;\n \t}\n \tcase KVM_GET_MP_STATE: {\n \t\tstruct kvm_mp_state mp_state;\n \n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_get_mpstate(vcpu, &mp_state);\n+\t\tvcpu_put(vcpu);\n \t\tif (r)\n \t\t\tgoto out;\n \t\tr = -EFAULT;\n@@ -2619,7 +2630,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tr = -EFAULT;\n \t\tif (copy_from_user(&mp_state, argp, sizeof(mp_state)))\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_set_mpstate(vcpu, &mp_state);\n+\t\tvcpu_put(vcpu);\n \t\tbreak;\n \t}\n \tcase KVM_TRANSLATE: {\n@@ -2628,7 +2641,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tr = -EFAULT;\n \t\tif (copy_from_user(&tr, argp, sizeof(tr)))\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_translate(vcpu, &tr);\n+\t\tvcpu_put(vcpu);\n \t\tif (r)\n \t\t\tgoto out;\n \t\tr = -EFAULT;\n@@ -2643,7 +2658,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tr = -EFAULT;\n \t\tif (copy_from_user(&dbg, argp, sizeof(dbg)))\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_set_guest_debug(vcpu, &dbg);\n+\t\tvcpu_put(vcpu);\n \t\tbreak;\n \t}\n \tcase KVM_SET_SIGNAL_MASK: {\n@@ -2674,7 +2691,9 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\tr = -ENOMEM;\n \t\tif (!fpu)\n \t\t\tgoto out;\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_get_fpu(vcpu, fpu);\n+\t\tvcpu_put(vcpu);\n \t\tif (r)\n \t\t\tgoto out;\n \t\tr = -EFAULT;\n@@ -2690,14 +2709,17 @@ static long kvm_vcpu_ioctl(struct file *filp,\n \t\t\tfpu = NULL;\n \t\t\tgoto out;\n \t\t}\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl_set_fpu(vcpu, fpu);\n+\t\tvcpu_put(vcpu);\n \t\tbreak;\n \t}\n \tdefault:\n+\t\tvcpu_load(vcpu);\n \t\tr = kvm_arch_vcpu_ioctl(filp, ioctl, arg);\n+\t\tvcpu_put(vcpu);\n \t}\n out:\n-\tvcpu_put(vcpu);\n \tmutex_unlock(&vcpu->mutex);\n \tkfree(fpu);\n \tkfree(kvm_sregs);\n", "prefixes": [ "v2", "02/16" ] }