Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/840499/?format=api
{ "id": 840499, "url": "http://patchwork.ozlabs.org/api/patches/840499/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185658.29785.82075.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171122185658.29785.82075.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-22T18:56:59", "name": "[jkirsher/next-queue,08/16] ixgbe: Assume provided MAC filter has been verified by macvlan", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "55020d1da9b7f8160620c0e32121a403678e471b", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185658.29785.82075.stgit@localhost.localdomain/mbox/", "series": [ { "id": 14756, "url": "http://patchwork.ozlabs.org/api/series/14756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14756", "date": "2017-11-22T18:56:10", "name": "ixgbe/fm10k: macvlan fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14756/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/840499/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/840499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vK2eCYuy\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhssq2TGgz9ryQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Nov 2017 06:27:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DC0A5882CB;\n\tWed, 22 Nov 2017 19:27:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7CZ3OgQK1LuG; Wed, 22 Nov 2017 19:27:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0AE44885F2;\n\tWed, 22 Nov 2017 19:27:15 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 583151C2272\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4F18A888C7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:26 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pVUJqQl+k7DX for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:24 +0000 (UTC)", "from mail-pl0-f68.google.com (mail-pl0-f68.google.com\n\t[209.85.160.68])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 633758887B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:24 +0000 (UTC)", "by mail-pl0-f68.google.com with SMTP id v15so1257274plk.11\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 11:02:24 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tw9sm30624821pfk.16.2017.11.22.10.56.59\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 22 Nov 2017 10:56:59 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=Z/dpGiVg1ZG1Xv/cYX+pN1lzBCgCAzwX777PQVt6Di4=;\n\tb=vK2eCYuyLQafplf3OpRKE7hvMtzdZ/mus0+vC1QUeIsjq3sVsp96GwBnCCl9yIZdnX\n\tQc/s49vh6lcJXfBfCzmSxXVRFqzEV1Bl1JMQ3EZlp5FX0zbFjsv/leBAbzjitu7he5NP\n\traRbKHe8F6mCEiLTY/kWOrGPKNw4pd4ZaBB/Coz3SMH9ipi1X7d01mWhyW9cjSbM0mCR\n\tdtdOommPbRupAwP1+Bc5UWTWywizybeMpd49QGogz0ilH8K6TZggU8mkVtKg/Gg6WbZp\n\tXtPL3nXJqyMYD6gBLTWDq4Mdp2kw47CkJOrmlpa3Nadrx5tjUj9KAw6Xu5vx0+vVKcUu\n\tMU8w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=Z/dpGiVg1ZG1Xv/cYX+pN1lzBCgCAzwX777PQVt6Di4=;\n\tb=sERByviNS1PNPqrOHpmDMTVU3uAGC+SPbnpKj2YISlwFeZwD0W9nNtg4vlKPifllAM\n\t3+JRQUT2IiuDeRqFgTTU/5Q7IrkYS9obHj6tC+GgdM6SxJpsVM+UYBbXXN+o7OcG0Vjc\n\t9+dwLBm/RuqzfRfita5ArrM9/jvv9acesCEJTzmRR/Kux97eOUjdFfrociZzoQj2d0hA\n\trd0DQHKm5beQnsd8V5Y/EwS1rFyFxUcETDcxmsEve74OJT8jz4j/CC7RyjRQLRWKNzjD\n\tvk58pmaY+LiQPdu3QCna9LIqpSVqr1UzhmPyB4EdEUqnUQ1KsL3RnwQai20XdnE5eWYy\n\tetCg==", "X-Gm-Message-State": "AJaThX42toOcmhCIWmN8TQZv9bpeFI6IeDyBmhOsuSDEsz0HJPPBbVI8\n\twcNSLL3OzfKuMrRl8ouW09Zf6Avr", "X-Google-Smtp-Source": "AGs4zMZ2KWdtyMSCtOyepbaaqEZ8KVR8LVlW6rRy1J+j7/Qv76vz/Uq0RtedTvx3WKnby6ntgVP69Q==", "X-Received": "by 10.84.195.3 with SMTP id i3mr1591106pld.282.1511377020041;\n\tWed, 22 Nov 2017 10:57:00 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Nov 2017 10:56:59 -0800", "Message-ID": "<20171122185658.29785.82075.stgit@localhost.localdomain>", "In-Reply-To": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "References": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 08/16] ixgbe: Assume\n\tprovided MAC filter has been verified by macvlan", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThe macvlan driver itself will validate the MAC address that is configured\nfor a given interface. There is no need for us to verify it again.\n\nInstead we should be checking to verify that we actuall allocate the filter\nand have not run out of resources to configure a MAC rule in our filter\ntable.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 09754519a0d9..6b553f96ead9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -5404,12 +5404,16 @@ static int ixgbe_fwd_ring_up(struct net_device *vdev,\n \tif (err)\n \t\tgoto fwd_queue_err;\n \n-\tif (is_valid_ether_addr(vdev->dev_addr))\n-\t\tixgbe_add_mac_filter(adapter, vdev->dev_addr,\n-\t\t\t\t VMDQ_P(accel->pool));\n+\t/* ixgbe_add_mac_filter will return an index if it succeeds, so we\n+\t * need to only treat it as an error value if it is negative.\n+\t */\n+\terr = ixgbe_add_mac_filter(adapter, vdev->dev_addr,\n+\t\t\t\t VMDQ_P(accel->pool));\n+\tif (err < 0)\n+\t\tgoto fwd_queue_err;\n \n \tixgbe_macvlan_set_rx_mode(vdev, VMDQ_P(accel->pool), adapter);\n-\treturn err;\n+\treturn 0;\n fwd_queue_err:\n \tixgbe_fwd_ring_down(vdev, accel);\n \treturn err;\n", "prefixes": [ "jkirsher/next-queue", "08/16" ] }