Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/840497/?format=api
{ "id": 840497, "url": "http://patchwork.ozlabs.org/api/patches/840497/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185747.29785.20248.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171122185747.29785.20248.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-22T18:57:47", "name": "[jkirsher/next-queue,16/16] fm10k: Fix configuration for macvlan offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8b9106739713aea7e666bdcf39d32c60d39e6bbd", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185747.29785.20248.stgit@localhost.localdomain/mbox/", "series": [ { "id": 14756, "url": "http://patchwork.ozlabs.org/api/series/14756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14756", "date": "2017-11-22T18:56:10", "name": "ixgbe/fm10k: macvlan fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14756/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/840497/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/840497/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"e/t+wwdq\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhssg5GcMz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Nov 2017 06:27:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BF53F86886;\n\tWed, 22 Nov 2017 19:27:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ixDVS7xXIPAc; Wed, 22 Nov 2017 19:27:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6C35086B85;\n\tWed, 22 Nov 2017 19:27:15 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6BEB51C2272\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:03:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 655202D03E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:03:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lixEDZsB2aiI for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:03:46 +0000 (UTC)", "from mail-pl0-f65.google.com (mail-pl0-f65.google.com\n\t[209.85.160.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 895BC2D00E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:03:46 +0000 (UTC)", "by mail-pl0-f65.google.com with SMTP id 62so1259202plc.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 11:03:46 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\ts73sm30507878pfi.167.2017.11.22.10.57.47\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 22 Nov 2017 10:57:47 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=yIy0rSCz5c/pq8Hwt4akrLBxldMzDxACItXKmsyMa2c=;\n\tb=e/t+wwdqK4aqhOZGCxNP/QPrOIvH/3GigJKc9O9GqOP8L+tCzUF9zCs7bH0Dz+rRCX\n\tBel7rENyQZmvEm922I88sF529d3CQk/HS0eLdO/gBCEpiTFo25+efPTJ9m6zPtAQoiLG\n\t3+94z00MsBs3H6uubbOYE2PZd9I65dh7+lggI9wdTkuO159AJ4YuvHkzR1/j8u7NkeaB\n\t4pqiFRVu1ri3z3rZWbLdVscGWSpVqJwgB7SktJf7qUu/ZeqRGdLA96XKFmV4PfTkZzeQ\n\tWPcgz+L5CkMBa1dsLrigNEKupFoagybzv5sDkh7c4VZ0DDVC+MViMyQ1vaSVhPBR1EVP\n\tD/Fw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=yIy0rSCz5c/pq8Hwt4akrLBxldMzDxACItXKmsyMa2c=;\n\tb=b024ikkXx5XIF123ZcfabovASuEIc4cIBltyA+PMRQVGEHznauYQj1iENa/xpJalt0\n\toAf2C2XtZONBF9yN7tmbmikpqIqol95Q9RE2XsZDUPitlrL8aNH0RXhZ3oofMwJJn1bK\n\t6pD8/NbQKYDw6dKNxgs014yP0V2r6m5UQQyrlVpWCemlEbXqY3NgQ4rh0Bzblb3h88of\n\tPGf5poqEgTQIG8KPX+ciRqVFk//iaPhBo568embw7Rthj0kZfEEdTtDGsdy2r3gCmYc4\n\t2Hqa+Sz25djYcNgwX8GZc4usLMULf3k/a2s9djTf2INdrF6QjjCfkpyqzEWbcGXAHuOy\n\tfH8Q==", "X-Gm-Message-State": "AJaThX7/WNjy7CUh5j0smKjqJsGUBHT5LbMZOYhGjA8l/rsM8wgyFsz0\n\tUxrGMrAobY5iVPVID8x4b4mpXxgT", "X-Google-Smtp-Source": "AGs4zMbBf/fMHGRAbGZETLGXY43NPXI96MwhW8CrYZ+KfNINQuU6MsCc6kFnSivtfDtw4J6/fRkiuQ==", "X-Received": "by 10.159.194.18 with SMTP id x18mr14788212pln.412.1511377068329;\n\tWed, 22 Nov 2017 10:57:48 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Nov 2017 10:57:47 -0800", "Message-ID": "<20171122185747.29785.20248.stgit@localhost.localdomain>", "In-Reply-To": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "References": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 16/16] fm10k: Fix\n\tconfiguration for macvlan offload", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThe fm10k driver didn't work correctly when macvlan offload was enabled.\nSpecifically what would occur is that we would see no unicast packets being\nreceived. This was traced down to us not correctly configuring the default\nVLAN ID for the port and defaulting to 0.\n\nTo correct this we either use the default ID provided by the switch or\nsimply use 1. With that we are able to pass and receive traffic without any\nissues.\n\nIn addition we were not repopulating the filter table following a reset. To\ncorrect that I have added a bit of code to fm10k_restore_rx_state that will\nrepopulate the Rx filter configuration for the macvlan interfaces.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 25 ++++++++++++++++++++---\n 1 file changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex adc62fb38c49..6d9088956407 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -1182,9 +1182,10 @@ static void fm10k_set_rx_mode(struct net_device *dev)\n \n void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n {\n+\tstruct fm10k_l2_accel *l2_accel = interface->l2_accel;\n \tstruct net_device *netdev = interface->netdev;\n \tstruct fm10k_hw *hw = &interface->hw;\n-\tint xcast_mode;\n+\tint xcast_mode, i;\n \tu16 vid, glort;\n \n \t/* record glort for this interface */\n@@ -1234,6 +1235,24 @@ void fm10k_restore_rx_state(struct fm10k_intfc *interface)\n \t__dev_uc_sync(netdev, fm10k_uc_sync, fm10k_uc_unsync);\n \t__dev_mc_sync(netdev, fm10k_mc_sync, fm10k_mc_unsync);\n \n+\t/* synchronize macvlan addresses */\n+\tif (l2_accel) {\n+\t\tfor (i = 0; i < l2_accel->size; i++) {\n+\t\t\tstruct net_device *sdev = l2_accel->macvlan[i];\n+\n+\t\t\tif (!sdev)\n+\t\t\t\tcontinue;\n+\n+\t\t\tglort = l2_accel->dglort + 1 + i;\n+\n+\t\t\thw->mac.ops.update_xcast_mode(hw, glort,\n+\t\t\t\t\t\t FM10K_XCAST_MODE_MULTI);\n+\t\t\tfm10k_queue_mac_request(interface, glort,\n+\t\t\t\t\t\tsdev->dev_addr,\n+\t\t\t\t\t\thw->mac.default_vid, true);\n+\t\t}\n+\t}\n+\n \tfm10k_mbx_unlock(interface);\n \n \t/* record updated xcast mode state */\n@@ -1490,7 +1509,7 @@ static void *fm10k_dfwd_add_station(struct net_device *dev,\n \t\thw->mac.ops.update_xcast_mode(hw, glort,\n \t\t\t\t\t FM10K_XCAST_MODE_MULTI);\n \t\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n-\t\t\t\t\t0, true);\n+\t\t\t\t\thw->mac.default_vid, true);\n \t}\n \n \tfm10k_mbx_unlock(interface);\n@@ -1530,7 +1549,7 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)\n \t\thw->mac.ops.update_xcast_mode(hw, glort,\n \t\t\t\t\t FM10K_XCAST_MODE_NONE);\n \t\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n-\t\t\t\t\t0, false);\n+\t\t\t\t\thw->mac.default_vid, false);\n \t}\n \n \tfm10k_mbx_unlock(interface);\n", "prefixes": [ "jkirsher/next-queue", "16/16" ] }