Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/840496/?format=api
{ "id": 840496, "url": "http://patchwork.ozlabs.org/api/patches/840496/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185646.29785.9424.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171122185646.29785.9424.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-22T18:56:46", "name": "[jkirsher/next-queue,06/16] ixgbe: Use ring values to test for Tx pending", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "00ed704d86305325d979850d7526ac208f8daea7", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185646.29785.9424.stgit@localhost.localdomain/mbox/", "series": [ { "id": 14756, "url": "http://patchwork.ozlabs.org/api/series/14756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14756", "date": "2017-11-22T18:56:10", "name": "ixgbe/fm10k: macvlan fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14756/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/840496/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/840496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FHT/Wol9\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhssg5hhRz9s7B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Nov 2017 06:27:19 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0943188713;\n\tWed, 22 Nov 2017 19:27:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Iz9fRdU3H5Xx; Wed, 22 Nov 2017 19:27:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A13CE8845D;\n\tWed, 22 Nov 2017 19:27:14 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 694F11C2272\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 60EA32D00E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:21 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YNd-8w8QuAvY for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:20 +0000 (UTC)", "from mail-pl0-f66.google.com (mail-pl0-f66.google.com\n\t[209.85.160.66])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C3C8E265B2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 19:02:20 +0000 (UTC)", "by mail-pl0-f66.google.com with SMTP id k7so1255803pln.13\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 11:02:20 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tv81sm24975533pgb.51.2017.11.22.10.56.47\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 22 Nov 2017 10:56:47 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:05:32 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=vZWc+uGyyO4CYBFFLFeOKZrP4Z0y8fRj7PDprDGnPHg=;\n\tb=FHT/Wol9vLU0Th+hnZmCFFvfs6YxFaU5V6xyttFvhXIBreTyai7AlScAP216nIKSDJ\n\trjtjcEbeCtOO9DRBdE8Hh9JW4DfX2aDnWbhVpiFjcs3VeA4cqOGE0Vk/zYXK1SuhH233\n\tqeD3EiHghq5oYmUdmSTDCkX7tbDzx6OhY3SgDElvgq7B3SFxJnQiKfAxTWq1anBZvxoo\n\tgSuso2ToSCevWx7+yc0SiHnUFtmXjO6rFWhEDcIWEvC5rvTfYrhuQaGs5KxTkLK7lgK2\n\tp6fnrTERT+faafidg6HJnIegQpiYHgjoV4khc7sSEumDzCLE+Lqs6gzAk7McOvrpX9Cr\n\t0iyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=vZWc+uGyyO4CYBFFLFeOKZrP4Z0y8fRj7PDprDGnPHg=;\n\tb=HpaSYO/J05+M5nsyHqs0USng3ZfWDjJa2Q0d5cP4zmY9x2TyT70ukiE5kGUTPPIv8k\n\tXVjPCYHs9VnSbdXvXeT95Yu/hRG7yN4/hnN4tN9BOy5hPHZyzB9MJT8a+q71jefesn++\n\tkT91Ej+jny5Ma7+Zq5Cp6sqPbnIUO8QAmom8OojLnJ93lCk/LL5BKbmHyXZaU4JH7Gu4\n\tf+AufXzsVs41yiRvejFM9/i9lQODh21bH1F8G4mFqMEQq3o+SS85cljmh1QmKJfxQIZv\n\tKyiOvRh1ENfLaqosk7nXRbjVx5qlEPLmtQf+f3rEzv5LDgpMn+uiqeCGEI8QUhKGY/rh\n\tbGGQ==", "X-Gm-Message-State": "AJaThX6xgKqIM/qo1/AGamupf3L2xGRbItkk8C9foChVcHV/ZehUdHHt\n\tmdlYEn6MFvBhRc9ZsPzkZuJdGbwC", "X-Google-Smtp-Source": "AGs4zMafiybAm67uYN/1/cRZZztOKfQW7rpMDXpzXzHAflNBE7c6OfAsjr0RoO/QxELJBpAQoK5Izw==", "X-Received": "by 10.84.142.131 with SMTP id 3mr22190216plx.26.1511377007892;\n\tWed, 22 Nov 2017 10:56:47 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Nov 2017 10:56:46 -0800", "Message-ID": "<20171122185646.29785.9424.stgit@localhost.localdomain>", "In-Reply-To": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "References": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 06/16] ixgbe: Use ring\n\tvalues to test for Tx pending", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis patch simplifies the check for Tx pending traffic and makes it more\nholistic as there being any difference between next_to_use and\nnext_to_clean is much more informative than if head and tail are equal, as\nit is possible for us to either not update tail, or not be notified of\ncompleted work in which case next_to_clean would not be equal to head.\n\nIn addition the simplification makes it so that we don't have to read\nhardware which allows us to drop a number of variables that were previously\nbeing used in the call.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++++----------------\n 1 file changed, 4 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 101b3521ab0b..69bababc0cf6 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1064,24 +1064,12 @@ static u64 ixgbe_get_tx_completed(struct ixgbe_ring *ring)\n \n static u64 ixgbe_get_tx_pending(struct ixgbe_ring *ring)\n {\n-\tstruct ixgbe_adapter *adapter;\n-\tstruct ixgbe_hw *hw;\n-\tu32 head, tail;\n+\tunsigned int head, tail;\n \n-\tif (ring->l2_accel_priv)\n-\t\tadapter = ring->l2_accel_priv->real_adapter;\n-\telse\n-\t\tadapter = netdev_priv(ring->netdev);\n+\thead = ring->next_to_clean;\n+\ttail = ring->next_to_use;\n \n-\thw = &adapter->hw;\n-\thead = IXGBE_READ_REG(hw, IXGBE_TDH(ring->reg_idx));\n-\ttail = IXGBE_READ_REG(hw, IXGBE_TDT(ring->reg_idx));\n-\n-\tif (head != tail)\n-\t\treturn (head < tail) ?\n-\t\t\ttail - head : (tail + ring->count - head);\n-\n-\treturn 0;\n+\treturn ((head <= tail) ? tail : tail + ring->count) - head;\n }\n \n static inline bool ixgbe_check_tx_hang(struct ixgbe_ring *tx_ring)\n", "prefixes": [ "jkirsher/next-queue", "06/16" ] }