Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/840483/?format=api
{ "id": 840483, "url": "http://patchwork.ozlabs.org/api/patches/840483/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185634.29785.72563.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171122185634.29785.72563.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-22T18:56:34", "name": "[jkirsher/next-queue,04/16] ixgbe: There is no need to update num_rx_pools in L2 fwd offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "97f5774d3af1a4b558d8f4186d32cc4f1935a9bc", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171122185634.29785.72563.stgit@localhost.localdomain/mbox/", "series": [ { "id": 14756, "url": "http://patchwork.ozlabs.org/api/series/14756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14756", "date": "2017-11-22T18:56:10", "name": "ixgbe/fm10k: macvlan fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14756/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/840483/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/840483/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YGhzoB8Q\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhsXf09Gnz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Nov 2017 06:12:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 663C987A59;\n\tWed, 22 Nov 2017 19:12:32 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mQ_y6pIeF9t9; Wed, 22 Nov 2017 19:12:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 212D287A34;\n\tWed, 22 Nov 2017 19:12:31 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 013B31C2314\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id ED29587966\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:36 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zLb-XbwN0AiH for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:36 +0000 (UTC)", "from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 59BF987963\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 18:56:36 +0000 (UTC)", "by mail-pg0-f66.google.com with SMTP id s11so12955493pgc.5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Nov 2017 10:56:36 -0800 (PST)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tg10sm9170617pfe.77.2017.11.22.10.56.35\n\tfor <intel-wired-lan@lists.osuosl.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 22 Nov 2017 10:56:35 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=n6jHIsyHQAQPYC7aVG1PZZXMEIWgSrtef2+KTQDHO74=;\n\tb=YGhzoB8Q1SEaZj84ykC9o7L4fLZQUoWkXrAFtfoZeNMy0Po4PBZeQy7YAwXwYq6+nM\n\t3b+FUTLIL/USc8edU4uaJIjTt5YQccx5poB0f6nkKkUu8dgvCeFCOpZyuRxsRuvuy0pt\n\tvhtLs4P+tKukEKSbq3Z9v0V+Xm9AYY6pNyKO3Gd+9DcC33FQ58ClGvui1BzkDNlaGf1I\n\tnGUk9OTI3g90quAw0oOGdrkGzXl8HjTETHp35rd0Y3JSmKm8bhyUlyA6pNIXg5DsnEbf\n\tqvfYQFtI+1Uh42FNv5tmU/nSDKf/fXpjFokzrIFXDIF4R0YeSEyos9rzGbXDaGvLYaKx\n\tHOBw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=n6jHIsyHQAQPYC7aVG1PZZXMEIWgSrtef2+KTQDHO74=;\n\tb=Yxjee75rMUJVlidYWmf2S53wF7XhbP58Wg3qTOj5Ry6MQBzla/y/san3+maoCGHT3W\n\tjKtX29qo6NPuzQvTD9DVipiPv9V4NvvF1U81n4Cjvq5aWwCjf9xxnghvNxTJcPlJ7j3G\n\taTLW4mDcdOaRz8FeJlzGK43qtB1Xy0g24632C+ipKx9y+/jN+C+4qHqO2i2WHmPX/x7h\n\tL2n/jkR4mWHFCePWl0XpC3Stf8yimm9ybXAVaKB+GaEDGRdQ2Z2eaHE4MTwqmMHYeC0X\n\tJXa0hMbx8vrh/QZ7xbzUXHOarv7VKMPfW8XQYRUlGxG4BEbKeyNvz/GXx2Qe4i//csCm\n\tC0yA==", "X-Gm-Message-State": "AJaThX7Jq9imgQejxbQxZ9ugoqmFZ4h67tdjsA5JjnviHaintKQzGZg/\n\trZx8WVoP6nyzvsSOFNdIVP2zPEmb", "X-Google-Smtp-Source": "AGs4zMaeusFedPp+fQy+fXVFexFvUDTLJ8AosZtjebCKId6eNTZyfMREf/TOWj7gP7DeqT8RIK/GeA==", "X-Received": "by 10.98.211.73 with SMTP id q70mr20517320pfg.107.1511376995746; \n\tWed, 22 Nov 2017 10:56:35 -0800 (PST)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Nov 2017 10:56:34 -0800", "Message-ID": "<20171122185634.29785.72563.stgit@localhost.localdomain>", "In-Reply-To": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "References": "<20171122185256.29785.93548.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 04/16] ixgbe: There is\n\tno need to update num_rx_pools in L2 fwd offload", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThe num_rx_pools value is overwritten when we reinitialize the queue\nconfiguration. In reality we shouldn't need to be updating the value since\nit is redone every time we call into ixgbe_setup_tc so for now just drop\nthe spots where we were incrementing or decrementing the value.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ---\n 2 files changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c\nindex 8e2a957aca18..56622adc76dc 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c\n@@ -701,7 +701,7 @@ static void ixgbe_set_num_queues(struct ixgbe_adapter *adapter)\n \tadapter->num_rx_queues = 1;\n \tadapter->num_tx_queues = 1;\n \tadapter->num_xdp_queues = 0;\n-\tadapter->num_rx_pools = adapter->num_rx_queues;\n+\tadapter->num_rx_pools = 1;\n \tadapter->num_rx_queues_per_pool = 1;\n \n #ifdef CONFIG_IXGBE_DCB\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 060474747ecc..c1df873faf68 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9833,7 +9833,6 @@ static void *ixgbe_fwd_add(struct net_device *pdev, struct net_device *vdev)\n \t\treturn ERR_PTR(-ENOMEM);\n \n \tpool = find_first_zero_bit(&adapter->fwd_bitmask, 32);\n-\tadapter->num_rx_pools++;\n \tset_bit(pool, &adapter->fwd_bitmask);\n \tlimit = find_last_bit(&adapter->fwd_bitmask, 32);\n \n@@ -9862,7 +9861,6 @@ static void *ixgbe_fwd_add(struct net_device *pdev, struct net_device *vdev)\n \tnetdev_info(pdev,\n \t\t \"%s: dfwd hardware acceleration failed\\n\", vdev->name);\n \tclear_bit(pool, &adapter->fwd_bitmask);\n-\tadapter->num_rx_pools--;\n \tkfree(fwd_adapter);\n \treturn ERR_PTR(err);\n }\n@@ -9874,7 +9872,6 @@ static void ixgbe_fwd_del(struct net_device *pdev, void *priv)\n \tunsigned int limit;\n \n \tclear_bit(fwd_adapter->pool, &adapter->fwd_bitmask);\n-\tadapter->num_rx_pools--;\n \n \tlimit = find_last_bit(&adapter->fwd_bitmask, 32);\n \tadapter->ring_feature[RING_F_VMDQ].limit = limit + 1;\n", "prefixes": [ "jkirsher/next-queue", "04/16" ] }