Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/840223/?format=api
{ "id": 840223, "url": "http://patchwork.ozlabs.org/api/patches/840223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171121223030.28051-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171121223030.28051-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2017-11-21T22:30:30", "name": "[net] sched/deadline: fix one-bit signed bitfields to be unsigned", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9a24df416756ff4af7e6868010f1d8e61f5910e1", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171121223030.28051-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 14621, "url": "http://patchwork.ozlabs.org/api/series/14621/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14621", "date": "2017-11-21T22:30:30", "name": "[net] sched/deadline: fix one-bit signed bitfields to be unsigned", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14621/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/840223/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/840223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhLvZ4DVTz9t2t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 22 Nov 2017 10:12:09 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F22F38740E;\n\tTue, 21 Nov 2017 23:12:07 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HhCCJSHHxymS; Tue, 21 Nov 2017 23:12:04 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 41FDA873DE;\n\tTue, 21 Nov 2017 23:12:04 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2C6E91BF9C3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Nov 2017 22:30:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1FEA42FF91\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Nov 2017 22:30:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 02BZ6D8N6T5A for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Nov 2017 22:30:41 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id DB3502FE51\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 21 Nov 2017 22:30:41 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Nov 2017 14:30:41 -0800", "from jekeller-desk.amr.corp.intel.com ([134.134.177.230])\n\tby orsmga005.jf.intel.com with ESMTP; 21 Nov 2017 14:30:40 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,432,1505804400\"; d=\"scan'208\";a=\"176335713\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 21 Nov 2017 14:30:30 -0800", "Message-Id": "<20171121223030.28051-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.15.0", "Subject": "[Intel-wired-lan] [PATCH net] sched/deadline: fix one-bit signed\n\tbitfields to be unsigned", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Peter Zijlstra <peterz@infradead.org>,\n\tluca abeni <luca.abeni@santannapisa.it>, Ingo Molnar <mingo@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit 799ba82de01e (\"sched/deadline: Use C bitfields for the state\nflags\", 2017-10-10) introduced the use of C bitfields for these\nvariables. However, sparse complains about them:\n\n./include/linux/sched.h:476:62: error: dubious one-bit signed bitfield\n./include/linux/sched.h:477:62: error: dubious one-bit signed bitfield\n./include/linux/sched.h:478:62: error: dubious one-bit signed bitfield\n./include/linux/sched.h:479:62: error: dubious one-bit signed bitfield\n\nThis is because a one-bit signed bitfield can only hold the values 0 and\n-1, which can cause problems if the program expects to be able to\nrepresent the value positive 1.\n\nIn practice, this may not cause a bug since -1 would be considered\n\"true\" in logical tests, however we should avoid the practice anyways.\n\nFixes: 799ba82de01e (\"sched/deadline: Use C bitfields for the state flags\", 2017-10-10)\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nCc: Ingo Molnar <mingo@redhat.com>\nCc: Peter Zijlstra <peterz@infradead.org>\nCc: luca abeni <luca.abeni@santannapisa.it>\n---\n include/linux/sched.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/linux/sched.h b/include/linux/sched.h\nindex a5dc7c98b0a2..21991d668d35 100644\n--- a/include/linux/sched.h\n+++ b/include/linux/sched.h\n@@ -473,10 +473,10 @@ struct sched_dl_entity {\n \t * conditions between the inactive timer handler and the wakeup\n \t * code.\n \t */\n-\tint\t\t\t\tdl_throttled : 1;\n-\tint\t\t\t\tdl_boosted : 1;\n-\tint\t\t\t\tdl_yielded : 1;\n-\tint\t\t\t\tdl_non_contending : 1;\n+\tunsigned int\t\t\tdl_throttled : 1;\n+\tunsigned int\t\t\tdl_boosted : 1;\n+\tunsigned int\t\t\tdl_yielded : 1;\n+\tunsigned int\t\t\tdl_non_contending : 1;\n \n \t/*\n \t * Bandwidth enforcement timer. Each -deadline task has its\n", "prefixes": [ "net" ] }