Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/839187/?format=api
{ "id": 839187, "url": "http://patchwork.ozlabs.org/api/patches/839187/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/151096270698.41070.15719394215346077510.stgit@anamdev.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<151096270698.41070.15719394215346077510.stgit@anamdev.jf.intel.com>", "list_archive_url": null, "date": "2017-11-17T23:51:47", "name": "[jkirsher/next-queue] i40e: Support only TCP filters via big buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0c4a7515b102a5b8b583c431d79c100d3e861ad9", "submitter": { "id": 68504, "url": "http://patchwork.ozlabs.org/api/people/68504/?format=api", "name": "Nambiar, Amritha", "email": "amritha.nambiar@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/151096270698.41070.15719394215346077510.stgit@anamdev.jf.intel.com/mbox/", "series": [ { "id": 14182, "url": "http://patchwork.ozlabs.org/api/series/14182/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14182", "date": "2017-11-17T23:51:47", "name": "[jkirsher/next-queue] i40e: Support only TCP filters via big buffer", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/14182/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/839187/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/839187/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ydwNN0yH2z9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 18 Nov 2017 11:10:12 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8F4DD88EB2;\n\tSat, 18 Nov 2017 00:10:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ynu7wDyC0Pfr; Sat, 18 Nov 2017 00:10:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6616788E40;\n\tSat, 18 Nov 2017 00:10:09 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A2F101BFFC3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 23:53:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DA07422FF7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 23:53:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1wyLDu1DDvLE for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 23:53:14 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 0B29522F02\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 23:53:13 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Nov 2017 15:53:32 -0800", "from anamdev.jf.intel.com ([10.166.29.110])\n\tby orsmga001.jf.intel.com with ESMTP; 17 Nov 2017 15:53:31 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,411,1505804400\"; d=\"scan'208\";a=\"6304721\"", "From": "Amritha Nambiar <amritha.nambiar@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Fri, 17 Nov 2017 15:51:47 -0800", "Message-ID": "<151096270698.41070.15719394215346077510.stgit@anamdev.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH] i40e: Support only\n\tTCP filters via big buffer", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Change big buffer cloud filter function to operate in TCP\nonly mode. UDP based filters are not supported via big buffer\ncloud filters. Also change few return types to indicate\nunsupported vs invalid configuration.\n\nSigned-off-by: Amritha Nambiar <amritha.nambiar@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 565ce12..1fa07c10 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6038,8 +6038,8 @@ static int i40e_validate_and_set_switch_mode(struct i40e_vsi *vsi)\n \t/* Set Bit 7 to be valid */\n \tmode = I40E_AQ_SET_SWITCH_BIT7_VALID;\n \n-\t/* Set L4type to both TCP and UDP support */\n-\tmode |= I40E_AQ_SET_SWITCH_L4_TYPE_BOTH;\n+\t/* Set L4type for TCP support */\n+\tmode |= I40E_AQ_SET_SWITCH_L4_TYPE_TCP;\n \n \t/* Set cloud filter mode */\n \tmode |= I40E_AQ_SET_SWITCH_MODE_NON_TUNNEL;\n@@ -7038,18 +7038,18 @@ static int i40e_add_del_cloud_filter_big_buf(struct i40e_vsi *vsi,\n \t is_valid_ether_addr(filter->src_mac)) ||\n \t (is_multicast_ether_addr(filter->dst_mac) &&\n \t is_multicast_ether_addr(filter->src_mac)))\n-\t\treturn -EINVAL;\n+\t\treturn -EOPNOTSUPP;\n \n-\t/* Make sure port is specified, otherwise bail out, for channel\n-\t * specific cloud filter needs 'L4 port' to be non-zero\n+\t/* Big buffer cloud filter needs 'L4 port' to be non-zero. Also, UDP\n+\t * ports are not supported via big buffer now.\n \t */\n-\tif (!filter->dst_port)\n-\t\treturn -EINVAL;\n+\tif (!filter->dst_port || filter->ip_proto == IPPROTO_UDP)\n+\t\treturn -EOPNOTSUPP;\n \n \t/* adding filter using src_port/src_ip is not supported at this stage */\n \tif (filter->src_port || filter->src_ipv4 ||\n \t !ipv6_addr_any(&filter->ip.v6.src_ip6))\n-\t\treturn -EINVAL;\n+\t\treturn -EOPNOTSUPP;\n \n \t/* copy element needed to add cloud filter from filter */\n \ti40e_set_cld_element(filter, &cld_filter.element);\n@@ -7060,7 +7060,7 @@ static int i40e_add_del_cloud_filter_big_buf(struct i40e_vsi *vsi,\n \t is_multicast_ether_addr(filter->src_mac)) {\n \t\t/* MAC + IP : unsupported mode */\n \t\tif (filter->dst_ipv4)\n-\t\t\treturn -EINVAL;\n+\t\t\treturn -EOPNOTSUPP;\n \n \t\t/* since we validated that L4 port must be valid before\n \t\t * we get here, start with respective \"flags\" value\n", "prefixes": [ "jkirsher/next-queue" ] }