Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/839072/?format=api
{ "id": 839072, "url": "http://patchwork.ozlabs.org/api/patches/839072/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1510938349-17608-3-git-send-email-brking@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1510938349-17608-3-git-send-email-brking@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-11-17T17:05:44", "name": "[v2,2/7] i40e: Use smp_rmb rather than read_barrier_depends", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1c055ddb6e8609aae8bef21d484a3b56bab58262", "submitter": { "id": 943, "url": "http://patchwork.ozlabs.org/api/people/943/?format=api", "name": "Brian King", "email": "brking@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1510938349-17608-3-git-send-email-brking@linux.vnet.ibm.com/mbox/", "series": [ { "id": 14119, "url": "http://patchwork.ozlabs.org/api/series/14119/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=14119", "date": "2017-11-17T17:05:43", "name": "intel: Use smp_rmb rather than read_barrier_depends", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/14119/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/839072/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/839072/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ydlN66sPcz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 18 Nov 2017 04:24:22 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6343F88E90;\n\tFri, 17 Nov 2017 17:24:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aPjd8GNUcYSi; Fri, 17 Nov 2017 17:24:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F1C2888E3E;\n\tFri, 17 Nov 2017 17:24:18 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 46BBC1C152B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 17:06:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3DE6C88D02\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 17:06:02 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id y7XATcAl-nHW for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 17:06:01 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id BC6AB88CFC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 17:06:01 +0000 (UTC)", "from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tvAHH4HP6196175 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 12:06:00 -0500", "from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2e9ykw4t3j-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Nov 2017 12:06:00 -0500", "from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <intel-wired-lan@lists.osuosl.org> from\n\t<brking@linux.vnet.ibm.com>; Fri, 17 Nov 2017 10:05:59 -0700", "from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 17 Nov 2017 10:05:57 -0700", "from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id vAHH5uqL65274110; Fri, 17 Nov 2017 10:05:56 -0700", "from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D992E78037;\n\tFri, 17 Nov 2017 10:05:56 -0700 (MST)", "from oc3660843733-ibm-com.ibm.com (unknown [9.10.86.134])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 3894778051;\n\tFri, 17 Nov 2017 10:05:56 -0700 (MST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Brian King <brking@linux.vnet.ibm.com>", "To": "", "Date": "Fri, 17 Nov 2017 11:05:44 -0600", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1510938349-17608-1-git-send-email-brking@linux.vnet.ibm.com>", "References": "<1510938349-17608-1-git-send-email-brking@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17111717-0024-0000-0000-000017814688", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00008083; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000240; SDB=6.00947257; UDB=6.00478229;\n\tIPR=6.00727549; \n\tBA=6.00005697; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018066;\n\tXFM=3.00000015; UTC=2017-11-17 17:05:59", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17111717-0025-0000-0000-00004D8AE858", "Message-Id": "<1510938349-17608-3-git-send-email-brking@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-11-17_05:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1709140000\n\tdefinitions=main-1711170233", "Subject": "[Intel-wired-lan] [PATCH v2 2/7] i40e: Use smp_rmb rather than\n\tread_barrier_depends", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "muvic@linux.vnet.ibm.com, stable@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, brking@pobox.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The original issue being fixed in this patch was seen with the ixgbe\ndriver, but the same issue exists with i40e as well, as the code is\nvery similar. read_barrier_depends is not sufficient to ensure\nloads following it are not speculatively loaded out of order\nby the CPU, which can result in stale data being loaded, causing\npotential system crashes.\n\nCc: stable<stable@vger.kernel.org>\nSigned-off-by: Brian King <brking@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 6498da8..ea20aac 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -3760,7 +3760,7 @@ static bool i40e_clean_fdir_tx_irq(struct i40e_ring *tx_ring, int budget)\n \t\t\tbreak;\n \n \t\t/* prevent any other reads prior to eop_desc */\n-\t\tread_barrier_depends();\n+\t\tsmp_rmb();\n \n \t\t/* if the descriptor isn't done, no work yet to do */\n \t\tif (!(eop_desc->cmd_type_offset_bsz &\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 120c68f..3c07ff1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -759,7 +759,7 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \t\t\tbreak;\n \n \t\t/* prevent any other reads prior to eop_desc */\n-\t\tread_barrier_depends();\n+\t\tsmp_rmb();\n \n \t\ti40e_trace(clean_tx_irq, tx_ring, tx_desc, tx_buf);\n \t\t/* we have caught up to head, no work left to do */\n", "prefixes": [ "v2", "2/7" ] }