Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/838016/?format=api
{ "id": 838016, "url": "http://patchwork.ozlabs.org/api/patches/838016/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171114120052.86665-3-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171114120052.86665-3-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-11-14T12:00:46", "name": "[next,S82-V4,3/9] i40evf: Drop i40evf_fire_sw_int as it is prone to races", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bc8905964765512f25b663aac382d83668941350", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171114120052.86665-3-alice.michael@intel.com/mbox/", "series": [ { "id": 13564, "url": "http://patchwork.ozlabs.org/api/series/13564/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=13564", "date": "2017-11-14T12:00:46", "name": "[next,S82-V4,1/9] i40evf: Do not clear MSI-X PBA manually", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/13564/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/838016/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/838016/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ybzVZ2Tsrz9ryv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 15 Nov 2017 07:23:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 49245258C4;\n\tTue, 14 Nov 2017 20:23:48 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EHXDoKhzMdOL; Tue, 14 Nov 2017 20:23:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 70FF3240A0;\n\tTue, 14 Nov 2017 20:23:47 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 276E21BFC3F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Nov 2017 20:07:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 18D1E878B4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Nov 2017 20:07:04 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id i1VVvlzSPkgt for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Nov 2017 20:06:59 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id BD627878C3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Nov 2017 20:06:59 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Nov 2017 12:06:58 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby fmsmga001.fm.intel.com with ESMTP; 14 Nov 2017 12:06:58 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,396,1505804400\"; d=\"scan'208\";a=\"2651453\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 14 Nov 2017 07:00:46 -0500", "Message-Id": "<20171114120052.86665-3-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20171114120052.86665-1-alice.michael@intel.com>", "References": "<20171114120052.86665-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S82-V4 3/9] i40evf: Drop\n\ti40evf_fire_sw_int as it is prone to races", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nHaving the interrupts firing while we are polling causes extra overhead and\nisn't needed for most systems out there. If an interrupt is lost us\nexperiencing a 2s latency spike before recovering is still not acceptable\nand masks the issue. We are better off just identifying systems that lose\ninterrupts and instead enable workarounds for those systems.\n\nTo that end I am dropping the code that was strobing the interrupts as\nthere is a narrow window where having them enabled can actually cause\nrace issues anyway where a few stray packets might get misses if the\ninterrupt is re-enabled and fires before we call napi_complete.\n\nAlso replace one line where we were using bit 31 instead of the define\nfor the bit to represent masking the interrupt enable bit.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 34 -------------------------\n 1 file changed, 34 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 4dd3149..5e27619 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -282,33 +282,6 @@ void i40evf_irq_enable_queues(struct i40evf_adapter *adapter, u32 mask)\n }\n \n /**\n- * i40evf_fire_sw_int - Generate SW interrupt for specified vectors\n- * @adapter: board private structure\n- * @mask: bitmap of vectors to trigger\n- **/\n-static void i40evf_fire_sw_int(struct i40evf_adapter *adapter, u32 mask)\n-{\n-\tstruct i40e_hw *hw = &adapter->hw;\n-\tint i;\n-\tu32 dyn_ctl;\n-\n-\tif (mask & 1) {\n-\t\tdyn_ctl = rd32(hw, I40E_VFINT_DYN_CTL01);\n-\t\tdyn_ctl |= I40E_VFINT_DYN_CTLN1_SWINT_TRIG_MASK |\n-\t\t\t I40E_VFINT_DYN_CTLN1_ITR_INDX_MASK;\n-\t\twr32(hw, I40E_VFINT_DYN_CTL01, dyn_ctl);\n-\t}\n-\tfor (i = 1; i < adapter->num_msix_vectors; i++) {\n-\t\tif (mask & BIT(i)) {\n-\t\t\tdyn_ctl = rd32(hw, I40E_VFINT_DYN_CTLN1(i - 1));\n-\t\t\tdyn_ctl |= I40E_VFINT_DYN_CTLN1_SWINT_TRIG_MASK |\n-\t\t\t\t I40E_VFINT_DYN_CTLN1_ITR_INDX_MASK;\n-\t\t\twr32(hw, I40E_VFINT_DYN_CTLN1(i - 1), dyn_ctl);\n-\t\t}\n-\t}\n-}\n-\n-/**\n * i40evf_irq_enable - Enable default interrupt generation settings\n * @adapter: board private structure\n * @flush: boolean value whether to run rd32()\n@@ -1743,13 +1716,6 @@ static void i40evf_watchdog_task(struct work_struct *work)\n \tif (adapter->state == __I40EVF_RUNNING)\n \t\ti40evf_request_stats(adapter);\n watchdog_done:\n-\tif (adapter->state == __I40EVF_RUNNING) {\n-\t\ti40evf_irq_enable_queues(adapter, ~0);\n-\t\ti40evf_fire_sw_int(adapter, 0xFF);\n-\t} else {\n-\t\ti40evf_fire_sw_int(adapter, 0x1);\n-\t}\n-\n \tclear_bit(__I40EVF_IN_CRITICAL_TASK, &adapter->crit_section);\n restart_watchdog:\n \tif (adapter->state == __I40EVF_REMOVE)\n", "prefixes": [ "next", "S82-V4", "3/9" ] }