Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/836951/?format=api
{ "id": 836951, "url": "http://patchwork.ozlabs.org/api/patches/836951/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171110222150.17754-1-jesus.sanchez-palencia@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171110222150.17754-1-jesus.sanchez-palencia@intel.com>", "list_archive_url": null, "date": "2017-11-10T22:21:50", "name": "[net-next] igb: Clarify idleslope config constraints", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "956b3356f83fc9b1a4a71406fb47a2fa3f1ed7b8", "submitter": { "id": 72279, "url": "http://patchwork.ozlabs.org/api/people/72279/?format=api", "name": "Jesus Sanchez-Palencia", "email": "jesus.sanchez-palencia@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171110222150.17754-1-jesus.sanchez-palencia@intel.com/mbox/", "series": [ { "id": 13078, "url": "http://patchwork.ozlabs.org/api/series/13078/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=13078", "date": "2017-11-10T22:21:50", "name": "[net-next] igb: Clarify idleslope config constraints", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/13078/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/836951/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/836951/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yYZTh39N0z9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 11 Nov 2017 09:29:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0CF7C8840E;\n\tFri, 10 Nov 2017 22:29:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rGuRcXx4x2BC; Fri, 10 Nov 2017 22:29:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2476F83978;\n\tFri, 10 Nov 2017 22:29:39 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 691951C4371\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Nov 2017 22:29:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 61A4C826A8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Nov 2017 22:29:38 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Rz6kNB0sSlQX for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Nov 2017 22:29:37 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 64C4E82645\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 10 Nov 2017 22:29:37 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP; 10 Nov 2017 14:29:36 -0800", "from cvitu-mobl1.amr.corp.intel.com (HELO\n\tdarjeeling.amr.corp.intel.com) ([10.254.187.91])\n\tby orsmga003.jf.intel.com with ESMTP; 10 Nov 2017 14:29:34 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,376,1505804400\"; d=\"scan'208\";a=\"1024457\"", "From": "Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 10 Nov 2017 14:21:50 -0800", "Message-Id": "<20171110222150.17754-1-jesus.sanchez-palencia@intel.com>", "X-Mailer": "git-send-email 2.14.1", "Subject": "[Intel-wired-lan] [PATCH net-next] igb: Clarify idleslope config\n\tconstraints", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>,\n\tandre.guedes@intel.com, ivan.briano@intel.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "By design, the idleslope increments are restricted to 16.384kbps steps.\nAdd a comment to igb_main.c making that explicit and add one example\nthat illustrates the impact of that.\n\nSigned-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 43cf39527660..d56c998f3f14 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -1744,6 +1744,20 @@ static void igb_configure_cbs(struct igb_adapter *adapter, int queue,\n \t\t * value = idleSlope * 61034\n \t\t * ----------------- (E6)\n \t\t * 1000000\n+\t\t *\n+\t\t * NOTE: For i210, given the above, we can see that idleslope\n+\t\t * is represented in 16.38431 kbps units by the value at\n+\t\t * the TQAVCC register (1Gbps / 61034), which reduces\n+\t\t * the granularity for idleslope increments.\n+\t\t * For instance, if you want to configure a 2576kbps\n+\t\t * idleslope, the value to be written on the register\n+\t\t * would have to be 157.23. If rounded down, you end\n+\t\t * up with less bandwidth available than originally\n+\t\t * required (~2572 kbps). If rounded up, you end up\n+\t\t * with a higher bandwidth (~2589 kbps). Below the\n+\t\t * approach we take is to always round up the\n+\t\t * calculated value, so the resulting bandwidth might\n+\t\t * be slightly higher for some configurations.\n \t\t */\n \t\tvalue = DIV_ROUND_UP_ULL(idleslope * 61034ULL, 1000000);\n \n", "prefixes": [ "net-next" ] }