Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/835841/?format=api
{ "id": 835841, "url": "http://patchwork.ozlabs.org/api/patches/835841/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171107221332.28283-3-mattst88@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171107221332.28283-3-mattst88@gmail.com>", "list_archive_url": null, "date": "2017-11-07T22:13:32", "name": "[3/3] e1000e: Disable jumbo receive workaround on Lynx Point and newer", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "cb626116db28c97d2f48d0467026d60db8b45491", "submitter": { "id": 7917, "url": "http://patchwork.ozlabs.org/api/people/7917/?format=api", "name": "Matt Turner", "email": "mattst88@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171107221332.28283-3-mattst88@gmail.com/mbox/", "series": [ { "id": 12542, "url": "http://patchwork.ozlabs.org/api/series/12542/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=12542", "date": "2017-11-07T22:13:31", "name": "[1/3] e1000e: Set HTHRESH when PTHRESH is used", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/12542/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/835841/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/835841/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MPdWCpLZ\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yX8MW4l6dz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 9 Nov 2017 01:49:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B8D37230F6;\n\tWed, 8 Nov 2017 14:49:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5veAAK0lxsqL; Wed, 8 Nov 2017 14:49:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 35B8124527;\n\tWed, 8 Nov 2017 14:49:23 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1C9821C02F3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 22:13:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 132A18874B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 22:13:46 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3j8rCLPwwtri for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 22:13:45 +0000 (UTC)", "from mail-pg0-f68.google.com (mail-pg0-f68.google.com\n\t[74.125.83.68])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 4F10181FD4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 22:13:45 +0000 (UTC)", "by mail-pg0-f68.google.com with SMTP id m18so552724pgd.13\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 07 Nov 2017 14:13:45 -0800 (PST)", "from localhost ([108.161.26.224]) by smtp.gmail.com with ESMTPSA id\n\t22sm4734710pfn.24.2017.11.07.14.13.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 07 Nov 2017 14:13:43 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=UHH5KlNGm43vo3oxsanIEAH1mHxAmXj7Ws/et6IUT38=;\n\tb=MPdWCpLZVaEL/w4n9IJbG49x1vDNMd6urPDRk+m3RzCr2u3GE5z4Q/tcoYgzyOvbd/\n\tY0LsnWKJ0sRCX94VnE8o+gdPPcxtI8QxtwBKaJ8sngSifcOH9IvDZTpZSzonDEC1JJZJ\n\tN3nqgianCVD1mRtkLDrN9kuoj1NAGWuFFBtnE2QFkajCtXQHo8n//wokVqbE177zb4ah\n\tevPnrgaHVNrYbarkR3pyPTMqNbRuFg9znjs979Z8Y18rUM++3hrjY8j0R25Mp117C8jt\n\tcBtVITyugBS00Fbh7w5pCcBYD0Jk12qm/jg0+dUf37dIfgRuvXh7VbzawnRXjvEFvKlJ\n\tvt/g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UHH5KlNGm43vo3oxsanIEAH1mHxAmXj7Ws/et6IUT38=;\n\tb=CpCts3ksxHtoSCsRDtHmZn3WZty1c0A3v5EBagXdSOxnTX5d+tn9cR/NMrSfL6HS6w\n\tnbAEXYBepmFGbBZgGtO8zd1egaE5vvwsBC171HuJO2mj+l+PYlWH27A+8yh37nurITJK\n\tCdE9Khi0si+Akt9EDTAXCB8UmDzMBf5gMOzmNEj4jB9RHx4zUpSd6Fn9C3xazXipX27v\n\tO5CbllIHbzD2RJzVWSr9dc16BmtvMXPfKF6ouT8KI8Tdy7ulOpKmdWFO+1C7G92Gagla\n\tATKBnkFpC8Znbz/M9UgSAqu7f6F+GXgaCt/uHZGl+DvTOM6YGnZr8VUyiUV5alud1Vbz\n\tY+Og==", "X-Gm-Message-State": "AJaThX6q/zYcu0iXgo6O0jIqlCy5Z7ShgxomckLdMQ89WZuOa2XVtszV\n\ta1t4xMc/krMYDhXbfTAeaRRRXBHR", "X-Google-Smtp-Source": "ABhQp+RkcmVcPAc4OyumKLugR4bHCcyf3PduEpF00NzOMQHbUk7zTrrq61Xw3JiSbY+iHNunvBJCdw==", "X-Received": "by 10.159.253.147 with SMTP id q19mr220241pls.54.1510092824597; \n\tTue, 07 Nov 2017 14:13:44 -0800 (PST)", "From": "Matt Turner <mattst88@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 7 Nov 2017 14:13:32 -0800", "Message-Id": "<20171107221332.28283-3-mattst88@gmail.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20171107221332.28283-1-mattst88@gmail.com>", "References": "<20171107221332.28283-1-mattst88@gmail.com>", "X-Mailman-Approved-At": "Wed, 08 Nov 2017 14:49:21 +0000", "Subject": "[Intel-wired-lan] [PATCH 3/3] e1000e: Disable jumbo receive\n\tworkaround on Lynx Point and newer", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Matt Turner <matt.turner@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Matt Turner <matt.turner@intel.com>\n\nCommit 3e35d9918cbb (\"e1000e: adjust PM QoS request\") expanded the\napplication of what is evidently a hardware workaround to apply to all\ne1000e devices. Prior to the commit, it applied only to e1000_pch2lan\n(Sandy Bridge era) and the commit message notes that other earlier parts\nsuch as ICH9 and ICH10 suffer from the problem as well.\n\nThe workaround works by preventing the CPU from entering deep sleep\nstates, which increases energy consumption significantly. My Skylake\nCPU reaches the C10 state the PC8 package state with the MTU for its\nI219-LM set to 1500. At an MTU of 9000, it can only reach the C1E state\nand no low power package state at all. With this patch, the CPU again\nreaches the C10 state and (only) the PC2 package state. Not ideal, but an\nimprovement nonetheless.\n\nSigned-off-by: Matt Turner <matt.turner@intel.com>\n---\nThis patch is speculative -- I'm an Intel employee (not in the networking\ndivision), but I have no idea where to find documentation about the hardware\nbug in question. I'm hoping that someone more in the know can check if the\nhardware was fixed in subsequent generations and this workaround can be\ndisabled. I have chosen the pch2 cut off only because nothing further is\nmentioned about the bug in git history.\n\n drivers/net/ethernet/intel/e1000e/netdev.c | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 4dcff481c4b4..553f8bd45eea 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3277,7 +3277,8 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)\n \t/* With jumbo frames, excessive C-state transition latencies result\n \t * in dropped transactions.\n \t */\n-\tif (adapter->netdev->mtu > ETH_DATA_LEN) {\n+\tif (adapter->hw.mac.type <= e1000_pch2lan &&\n+\t adapter->netdev->mtu > ETH_DATA_LEN) {\n \t\tu32 lat =\n \t\t ((er32(PBA) & E1000_PBA_RXA_MASK) * 1024 -\n \t\t adapter->max_frame_size) * 8 / 1000;\n@@ -3292,9 +3293,6 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)\n \t\t\t \"Some CPU C-states have been disabled in order to \"\n \t\t\t \"enable jumbo frames\\n\");\n \t\tpm_qos_update_request(&adapter->pm_qos_req, lat);\n-\t} else {\n-\t\tpm_qos_update_request(&adapter->pm_qos_req,\n-\t\t\t\t PM_QOS_DEFAULT_VALUE);\n \t}\n \n \t/* Enable Receives */\n@@ -4625,8 +4623,9 @@ int e1000e_open(struct net_device *netdev)\n \t\te1000_update_mng_vlan(adapter);\n \n \t/* DMA latency requirement to workaround jumbo issue */\n-\tpm_qos_add_request(&adapter->pm_qos_req, PM_QOS_CPU_DMA_LATENCY,\n-\t\t\t PM_QOS_DEFAULT_VALUE);\n+\tif (adapter->hw.mac.type <= e1000_pch2lan)\n+\t\tpm_qos_add_request(&adapter->pm_qos_req, PM_QOS_CPU_DMA_LATENCY,\n+\t\t\t\t PM_QOS_DEFAULT_VALUE);\n \n \t/* before we allocate an interrupt, we must be ready to handle it.\n \t * Setting DEBUG_SHIRQ in the kernel makes it fire an interrupt\n@@ -4669,7 +4668,8 @@ int e1000e_open(struct net_device *netdev)\n \treturn 0;\n \n err_req_irq:\n-\tpm_qos_remove_request(&adapter->pm_qos_req);\n+\tif (adapter->hw.mac.type <= e1000_pch2lan)\n+\t\tpm_qos_remove_request(&adapter->pm_qos_req);\n \te1000e_release_hw_control(adapter);\n \te1000_power_down_phy(adapter);\n \te1000e_free_rx_resources(adapter->rx_ring);\n@@ -4733,7 +4733,8 @@ int e1000e_close(struct net_device *netdev)\n \t !test_bit(__E1000_TESTING, &adapter->state))\n \t\te1000e_release_hw_control(adapter);\n \n-\tpm_qos_remove_request(&adapter->pm_qos_req);\n+\tif (adapter->hw.mac.type <= e1000_pch2lan)\n+\t\tpm_qos_remove_request(&adapter->pm_qos_req);\n \n \tpm_runtime_put_sync(&pdev->dev);\n \n", "prefixes": [ "3/3" ] }