Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/835448/?format=api
{ "id": 835448, "url": "http://patchwork.ozlabs.org/api/patches/835448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171107200607.62104-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171107200607.62104-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2017-11-07T20:06:07", "name": "[net] i40e: fix the calculation of VFs mac addresses", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fcbb62467444b5f11758f90ea3155973035e98dc", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171107200607.62104-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 12380, "url": "http://patchwork.ozlabs.org/api/series/12380/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=12380", "date": "2017-11-07T20:06:07", "name": "[net] i40e: fix the calculation of VFs mac addresses", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/12380/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/835448/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/835448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yWgS71tvyz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Nov 2017 07:06:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D725A30909;\n\tTue, 7 Nov 2017 20:06:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4Se87bRFZkRt; Tue, 7 Nov 2017 20:06:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7B86930905;\n\tTue, 7 Nov 2017 20:06:43 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8C5021C2630\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 20:06:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 839618984B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 20:06:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id IZif9Wb7VTpx for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 20:06:40 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id B841E8984C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Nov 2017 20:06:40 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Nov 2017 12:06:40 -0800", "from jtkirshe-desk.jf.intel.com (HELO\n\tjtkirshe-DESK.amr.corp.intel.com.com) ([134.134.177.54])\n\tby orsmga002.jf.intel.com with ESMTP; 07 Nov 2017 12:06:39 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,360,1505804400\"; d=\"scan'208\";a=\"4684355\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 7 Nov 2017 12:06:07 -0800", "Message-Id": "<20171107200607.62104-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.14.2", "Subject": "[Intel-wired-lan] [net] i40e: fix the calculation of VFs mac\n\taddresses", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Zijie Pan <zijie.pan@6wind.com>,\n\tNicolas Dichtel <nicolas.dichtel@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Zijie Pan <zijie.pan@6wind.com>\n\nnum_mac should be increased only after the call to i40e_add_mac_filter().\n\nFixes: 5f527ba962e2 (\"i40e: Limit the number of MAC and VLAN addresses that can be added for VFs\")\nCC: Anjali Singhai Jain <anjali.singhai@intel.com>\nCC: Andrew Bowers <andrewx.bowers@intel.com>\nSigned-off-by: Zijie Pan <zijie.pan@6wind.com>\nSigned-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>\nReviewed-by: Tushar Dave <tushar.n.dave@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 21 +++++++++++----------\n 1 file changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 4d1e670f490e..2d1f3dbe67f1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -2115,18 +2115,19 @@ static int i40e_vc_add_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)\n \t\tstruct i40e_mac_filter *f;\n \n \t\tf = i40e_find_mac(vsi, al->list[i].addr);\n-\t\tif (!f)\n+\t\tif (!f) {\n \t\t\tf = i40e_add_mac_filter(vsi, al->list[i].addr);\n \n-\t\tif (!f) {\n-\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"Unable to add MAC filter %pM for VF %d\\n\",\n-\t\t\t\t al->list[i].addr, vf->vf_id);\n-\t\t\tret = I40E_ERR_PARAM;\n-\t\t\tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n-\t\t\tgoto error_param;\n-\t\t} else {\n-\t\t\tvf->num_mac++;\n+\t\t\tif (!f) {\n+\t\t\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\t\t\"Unable to add MAC filter %pM for VF %d\\n\",\n+\t\t\t\t\tal->list[i].addr, vf->vf_id);\n+\t\t\t\tret = I40E_ERR_PARAM;\n+\t\t\t\tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n+\t\t\t\tgoto error_param;\n+\t\t\t} else {\n+\t\t\t\tvf->num_mac++;\n+\t\t\t}\n \t\t}\n \t}\n \tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n", "prefixes": [ "net" ] }