Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/834472/?format=api
{ "id": 834472, "url": "http://patchwork.ozlabs.org/api/patches/834472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171106063159.32289-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171106063159.32289-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2017-11-06T06:31:59", "name": "[v2,1/1] e1000e: fix buffer overrun while the I219 is processing DMA transactions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "600f6dfc4ef50a3433454560ea71af37f0dc488f", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171106063159.32289-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 12006, "url": "http://patchwork.ozlabs.org/api/series/12006/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=12006", "date": "2017-11-06T06:31:59", "name": "[v2,1/1] e1000e: fix buffer overrun while the I219 is processing DMA transactions", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/12006/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/834472/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/834472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yVjQf20FBz9s4q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Nov 2017 17:32:09 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3C639304EA;\n\tMon, 6 Nov 2017 06:32:06 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id URjmm9g-EnRu; Mon, 6 Nov 2017 06:32:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7463B303F2;\n\tMon, 6 Nov 2017 06:32:05 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4F78F1C0000\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Nov 2017 06:32:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3E4F7303F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Nov 2017 06:32:04 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5kO8XIsYuMGA for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Nov 2017 06:32:03 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 4DB262EE8F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 6 Nov 2017 06:32:03 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga105.jf.intel.com with ESMTP; 05 Nov 2017 22:32:02 -0800", "from hostname.iil.intel.com (HELO ccdlinuxdev01.iil.intel.com)\n\t([143.185.162.145])\n\tby fmsmga005.fm.intel.com with ESMTP; 05 Nov 2017 22:32:00 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.44,351,1505804400\"; d=\"scan'208\";a=\"171909307\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "jeffrey.t.kirsher@intel.com, sasha.neftin@intel.com,\n\tintel-wired-lan@lists.osuosl.org, raanan.avargil@intel.com,\n\talexander.h.duyck@intel.com, dima.ruinskiy@intel.com", "Date": "Mon, 6 Nov 2017 08:31:59 +0200", "Message-Id": "<20171106063159.32289-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2 1/1] e1000e: fix buffer overrun while\n\tthe I219 is processing DMA transactions", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Description: Intel® 100/200 Series Chipset platforms\nreduced the round-trip latency for the LAN Controller\nDMA accesses, causing in some high performance cases a buffer\noverrun while the I219 LAN Connected Device is processing\nthe DMA transactions. I219LM and I219V devices can fall into\nunrecovered Tx hang under very stressfully UDP traffic and multiple\nreconnection of Ethernet cable. This Tx hang of the LAN Controller\nis only recovered if the system is rebooted. Slightly slow down\nDMA access by reducing the number of outstanding requests.\nThis workaround could have an impact on TCP traffic performance\non the platform. Disabling TSO eliminates performance loss for TCP\ntraffic without a noticeable impact on CPU performance.\n\nPlease, refer to I218/I219 specification update:\nhttps://www.intel.com/content/www/us/en/embedded/products/networking/\nethernet-connection-i218-family-documentation.html\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\nReviewed-by: Alexander H Duyck <alexander.h.duyck@intel.com>\nReviewed-by: Dima Ruinskiy <dima.ruinskiy@intel.com>\nReviewed-by: Raanan Avargil <raanan.avargil@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.h | 3 ++-\n drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++++++---\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.h b/drivers/net/ethernet/intel/e1000e/ich8lan.h\nindex 67163ca898ba..e23d8da9b15b 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.h\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.h\n@@ -113,7 +113,8 @@\n #define NVM_SIZE_MULTIPLIER 4096\t/*multiplier for NVMS field */\n #define E1000_FLASH_BASE_ADDR 0xE000\t/*offset of NVM access regs */\n #define E1000_CTRL_EXT_NVMVS 0x3\t/*NVM valid sector */\n-#define E1000_TARC0_CB_MULTIQ_3_REQ\t(1 << 28 | 1 << 29)\n+#define E1000_TARC0_CB_MULTIQ_3_REQ 0x30000000\n+#define E1000_TARC0_CB_MULTIQ_2_REQ 0x20000000\n #define PCIE_ICH8_SNOOP_ALL\tPCIE_NO_SNOOP_ALL\n \n #define E1000_ICH_RAR_ENTRIES\t7\ndiff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex f2f49239b015..9f18d39bdc8f 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3034,9 +3034,12 @@ static void e1000_configure_tx(struct e1000_adapter *adapter)\n \t\tew32(IOSFPC, reg_val);\n \n \t\treg_val = er32(TARC(0));\n-\t\t/* SPT and KBL Si errata workaround to avoid Tx hang */\n-\t\treg_val &= ~BIT(28);\n-\t\treg_val |= BIT(29);\n+\t\t/* SPT and KBL Si errata workaround to avoid Tx hang.\n+\t\t * Dropping the number of outstanding requests from\n+\t\t * 3 to 2 in order to avoid a buffer overrun.\n+\t\t */\n+\t\treg_val &= ~E1000_TARC0_CB_MULTIQ_3_REQ;\n+\t\treg_val |= E1000_TARC0_CB_MULTIQ_2_REQ;\n \t\tew32(TARC(0), reg_val);\n \t}\n }\n", "prefixes": [ "v2", "1/1" ] }