Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/834342/?format=api
{ "id": 834342, "url": "http://patchwork.ozlabs.org/api/patches/834342/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171105130429.6399-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171105130429.6399-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-11-05T13:04:29", "name": "i40e: remove redundant initialization of read_size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b60eab787d2408e800272a9eee6280749e319239", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171105130429.6399-1-colin.king@canonical.com/mbox/", "series": [ { "id": 11928, "url": "http://patchwork.ozlabs.org/api/series/11928/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=11928", "date": "2017-11-05T13:04:29", "name": "i40e: remove redundant initialization of read_size", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11928/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/834342/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/834342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yVG9z223hz9s7p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Nov 2017 00:04:37 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 39071266E0;\n\tSun, 5 Nov 2017 13:04:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id N0AG1-50DwLm; Sun, 5 Nov 2017 13:04:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5B1DD26400;\n\tSun, 5 Nov 2017 13:04:35 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E80841C2AE4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Nov 2017 13:04:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E1C298555F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Nov 2017 13:04:33 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id S_pFleinVrIu for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Nov 2017 13:04:33 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 1238585537\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Nov 2017 13:04:33 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1eBKbG-0004ym-BS; Sun, 05 Nov 2017 13:04:30 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Sun, 5 Nov 2017 13:04:29 +0000", "Message-Id": "<20171105130429.6399-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: remove redundant initialization of\n\tread_size", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nVariable read_size is initialized and this value is never read, it is\ninstead set inside the do-loop, hence the intialization is redundant\nand can be removed. Cleans up clang warning:\n\ndrivers/net/ethernet/intel/i40e/i40e_nvm.c:390:6: warning: Value stored\nto 'read_size' during its initialization is never read\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\nindex 0ccab0a5d717..8f444a40c3f9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n@@ -387,7 +387,7 @@ static i40e_status i40e_read_nvm_buffer_aq(struct i40e_hw *hw, u16 offset,\n \t\t\t\t\t u16 *words, u16 *data)\n {\n \ti40e_status ret_code;\n-\tu16 read_size = *words;\n+\tu16 read_size;\n \tbool last_cmd = false;\n \tu16 words_read = 0;\n \tu16 i = 0;\n", "prefixes": [] }