Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/833584/?format=api
{ "id": 833584, "url": "http://patchwork.ozlabs.org/api/patches/833584/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171102233417.15146.6991.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171102233417.15146.6991.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-02T23:34:41", "name": "[jkirsher/next-queue,4/5] dev: Clean-up __skb_tx_hash to match up with traffic class based configs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f3dd58e028eb34eeedd868a2b0bf411868c4e337", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171102233417.15146.6991.stgit@localhost.localdomain/mbox/", "series": [ { "id": 11616, "url": "http://patchwork.ozlabs.org/api/series/11616/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=11616", "date": "2017-11-02T23:33:09", "name": "macvlan offload fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11616/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833584/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833584/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RjEdySKk\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yShJS6zL2z9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 3 Nov 2017 10:34:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5236C8940F;\n\tThu, 2 Nov 2017 23:34:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zA9HZrjfhkzQ; Thu, 2 Nov 2017 23:34:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3041F890DC;\n\tThu, 2 Nov 2017 23:34:44 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 264F41C2306\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1D4E888139\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:43 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aUpxtIkVRvSP for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:42 +0000 (UTC)", "from mail-pf0-f194.google.com (mail-pf0-f194.google.com\n\t[209.85.192.194])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 8E4B082BEA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:42 +0000 (UTC)", "by mail-pf0-f194.google.com with SMTP id p87so855423pfj.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 02 Nov 2017 16:34:42 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tm1sm7667336pfk.54.2017.11.02.16.34.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Nov 2017 16:34:41 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=ejmPs4d6WGksKqGaSvVZvzQ4R2XgnE32rVqWT/NiCTA=;\n\tb=RjEdySKk9u2SrTdOBE4hweiNT5LTvf/dbv6PMVXzZZXG1gXJLz0V0hWG59jtZh/EFs\n\tmW6GkOFBd3qWG6n73ul0m1qvz4fhGffshAl3b9hn1R+BQEy3fg1O3z2Aufl6kEpDNlSh\n\too1nipCDqB9HsHRNmMwig1xeS+obB4KkX2jPiPqQg9/Dbvw1ozmEoPEBX1NIbcK1eGcD\n\twfqISVnsNc5X7a1ZRaj4J3NzoIhfruyNcFwysbgZxnW0bbxw9uyobPOQi3tZJ2Shdb1E\n\tfdk6HIjPZX/oUg/L59yOrzZWcpPFTQ9jEMuC+WaG0HAtFdolbenc2iEH07zbfnwwsNsJ\n\tfYWA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=ejmPs4d6WGksKqGaSvVZvzQ4R2XgnE32rVqWT/NiCTA=;\n\tb=IZLW8RuGFxDtnA8OAXaovDb0R+rOUMfw97/x+DWRVFSZjbrFoNGxxPXsjemqJlg6D3\n\tBNepztmjjWoiAgBebw0S8Npo8nEOmFBy0MDUfoaphPrmAxcwop5UQ9nChJ73S6YOqzOA\n\toTqgZKFlC0fVCiFdSqZ1ylULXPSFk5juEmHiqY+5RRFFDhoBzgjS0e4+Kup1jGkmK4r6\n\tOm6S+oh37WViIKOQGgUeTGL2vWb0jrSS0/fej+NPw2KIZde0FSyVtOTqlyH+m/dOFn5l\n\tIlbmaEwy53SamiJyIHu1SEZ0rO0YjLQQ9HrA12YN3Yv2zi2Q1n7xJ4zsoIiw5V+2Cf1Q\n\ten+A==", "X-Gm-Message-State": "AMCzsaUqJxWu75hxmMo0ADeqy8ahCCVUxz/K1aUPd7qO1hrHFOPusWtg\n\tNdQwp2Xzm2B39BWCOjqNCx9XY2O4", "X-Google-Smtp-Source": "ABhQp+QQ01eccjlFow0I0mLeKGS+UkmzkE9PbIRGcH52BsXpVql+zOBLGxFlOX6zrdYe7+fHGPN3yg==", "X-Received": "by 10.84.215.207 with SMTP id g15mr4941034plj.11.1509665681979; \n\tThu, 02 Nov 2017 16:34:41 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Date": "Thu, 02 Nov 2017 16:34:41 -0700", "Message-ID": "<20171102233417.15146.6991.stgit@localhost.localdomain>", "In-Reply-To": "<20171102232857.15146.21583.stgit@localhost.localdomain>", "References": "<20171102232857.15146.21583.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 4/5] dev: Clean-up\n\t__skb_tx_hash to match up with traffic class based configs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis patch is mostly just a minor clean-up so that we avoid letting a\npacket jump from one traffic class to another just based on the Rx queue.\nInstead we now use that queue number as an offset within the traffic class.\nHandling it this way allows us to operate more cleanly in a mixed\nenvironment that is doing routing over multiple interfaces that may not\nhave the same queue configuration.\n\nThis patch includes a minor clean-up of variable declaration as well to get\nthings into the reverse xmas tree format.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n net/core/dev.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/net/core/dev.c b/net/core/dev.c\nindex 24ac9083bc13..fd51b8703277 100644\n--- a/net/core/dev.c\n+++ b/net/core/dev.c\n@@ -2573,16 +2573,9 @@ void netif_device_attach(struct net_device *dev)\n u16 __skb_tx_hash(const struct net_device *dev, struct sk_buff *skb,\n \t\t unsigned int num_tx_queues)\n {\n-\tu32 hash;\n-\tu16 qoffset = 0;\n \tu16 qcount = num_tx_queues;\n-\n-\tif (skb_rx_queue_recorded(skb)) {\n-\t\thash = skb_get_rx_queue(skb);\n-\t\twhile (unlikely(hash >= num_tx_queues))\n-\t\t\thash -= num_tx_queues;\n-\t\treturn hash;\n-\t}\n+\tu16 qoffset = 0;\n+\tu32 hash;\n \n \tif (dev->num_tc) {\n \t\tu8 tc = netdev_get_prio_tc_map(dev, skb->priority);\n@@ -2591,6 +2584,13 @@ u16 __skb_tx_hash(const struct net_device *dev, struct sk_buff *skb,\n \t\tqcount = dev->tc_to_txq[tc].count;\n \t}\n \n+\tif (skb_rx_queue_recorded(skb)) {\n+\t\thash = skb_get_rx_queue(skb);\n+\t\twhile (unlikely(hash >= qcount))\n+\t\t\thash -= qcount;\n+\t\treturn hash + qoffset;\n+\t}\n+\n \treturn (u16) reciprocal_scale(skb_get_hash(skb), qcount) + qoffset;\n }\n EXPORT_SYMBOL(__skb_tx_hash);\n", "prefixes": [ "jkirsher/next-queue", "4/5" ] }