Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/833582/?format=api
{ "id": 833582, "url": "http://patchwork.ozlabs.org/api/patches/833582/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171102233351.15146.16006.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171102233351.15146.16006.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-02T23:34:11", "name": "[jkirsher/next-queue,3/5] ixgbe: Fix handling of macvlan Tx offload", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f5a5e171a8298b6fca070cc2929f7b1425fbfc93", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171102233351.15146.16006.stgit@localhost.localdomain/mbox/", "series": [ { "id": 11616, "url": "http://patchwork.ozlabs.org/api/series/11616/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=11616", "date": "2017-11-02T23:33:09", "name": "macvlan offload fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11616/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833582/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833582/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ueQ9pg9E\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yShHs4C9Kz9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 3 Nov 2017 10:34:17 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E980784E4A;\n\tThu, 2 Nov 2017 23:34:15 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sAEIkIEpE8Gv; Thu, 2 Nov 2017 23:34:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8CB5F84E63;\n\tThu, 2 Nov 2017 23:34:14 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id EE28E1C2306\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E6E7884E63\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:12 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LalYuuIXwZxM for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:12 +0000 (UTC)", "from mail-pg0-f67.google.com (mail-pg0-f67.google.com\n\t[74.125.83.67])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 8109984E4A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:34:12 +0000 (UTC)", "by mail-pg0-f67.google.com with SMTP id r25so955332pgn.4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 02 Nov 2017 16:34:12 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tj6sm6948411pgn.68.2017.11.02.16.34.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Nov 2017 16:34:11 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=R9K54CpAn8YtvMqkfDKdtYoAFzJoDB4/y2QCXWS9VVY=;\n\tb=ueQ9pg9EkD1SrvRyyMc1G+k0OzJhPLmc6vjJQA2JIbLr58MBiobATuj80tQiaWhMSa\n\tqPt4R4MlXhJSQI1QwLd6hTqCCuFSynngmORqGhOZcUZzq/SCu1cGXs0o64YmlDCZkB+L\n\tLBv0skMHzrSBOL8M1JxUG0lmVLFhemJgEf+RIxDup5OxDpkI+FrBLD9wh2LOzBJK61yx\n\tjlTKhe3iCLwbkrQWY686JZ7UUisjw79Ha97SpbWR2P+u9drANsFSh4ykfiOBRfEBErJC\n\tTcIIE9CH9bJRCMjvAHrc5GjEfb9Uq6REh7usryLw1em0OT5ZJ/G5xtMmPsohfjwEaD+i\n\tHVYw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=R9K54CpAn8YtvMqkfDKdtYoAFzJoDB4/y2QCXWS9VVY=;\n\tb=fbMQZBZQ3UvivIXtZGHvatyTbsrzqI3ui/ZtBcwZjn1lED1doYTbjB5ES5W63Pag9c\n\t+o11rg2h5MwXgbAGfdL11DNhAP/9IDvVL+KFuia/leMpQoothnkgTSLSoV63ycnAknna\n\tKoCyDGmtSrpgfPrAB7WtE7plMuIKluk0+J/atyPr54C6oV6BNGA4tCNlCqwapi632t1F\n\tAi2+68CQS/PlnoVNqzj8MP8pYSvR0oJ72CDmIvhCwSBAtlj+vghoBWz0mo6aBjKsUc7f\n\tVyidG/Xpl4yA8NBaiWMhF81Z87wSKPHH4XIXQA22pvmm4qowTXbQgV8EXIXilrQ6XVwk\n\tZ1sg==", "X-Gm-Message-State": "AMCzsaVNwNWbKHDv6ZVrfRzfioNLBJmxL7NVxuVcSA1NxIwbAzBgm0Om\n\t92KtuipGXNCNpi0kr9VXyPo+hf38", "X-Google-Smtp-Source": "ABhQp+QzcG1BeqITeeYAWNJImTOKtsv8FXmchOStKjzKOgwjVFLaxidr/rA8R1PicDdz9dNgIGEsdQ==", "X-Received": "by 10.101.76.195 with SMTP id n3mr5467871pgt.120.1509665652039; \n\tThu, 02 Nov 2017 16:34:12 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Date": "Thu, 02 Nov 2017 16:34:11 -0700", "Message-ID": "<20171102233351.15146.16006.stgit@localhost.localdomain>", "In-Reply-To": "<20171102232857.15146.21583.stgit@localhost.localdomain>", "References": "<20171102232857.15146.21583.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 3/5] ixgbe: Fix\n\thandling of macvlan Tx offload", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis update makes it so that we report the actual number of Tx queues via\nreal_num_tx_queues but are still restricted to RSS on only the first pool\nby setting num_tc equal to 1. Doing this locks us into only having the\nability to setup XPS on the queues in that pool, and only those queues\nshould be used for transmitting anything other than macvlan traffic.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 69ef35d13c36..b22ec4b9d02c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6638,8 +6638,9 @@ int ixgbe_open(struct net_device *netdev)\n \t\tgoto err_req_irq;\n \n \t/* Notify the stack of the actual queue counts. */\n-\tif (adapter->num_rx_pools > 1)\n-\t\tqueues = adapter->num_rx_queues_per_pool;\n+\tif (adapter->num_rx_pools > 1 &&\n+\t adapter->num_tx_queues > IXGBE_MAX_L2A_QUEUES)\n+\t\tqueues = IXGBE_MAX_L2A_QUEUES;\n \telse\n \t\tqueues = adapter->num_tx_queues;\n \n@@ -8901,6 +8902,18 @@ int ixgbe_setup_tc(struct net_device *dev, u8 tc)\n \t\tif (adapter->hw.mac.type == ixgbe_mac_82598EB)\n \t\t\tadapter->hw.fc.requested_mode = adapter->last_lfc_mode;\n \n+\t\t/* To support macvlan offload we have to use num_tc to\n+\t\t * restrict the queues that can be used by the device.\n+\t\t * By doing this we can avoid reporing a false number of\n+\t\t * queues.\n+\t\t */\n+\t\tif (adapter->num_rx_pools > 1) {\n+\t\t\tu16 qpp = adapter->num_rx_queues_per_pool;\n+\n+\t\t\tnetdev_set_num_tc(dev, 1);\n+\t\t\tnetdev_set_tc_queue(dev, 0, qpp, 0);\n+\t\t}\n+\n \t\tadapter->flags &= ~IXGBE_FLAG_DCB_ENABLED;\n \n \t\tadapter->temp_dcb_cfg.pfc_mode_enable = false;\n", "prefixes": [ "jkirsher/next-queue", "3/5" ] }