Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/833580/?format=api
{ "id": 833580, "url": "http://patchwork.ozlabs.org/api/patches/833580/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171102233336.15146.31137.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171102233336.15146.31137.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-11-02T23:33:45", "name": "[jkirsher/next-queue,2/5] fm10k: Fix VLAN configuration for macvlan offload", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "5cdbf356925870adcaaaba59fc852581378bae8f", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171102233336.15146.31137.stgit@localhost.localdomain/mbox/", "series": [ { "id": 11616, "url": "http://patchwork.ozlabs.org/api/series/11616/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=11616", "date": "2017-11-02T23:33:09", "name": "macvlan offload fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/11616/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/833580/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/833580/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FkV99kpY\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yShHP5bLjz9sRn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 3 Nov 2017 10:33:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DB73B88ABC;\n\tThu, 2 Nov 2017 23:33:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GCkWaQQIJ6Ta; Thu, 2 Nov 2017 23:33:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F387588A58;\n\tThu, 2 Nov 2017 23:33:49 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6F8C51C2306\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:33:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 66E03828F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:33:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wT3s9C6HcFnA for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:33:47 +0000 (UTC)", "from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 6967282766\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 2 Nov 2017 23:33:47 +0000 (UTC)", "by mail-pg0-f65.google.com with SMTP id l24so938895pgu.11\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 02 Nov 2017 16:33:47 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\ty84sm7904388pff.158.2017.11.02.16.33.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 02 Nov 2017 16:33:46 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=O6djppOfLcf2mYR0qC4zIV32MkDJ6tpMULtX30dxdpM=;\n\tb=FkV99kpYYjey63KSo1fNexV7iwOVAu3rrJgOODZVXGyaWXcaE+17f+VvdYojh5f3ZV\n\tjuvVIEno243YWc6yBnymBDXk+PaZoRXjUYZr7s9M7lzEz05pdH9fCcT95dd/wdxZwLqJ\n\t6T472NeuqnH9RL9OwEemIVlAaf+v1hmOCmkSWFWA3BCHPkiJftIv7sBCWvUMjX2IF7Q3\n\teprRSQpAa05kTXZ06F5GEOMIU11VGIrs1o/ExE8yByiXjfHAAEI/0lKLedq+aQyeFotB\n\tMzI02us7yL9X0k3uDCLLBVkp6o9tSFjS9HE/6r4Lnc/8ug87wHOxs4JsMVQBY87/Sf+p\n\t2DWw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=O6djppOfLcf2mYR0qC4zIV32MkDJ6tpMULtX30dxdpM=;\n\tb=eghkvgKwMKxJJHCjTa+hkMSibuz9mLswXfX4ra0xQaHIyZeOrk4QdjgWHoRVWQLMz0\n\tHi1JxiIWWhzQD5L+JFDT1QeybNnXMoVJPr187fkWULtsnaZJm1OWLchEiN2dRQpPNye3\n\tnbI/9maPC6+klgc0wcDrk5u1maXapxYkYKWQPZkAcxwSvWHL6wq1IWm1AhNC4OIdm1/G\n\t/AlBqT6/o8HcOSCbpioJDCbTydCru0LpSYApMGssm6zioEWDES+/4l0tu4GgTH4j2O86\n\tcs/h/nI65J490104GAGXo1xyBjAyyc6twd2FWXD6Sxxn8ETCCB17IS8D6lnhOO6blff4\n\tASPA==", "X-Gm-Message-State": "AMCzsaUPBf0o1yf3eU/3JFQQ4xlrLcRAy2OO+Y6ApgMX0jZrwzuR74VQ\n\ttjBw+UhaB7/MHzFEIW0zvkE84nTA", "X-Google-Smtp-Source": "ABhQp+RmZroeO9DQFQbPvk+0of9/boOv4Yukw1SIWb+Zbo6MhFgUqEJgMH1qYADgG2BVv02wFt9FDA==", "X-Received": "by 10.84.197.35 with SMTP id m32mr4964977pld.306.1509665626814; \n\tThu, 02 Nov 2017 16:33:46 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Date": "Thu, 02 Nov 2017 16:33:45 -0700", "Message-ID": "<20171102233336.15146.31137.stgit@localhost.localdomain>", "In-Reply-To": "<20171102232857.15146.21583.stgit@localhost.localdomain>", "References": "<20171102232857.15146.21583.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN\n\tconfiguration for macvlan offload", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThe fm10k driver didn't work correctly when macvlan offload was enabled.\nSpecifically what would occur is that we would see no unicast packets being\nreceived. This was traced down to us not correctly configuring the default\nVLAN ID for the port and defaulting to 0.\n\nTo correct this we either use the default ID provided by the switch or\nsimply use 1. With that we are able to pass and receive traffic without any\nissues.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 81e4425f0529..1280127077de 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -1490,7 +1490,7 @@ static void *fm10k_dfwd_add_station(struct net_device *dev,\n \t\thw->mac.ops.update_xcast_mode(hw, glort,\n \t\t\t\t\t FM10K_XCAST_MODE_MULTI);\n \t\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n-\t\t\t\t\t0, true);\n+\t\t\t\t\thw->mac.default_vid ? : 1, true);\n \t}\n \n \tfm10k_mbx_unlock(interface);\n@@ -1530,7 +1530,7 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)\n \t\thw->mac.ops.update_xcast_mode(hw, glort,\n \t\t\t\t\t FM10K_XCAST_MODE_NONE);\n \t\tfm10k_queue_mac_request(interface, glort, sdev->dev_addr,\n-\t\t\t\t\t0, false);\n+\t\t\t\t\thw->mac.default_vid ? : 1, false);\n \t}\n \n \tfm10k_mbx_unlock(interface);\n", "prefixes": [ "jkirsher/next-queue", "2/5" ] }