Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/830055/?format=api
{ "id": 830055, "url": "http://patchwork.ozlabs.org/api/patches/830055/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1508857240-5201-1-git-send-email-paul.greenwalt@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1508857240-5201-1-git-send-email-paul.greenwalt@intel.com>", "list_archive_url": null, "date": "2017-10-24T15:00:40", "name": "[v3] ixgbe: advertise highest capable link speed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f936c4563c2464b991843dc084eefb619a541b7c", "submitter": { "id": 71166, "url": "http://patchwork.ozlabs.org/api/people/71166/?format=api", "name": "Paul Greenwalt", "email": "paul.greenwalt@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1508857240-5201-1-git-send-email-paul.greenwalt@intel.com/mbox/", "series": [ { "id": 10061, "url": "http://patchwork.ozlabs.org/api/series/10061/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=10061", "date": "2017-10-24T15:00:40", "name": "[v3] ixgbe: advertise highest capable link speed", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/10061/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/830055/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/830055/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yM6tQ3JRbz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Oct 2017 09:11:26 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8063988AE8;\n\tTue, 24 Oct 2017 22:11:24 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Pj83NYL-1yAt; Tue, 24 Oct 2017 22:11:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B67F988AA6;\n\tTue, 24 Oct 2017 22:11:23 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 51E451C2232\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 22:11:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 45B0D88BCD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 22:11:22 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UJfZvOcozGXS for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 22:11:21 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7ED6188BBA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 22:11:21 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga105.jf.intel.com with ESMTP; 24 Oct 2017 15:11:20 -0700", "from unknown (HELO localhost.jf.intel.com) ([134.134.177.139])\n\tby orsmga005.jf.intel.com with ESMTP; 24 Oct 2017 15:11:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.43,430,1503385200\"; d=\"scan'208\";a=\"164508948\"", "From": "Paul Greenwalt <paul.greenwalt@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Oct 2017 11:00:40 -0400", "Message-Id": "<1508857240-5201-1-git-send-email-paul.greenwalt@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[Intel-wired-lan] [PATCH v3] ixgbe: advertise highest capable link\n\tspeed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On module insert advertise highest capable link speed. If module is\ncapable of 10G, then advertise 10G, else advertise modules capable\nlink speeds.\n\nv2 - Simplify logic based on feedback\nv3 - Fix format error\n\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 1e1aee1..a8d4be8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7648,6 +7648,7 @@ static void ixgbe_sfp_detection_subtask(struct ixgbe_adapter *adapter)\n static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n+\tu32 cap_speed;\n \tu32 speed;\n \tbool autoneg = false;\n \n@@ -7660,16 +7661,14 @@ static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)\n \n \tadapter->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;\n \n-\tspeed = hw->phy.autoneg_advertised;\n-\tif ((!speed) && (hw->mac.ops.get_link_capabilities)) {\n-\t\thw->mac.ops.get_link_capabilities(hw, &speed, &autoneg);\n+\thw->mac.ops.get_link_capabilities(hw, &cap_speed, &autoneg);\n \n-\t\t/* setup the highest link when no autoneg */\n-\t\tif (!autoneg) {\n-\t\t\tif (speed & IXGBE_LINK_SPEED_10GB_FULL)\n-\t\t\t\tspeed = IXGBE_LINK_SPEED_10GB_FULL;\n-\t\t}\n-\t}\n+\t/* advertise highest capable link speed */\n+\tif (!autoneg && (cap_speed & IXGBE_LINK_SPEED_10GB_FULL))\n+\t\tspeed = IXGBE_LINK_SPEED_10GB_FULL;\n+\telse\n+\t\tspeed = cap_speed & (IXGBE_LINK_SPEED_10GB_FULL |\n+\t\t\t\t IXGBE_LINK_SPEED_1GB_FULL);\n \n \tif (hw->mac.ops.setup_link)\n \t\thw->mac.ops.setup_link(hw, speed, true);\n", "prefixes": [ "v3" ] }