Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/829728/?format=api
{ "id": 829728, "url": "http://patchwork.ozlabs.org/api/patches/829728/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1508772169-4606-1-git-send-email-paul.greenwalt@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1508772169-4606-1-git-send-email-paul.greenwalt@intel.com>", "list_archive_url": null, "date": "2017-10-23T15:22:49", "name": "ixgbe: advertise highest capable link speed", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "daf6b0635a67c564dd4ff3e6e03e00862d1e7689", "submitter": { "id": 71166, "url": "http://patchwork.ozlabs.org/api/people/71166/?format=api", "name": "Paul Greenwalt", "email": "paul.greenwalt@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1508772169-4606-1-git-send-email-paul.greenwalt@intel.com/mbox/", "series": [ { "id": 9876, "url": "http://patchwork.ozlabs.org/api/series/9876/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=9876", "date": "2017-10-23T15:22:49", "name": "ixgbe: advertise highest capable link speed", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/9876/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/829728/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/829728/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yLWQV1mXCz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 24 Oct 2017 09:33:38 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8852B2FDD6;\n\tMon, 23 Oct 2017 22:33:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7OANmMHujAeF; Mon, 23 Oct 2017 22:33:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 641362FD48;\n\tMon, 23 Oct 2017 22:33:34 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C1B971BFC1A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:33:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B714E87560\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:33:32 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 14nkHQFhZ1Xf for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:33:32 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id DF4578755C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:33:31 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Oct 2017 15:33:31 -0700", "from win-l0ubgtdc98d.jf.intel.com ([134.134.177.139])\n\tby orsmga003.jf.intel.com with ESMTP; 23 Oct 2017 15:33:30 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.43,424,1503385200\"; d=\"scan'208\";\n\ta=\"1028461945\"", "From": "Paul Greenwalt <paul.greenwalt@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 23 Oct 2017 11:22:49 -0400", "Message-Id": "<1508772169-4606-1-git-send-email-paul.greenwalt@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: advertise highest capable link\n\tspeed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "On module insert advertise highest capable link speed. If module is\ncapable of 10G, then advertise 10G. If autoneg is enabled, then\nadvertise modules capable link speeds. If module is capable of\nsingle-rate 1G, then advertise 1G.\n\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 901ab12..2bd132c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7648,7 +7648,8 @@ static void ixgbe_sfp_detection_subtask(struct ixgbe_adapter *adapter)\n static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n-\tu32 speed;\n+\tu32 cap_speed;\n+\tu32 speed = 0;\n \tbool autoneg = false;\n \n \tif (!(adapter->flags & IXGBE_FLAG_NEED_LINK_CONFIG))\n@@ -7660,15 +7661,16 @@ static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)\n \n \tadapter->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;\n \n-\tspeed = hw->phy.autoneg_advertised;\n-\tif ((!speed) && (hw->mac.ops.get_link_capabilities)) {\n-\t\thw->mac.ops.get_link_capabilities(hw, &speed, &autoneg);\n+\thw->mac.ops.get_link_capabilities(hw, &cap_speed, &autoneg);\n \n-\t\t/* setup the highest link when no autoneg */\n-\t\tif (!autoneg) {\n-\t\t\tif (speed & IXGBE_LINK_SPEED_10GB_FULL)\n-\t\t\t\tspeed = IXGBE_LINK_SPEED_10GB_FULL;\n-\t\t}\n+\t/* advertise highest capable link speed */\n+\tif (cap_speed & IXGBE_LINK_SPEED_10GB_FULL) {\n+\t\tif (!autoneg)\n+\t\t\tspeed = IXGBE_LINK_SPEED_10GB_FULL;\n+\t\telse\n+\t\t\tspeed = cap_speed;\n+\t} else if (cap_speed == IXGBE_LINK_SPEED_1GB_FULL) {\n+\t\tspeed = IXGBE_LINK_SPEED_1GB_FULL;\n \t}\n \n \tif (hw->mac.ops.setup_link)\n", "prefixes": [] }