Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/829726/?format=api
{ "id": 829726, "url": "http://patchwork.ozlabs.org/api/patches/829726/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1508772069-4448-1-git-send-email-paul.greenwalt@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1508772069-4448-1-git-send-email-paul.greenwalt@intel.com>", "list_archive_url": null, "date": "2017-10-23T15:21:09", "name": "ixgbe: add bounds check for debugfs register access", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "10450c38cab6919d1e3f5caf3b935ad9a1c1b3c9", "submitter": { "id": 71166, "url": "http://patchwork.ozlabs.org/api/people/71166/?format=api", "name": "Paul Greenwalt", "email": "paul.greenwalt@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1508772069-4448-1-git-send-email-paul.greenwalt@intel.com/mbox/", "series": [ { "id": 9874, "url": "http://patchwork.ozlabs.org/api/series/9874/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=9874", "date": "2017-10-23T15:21:09", "name": "ixgbe: add bounds check for debugfs register access", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/9874/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/829726/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/829726/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yLWP25Z9kz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 24 Oct 2017 09:32:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 054B88755C;\n\tMon, 23 Oct 2017 22:32:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DBdOKKuUMo8q; Mon, 23 Oct 2017 22:32:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D4C0687560;\n\tMon, 23 Oct 2017 22:32:18 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A92E1BFC1A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:32:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 23BD687560\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:32:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CatasMagBXMR for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:32:15 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 942978755C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 23 Oct 2017 22:32:15 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Oct 2017 15:31:51 -0700", "from win-l0ubgtdc98d.jf.intel.com ([134.134.177.139])\n\tby fmsmga001.fm.intel.com with ESMTP; 23 Oct 2017 15:31:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.43,424,1503385200\"; d=\"scan'208\";\n\ta=\"1209169028\"", "From": "Paul Greenwalt <paul.greenwalt@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 23 Oct 2017 11:21:09 -0400", "Message-Id": "<1508772069-4448-1-git-send-email-paul.greenwalt@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: add bounds check for debugfs\n\tregister access", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Add bounds check for debugfs read and write register access.\n\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c\nindex 5e2c1e3..4fcd980 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c\n@@ -103,7 +103,8 @@ static ssize_t ixgbe_dbg_reg_ops_write(struct file *filp,\n \t\tu32 reg, value;\n \t\tint cnt;\n \t\tcnt = sscanf(&ixgbe_dbg_reg_ops_buf[5], \"%x %x\", ®, &value);\n-\t\tif (cnt == 2) {\n+\t\t/* check format and bounds check register access */\n+\t\tif (cnt == 2 && reg <= IXGBE_HFDR) {\n \t\t\tIXGBE_WRITE_REG(&adapter->hw, reg, value);\n \t\t\tvalue = IXGBE_READ_REG(&adapter->hw, reg);\n \t\t\te_dev_info(\"write: 0x%08x = 0x%08x\\n\", reg, value);\n@@ -114,7 +115,8 @@ static ssize_t ixgbe_dbg_reg_ops_write(struct file *filp,\n \t\tu32 reg, value;\n \t\tint cnt;\n \t\tcnt = sscanf(&ixgbe_dbg_reg_ops_buf[4], \"%x\", ®);\n-\t\tif (cnt == 1) {\n+\t\t/* check format and bounds check register access */\n+\t\tif (cnt == 1 && reg <= IXGBE_HFDR) {\n \t\t\tvalue = IXGBE_READ_REG(&adapter->hw, reg);\n \t\t\te_dev_info(\"read 0x%08x = 0x%08x\\n\", reg, value);\n \t\t} else {\n", "prefixes": [] }