Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/828975/?format=api
{ "id": 828975, "url": "http://patchwork.ozlabs.org/api/patches/828975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171022005030.19175.91947.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171022005030.19175.91947.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2017-10-22T00:51:50", "name": "[jkirsher/next-queue] i40e/i40evf: Revert \"i40e/i40evf: bump tail only in multiples of 8\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6e944c46f10be90297e06ed5896070940374d707", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171022005030.19175.91947.stgit@localhost.localdomain/mbox/", "series": [ { "id": 9498, "url": "http://patchwork.ozlabs.org/api/series/9498/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=9498", "date": "2017-10-22T00:51:50", "name": "[jkirsher/next-queue] i40e/i40evf: Revert \"i40e/i40evf: bump tail only in multiples of 8\"", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/9498/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/828975/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/828975/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"phfjhGqx\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yKLb70llVz9t2W\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 22 Oct 2017 11:52:01 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 44704871E1;\n\tSun, 22 Oct 2017 00:51:59 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qHfclgmKwpuU; Sun, 22 Oct 2017 00:51:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 677388724A;\n\tSun, 22 Oct 2017 00:51:56 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BAA241CEF17\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 22 Oct 2017 00:51:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B05A42E156\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 22 Oct 2017 00:51:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id o0BtKeTds+5N for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 22 Oct 2017 00:51:53 +0000 (UTC)", "from mail-io0-f196.google.com (mail-io0-f196.google.com\n\t[209.85.223.196])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 57BBD26162\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 22 Oct 2017 00:51:53 +0000 (UTC)", "by mail-io0-f196.google.com with SMTP id b186so16767341iof.8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 21 Oct 2017 17:51:53 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tq72sm960023itb.0.2017.10.21.17.51.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 21 Oct 2017 17:51:51 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=Y6iz7jWh4724dUF5BqqobB55GMzGDQkbUQOi6fv3r+c=;\n\tb=phfjhGqxvEFGQIZj3r+DVklLKje7bsFWJfD3jCpjh76Oif+kC4XmAsW4OsVdB8C1f+\n\tiN9LQ9mP5LydmhuVDmtreRav8TcqDee1/ngLUaa+1Z0B3+rDPEcI+fxs1ikx5JR9rlmX\n\tX0Mwm/MAZ66NSmvloVOwrdUN5Y132FJIcu3DeusAMge+S3eycnWpaanbz8zcX4hkUc5b\n\t9veVoJvJpo8FiWRH0zDwOpLYZtB4zBrr1X6utGBqZkzVqSCnDkyaCYQLklbqvYgtkWgo\n\tUR4pGxJ5Erh9HFNtJxHNMHGJ7hd/vwQuNMxoVep1Ye7xU0Q7N7K1JrPB0/M30/ImftZO\n\tCozA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=Y6iz7jWh4724dUF5BqqobB55GMzGDQkbUQOi6fv3r+c=;\n\tb=IxXbgK8nRzwqIjHyVYAHPuqOqBTUvx0iq1yYMQT9tlf8F5ASxnnZL1x0PmgiVmJF0r\n\tuw3S0m1PPsKcN3Goo1rutiZMMkifgQk2k3R027cyd7Gsedh9jHj/3bORrt7KNPRgORX0\n\teJi+h2l4A98wzKeFlfhBCKllU1eCzQD5r5Q3gUrqys7PuHVDumpZk4pTnUM6z+mctCQq\n\t8GUk4MKwM8D/lZ75KUD1IxnbFLyJHmusPBn9bYE/UgesNGa+5MCIf/Wwe/M4YKkNBLOV\n\tE7GC/GQ8I5aCWR2et5UyxgPqKFhcwjHOBAE1a0HJQ0KmptNouJYTDyGAHquuBrTyFDo+\n\t3CYQ==", "X-Gm-Message-State": "AMCzsaUBxj18N/hKDFc5SKtpMbZfxDTq1WhTiOr+AKZdzUSKvKoSx958\n\t0Upm700F2zodZWBZsCGPOyU=", "X-Google-Smtp-Source": "ABhQp+R/Liy9Y+ZAViUjc1eiPMxAHEJK0Ez3EC7Qoa6NVKiOpbghpALBXoimZnfIkmcjn4en4VdFfA==", "X-Received": "by 10.107.102.13 with SMTP id a13mr12183719ioc.185.1508633512572;\n\tSat, 21 Oct 2017 17:51:52 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\takp@cohaesio.com, pstaszewski@itcare.pl", "Date": "Sat, 21 Oct 2017 17:51:50 -0700", "Message-ID": "<20171022005030.19175.91947.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/next-queue PATCH] i40e/i40evf: Revert\n\t\"i40e/i40evf: bump tail only in multiples of 8\"", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis reverts commit 11f29003d6376fb123b7c3779dba49bb56fb0815.\n\nI am reverting this as I am fairly certain this can result in a memory leak\nwhen combined with the current page recycling scheme. Specifically we end\nup attempting to allocate fewer buffers than we recycled and this results\nin us rewinding the next to alloc pointer which leads to leaks when we\noverwrite the rx_buffer_info when processing the next frame.\n\nFixes: 11f29003d637 (\"i40e/i40evf: bump tail only in multiples of 8\")\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 ---------\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 9 ---------\n 2 files changed, 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex edbc94c4353d..487e2f483fa1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1407,15 +1407,6 @@ bool i40e_alloc_rx_buffers(struct i40e_ring *rx_ring, u16 cleaned_count)\n \tunion i40e_rx_desc *rx_desc;\n \tstruct i40e_rx_buffer *bi;\n \n-\t/* Hardware only fetches new descriptors in cache lines of 8,\n-\t * essentially ignoring the lower 3 bits of the tail register. We want\n-\t * to ensure our tail writes are aligned to avoid unnecessary work. We\n-\t * can't simply round down the cleaned count, since we might fail to\n-\t * allocate some buffers. What we really want is to ensure that\n-\t * next_to_used + cleaned_count produces an aligned value.\n-\t */\n-\tcleaned_count -= (ntu + cleaned_count) & 0x7;\n-\n \t/* do nothing if no valid netdev defined */\n \tif (!rx_ring->netdev || !cleaned_count)\n \t\treturn false;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 6806ada11490..fe817e2b6fef 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -711,15 +711,6 @@ bool i40evf_alloc_rx_buffers(struct i40e_ring *rx_ring, u16 cleaned_count)\n \tunion i40e_rx_desc *rx_desc;\n \tstruct i40e_rx_buffer *bi;\n \n-\t/* Hardware only fetches new descriptors in cache lines of 8,\n-\t * essentially ignoring the lower 3 bits of the tail register. We want\n-\t * to ensure our tail writes are aligned to avoid unnecessary work. We\n-\t * can't simply round down the cleaned count, since we might fail to\n-\t * allocate some buffers. What we really want is to ensure that\n-\t * next_to_used + cleaned_count produces an aligned value.\n-\t */\n-\tcleaned_count -= (ntu + cleaned_count) & 0x7;\n-\n \t/* do nothing if no valid netdev defined */\n \tif (!rx_ring->netdev || !cleaned_count)\n \t\treturn false;\n", "prefixes": [ "jkirsher/next-queue" ] }