Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/828346/?format=api
{ "id": 828346, "url": "http://patchwork.ozlabs.org/api/patches/828346/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171019190736.2770-1-jean-philippe.brucker@arm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171019190736.2770-1-jean-philippe.brucker@arm.com>", "list_archive_url": null, "date": "2017-10-19T19:07:36", "name": "igb: Fix TX map failure path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "431130a64ebebc3f5a8ed692576493ea18974ffe", "submitter": { "id": 68357, "url": "http://patchwork.ozlabs.org/api/people/68357/?format=api", "name": "Jean-Philippe Brucker", "email": "Jean-Philippe.Brucker@arm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171019190736.2770-1-jean-philippe.brucker@arm.com/mbox/", "series": [ { "id": 9200, "url": "http://patchwork.ozlabs.org/api/series/9200/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=9200", "date": "2017-10-19T19:07:36", "name": "igb: Fix TX map failure path", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/9200/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/828346/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/828346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJ22j10WSz9t5x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Oct 2017 08:22:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 94D0C88C08;\n\tThu, 19 Oct 2017 21:22:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VtSNqv1UlHHl; Thu, 19 Oct 2017 21:22:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DC3EB88BFA;\n\tThu, 19 Oct 2017 21:22:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B18A51BFBC3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 19:03:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A85C581D92\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 19:03:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UZbTn5TtVhnq for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 19:03:47 +0000 (UTC)", "from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 11FAC81D5F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 19:03:47 +0000 (UTC)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63C39F;\n\tThu, 19 Oct 2017 12:03:46 -0700 (PDT)", "from e106794-lin.cambridge.arm.com (e106794-lin.cambridge.arm.com\n\t[10.1.211.72])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t90D313F58F; Thu, 19 Oct 2017 12:03:45 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Jean-Philippe Brucker <jean-philippe.brucker@arm.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Thu, 19 Oct 2017 20:07:36 +0100", "Message-Id": "<20171019190736.2770-1-jean-philippe.brucker@arm.com>", "X-Mailer": "git-send-email 2.13.3", "X-Mailman-Approved-At": "Thu, 19 Oct 2017 21:22:49 +0000", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] igb: Fix TX map failure path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When the driver cannot map a TX buffer, instead of rolling back\ngracefully and retrying later, we currently get a panic:\n\n[ 159.885994] igb 0000:00:00.0: TX DMA map failed\n[ 159.886588] Unable to handle kernel paging request at virtual address ffff00000a08c7a8\n ...\n[ 159.897031] PC is at igb_xmit_frame_ring+0x9c8/0xcb8\n\nFix the erroneous test that leads to this situation.\n\nSigned-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex fd4a46b03cc8..ea69af267d63 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5326,7 +5326,7 @@ static int igb_tx_map(struct igb_ring *tx_ring,\n \t\t\t\t DMA_TO_DEVICE);\n \t\tdma_unmap_len_set(tx_buffer, len, 0);\n \n-\t\tif (i--)\n+\t\tif (i-- == 0)\n \t\t\ti += tx_ring->count;\n \t\ttx_buffer = &tx_ring->tx_buffer_info[i];\n \t}\n", "prefixes": [] }