Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/828342/?format=api
{ "id": 828342, "url": "http://patchwork.ozlabs.org/api/patches/828342/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171019210700.14788.7976.stgit@ahduyck-green-test.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171019210700.14788.7976.stgit@ahduyck-green-test.jf.intel.com>", "list_archive_url": null, "date": "2017-10-19T21:07:13", "name": "[jkirsher/net-queue] ixgbe: Fix Tx map failure path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9de74c364ed1a358ae925233a26c0ebb07995eff", "submitter": { "id": 251, "url": "http://patchwork.ozlabs.org/api/people/251/?format=api", "name": "Duyck, Alexander H", "email": "alexander.h.duyck@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171019210700.14788.7976.stgit@ahduyck-green-test.jf.intel.com/mbox/", "series": [ { "id": 9197, "url": "http://patchwork.ozlabs.org/api/series/9197/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=9197", "date": "2017-10-19T21:07:13", "name": "[jkirsher/net-queue] ixgbe: Fix Tx map failure path", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/9197/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/828342/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/828342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJ1mn0TDNz9t5x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Oct 2017 08:10:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A440587F36;\n\tThu, 19 Oct 2017 21:10:45 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nGIrlzWJykdZ; Thu, 19 Oct 2017 21:10:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0207887799;\n\tThu, 19 Oct 2017 21:10:45 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D94981C2797\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 21:10:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CE2C8887F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 21:10:43 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id N+eTA9fe79u9 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 21:10:42 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id CA157887CA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Oct 2017 21:10:42 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Oct 2017 14:10:41 -0700", "from ahduyck-green-test.jf.intel.com ([134.134.145.130])\n\tby orsmga004.jf.intel.com with ESMTP; 19 Oct 2017 14:10:31 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.43,403,1503385200\"; d=\"scan'208\";a=\"140173357\"", "From": "Alexander Duyck <alexander.h.duyck@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Thu, 19 Oct 2017 17:07:13 -0400", "Message-ID": "<20171019210700.14788.7976.stgit@ahduyck-green-test.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [jkirsher/net-queue PATCH] ixgbe: Fix Tx map\n\tfailure path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch is a partial revert of \"ixgbe: Don't bother clearing buffer\nmemory for descriptor rings\". Specifically I messed up the exception\nhandling path a bit and this resulted in us incorrectly adding the count\nback in when we didn't need to.\n\nIn order to make this simpler I am reverting most of the exception handling\npath change and instead just replacing the bit that was handled by the\nunmap_and_free call.\n\nFixes: ffed21bcee7a (\"ixgbe: Don't bother clearing buffer memory for descriptor rings\")\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 18 ++++++------------\n 1 file changed, 6 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 901ab12..a408345 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8149,29 +8149,23 @@ static int ixgbe_tx_map(struct ixgbe_ring *tx_ring,\n \treturn 0;\n dma_error:\n \tdev_err(tx_ring->dev, \"TX DMA map failed\\n\");\n-\ttx_buffer = &tx_ring->tx_buffer_info[i];\n \n \t/* clear dma mappings for failed tx_buffer_info map */\n-\twhile (tx_buffer != first) {\n+\tfor (;;) {\n+\t\ttx_buffer = &tx_ring->tx_buffer_info[i];\n \t\tif (dma_unmap_len(tx_buffer, len))\n \t\t\tdma_unmap_page(tx_ring->dev,\n \t\t\t\t dma_unmap_addr(tx_buffer, dma),\n \t\t\t\t dma_unmap_len(tx_buffer, len),\n \t\t\t\t DMA_TO_DEVICE);\n \t\tdma_unmap_len_set(tx_buffer, len, 0);\n-\n-\t\tif (i--)\n+\t\tif (tx_buffer == first)\n+\t\t\tbreak;\n+\t\tif (i == 0)\n \t\t\ti += tx_ring->count;\n-\t\ttx_buffer = &tx_ring->tx_buffer_info[i];\n+\t\ti--;\n \t}\n \n-\tif (dma_unmap_len(tx_buffer, len))\n-\t\tdma_unmap_single(tx_ring->dev,\n-\t\t\t\t dma_unmap_addr(tx_buffer, dma),\n-\t\t\t\t dma_unmap_len(tx_buffer, len),\n-\t\t\t\t DMA_TO_DEVICE);\n-\tdma_unmap_len_set(tx_buffer, len, 0);\n-\n \tdev_kfree_skb_any(first->skb);\n \tfirst->skb = NULL;\n \n", "prefixes": [ "jkirsher/net-queue" ] }