Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/826668/?format=api
{ "id": 826668, "url": "http://patchwork.ozlabs.org/api/patches/826668/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171017010128.22141-2-vinicius.gomes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171017010128.22141-2-vinicius.gomes@intel.com>", "list_archive_url": null, "date": "2017-10-17T01:01:23", "name": "[next-queue,v9,1/6] net/sched: Check for null dev_queue on create flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9492fdaca99c844578fd46826226273604b47cb6", "submitter": { "id": 72272, "url": "http://patchwork.ozlabs.org/api/people/72272/?format=api", "name": "Vinicius Costa Gomes", "email": "vinicius.gomes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171017010128.22141-2-vinicius.gomes@intel.com/mbox/", "series": [ { "id": 8543, "url": "http://patchwork.ozlabs.org/api/series/8543/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=8543", "date": "2017-10-17T01:01:23", "name": "TSN: Add qdisc based config interface for CBS", "version": 9, "mbox": "http://patchwork.ozlabs.org/series/8543/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/826668/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/826668/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yGH2k39vJz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 Oct 2017 12:01:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 110A52F40B;\n\tTue, 17 Oct 2017 01:01:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nDYX3uV3h4L2; Tue, 17 Oct 2017 01:01:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 96B4D27CF9;\n\tTue, 17 Oct 2017 01:01:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id CA4D81CEF32\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 Oct 2017 01:01:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BECC186DB3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 Oct 2017 01:01:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AuhipXyAAj4N for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 Oct 2017 01:01:43 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C0F9286D1D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 Oct 2017 01:01:43 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Oct 2017 18:01:42 -0700", "from ellie.jf.intel.com (HELO localhost.localdomain)\n\t([10.24.13.70])\n\tby fmsmga002.fm.intel.com with ESMTP; 16 Oct 2017 18:01:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.43,389,1503385200\"; d=\"scan'208\";\n\ta=\"1231539026\"", "From": "Vinicius Costa Gomes <vinicius.gomes@intel.com>", "To": "netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 16 Oct 2017 18:01:23 -0700", "Message-Id": "<20171017010128.22141-2-vinicius.gomes@intel.com>", "X-Mailer": "git-send-email 2.14.2", "In-Reply-To": "<20171017010128.22141-1-vinicius.gomes@intel.com>", "References": "<20171017010128.22141-1-vinicius.gomes@intel.com>", "Cc": "rodney.cummings@ni.com, andre.guedes@intel.com, jiri@resnulli.us,\n\tivan.briano@intel.com, richardcochran@gmail.com, henrik@austad.us,\n\tjhs@mojatatu.com, levipearson@gmail.com, boon.leong.ong@intel.com,\n\txiyou.wangcong@gmail.com,\n\tJesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>", "Subject": "[Intel-wired-lan] [next-queue PATCH v9 1/6] net/sched: Check for\n\tnull dev_queue on create flow", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>\n\nIn qdisc_alloc() the dev_queue pointer was used without any checks\nbeing performed. If qdisc_create() gets a null dev_queue pointer, it\njust passes it along to qdisc_alloc(), leading to a crash. That\nhappens if a root qdisc implements select_queue() and returns a null\ndev_queue pointer for an \"invalid handle\", for example, or if the\ndev_queue associated with the parent qdisc is null.\n\nThis patch is in preparation for the next in this series, where\nselect_queue() is being added to mqprio and as it may return a null\ndev_queue.\n\nSigned-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>\n---\n net/sched/sch_generic.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c\nindex a0a198768aad..de2408f1ccd3 100644\n--- a/net/sched/sch_generic.c\n+++ b/net/sched/sch_generic.c\n@@ -603,8 +603,14 @@ struct Qdisc *qdisc_alloc(struct netdev_queue *dev_queue,\n \tstruct Qdisc *sch;\n \tunsigned int size = QDISC_ALIGN(sizeof(*sch)) + ops->priv_size;\n \tint err = -ENOBUFS;\n-\tstruct net_device *dev = dev_queue->dev;\n+\tstruct net_device *dev;\n+\n+\tif (!dev_queue) {\n+\t\terr = -EINVAL;\n+\t\tgoto errout;\n+\t}\n \n+\tdev = dev_queue->dev;\n \tp = kzalloc_node(size, GFP_KERNEL,\n \t\t\t netdev_queue_numa_node_read(dev_queue));\n \n", "prefixes": [ "next-queue", "v9", "1/6" ] }