Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/824430/?format=api
{ "id": 824430, "url": "http://patchwork.ozlabs.org/api/patches/824430/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171011135834.3628155-1-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171011135834.3628155-1-arnd@arndb.de>", "list_archive_url": null, "date": "2017-10-11T13:58:22", "name": "fm10k: mark PM functions as __maybe_unused", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a3f01ee925f8a6b459556bacd27ce7e95b058ebb", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171011135834.3628155-1-arnd@arndb.de/mbox/", "series": [ { "id": 7626, "url": "http://patchwork.ozlabs.org/api/series/7626/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=7626", "date": "2017-10-11T13:58:22", "name": "fm10k: mark PM functions as __maybe_unused", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/7626/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/824430/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/824430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBwZH6R8Rz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 12 Oct 2017 00:59:03 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B5ED02FAE1;\n\tWed, 11 Oct 2017 13:59:01 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eAXtboD+umJs; Wed, 11 Oct 2017 13:59:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D123A2FA97;\n\tWed, 11 Oct 2017 13:59:00 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 11C861C09DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 Oct 2017 13:59:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 98A7D82593\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 Oct 2017 13:58:59 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zLjrxz5DSuOz for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 Oct 2017 13:58:58 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 58B4D82365\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 Oct 2017 13:58:58 +0000 (UTC)", "from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id\n\t0LnpfA-1dMeBj1jey-00fx05; Wed, 11 Oct 2017 15:58:39 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Wed, 11 Oct 2017 15:58:22 +0200", "Message-Id": "<20171011135834.3628155-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "X-Provags-ID": "V03:K0:pomLevAo/euNTGlctXH8ACFSr7t+axpxG29WUZUvI8/20VlYvN6\n\t9gQSvd35F2E5fL/E7S8/XkHUoaOqnVrM66T3lRoONU0B/E52GSs7aZ6sNP6MFB28OtqInrx\n\tihJze1O1NJLHMXKxWOd4H/L8ciaKx+XxW4pofUlXZGL67ftN4zfeW4iXSnlLW2BgULR/ISF\n\tz5tFRH51Yfa0sWdX4g6CA==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:BOO+g973mJ0=:B/Kj5XN65ljK83ipsi6Z4q\n\tp9qnIh1FyaUn+yeu5/KXq9V3LXJRDAUlq1i4qMnXnDIDnbtRxNhA+9GJX1nyqca/GHMKsTsO+\n\tlBWfF2klXKma0qvvSXd0oqwNsBYaqxwJDFfc3enf/ArGM38g4H4/kk3+JNqnrEzmYdEoR+awz\n\tQxTEVmPiKzcxE3+WODhb+D4SaFNtkIT+lpZTX5+YaYJLHug2UXNsMksyZYyzPfK/YnHEIB6Oj\n\t1Vkr8fE6jF7k1HJ4F8k1JHf8h4frjz1zMqGIx7NXAygy8ePWSOaf0gTRNRU71WzyrWHHhzAkr\n\t2lF/nY3gjz+jmCWOH2gLR8pds6L/VyZbWRMnioSvS0Ivt/f23xLVwiKX3iuAooQKCMGeS2C0a\n\tPQxQ0K8seQG4LDwyyMPbdsorrlr/praFdwS9ISvUIrQq+Ql5UNJcLcdrybSxLPKeCGlFRbCn/\n\tVfVuKUHitSwu0eHWvmpGctYsryj2H0WuTo8hHilj83UImA8fEC/JV8vUzCiUOJ5YX5SG5Oe46\n\tLxWLHSL6tDWSbcrk3W921KiUyQlm+6EDPSLAuHFhsjHrwlH594qn67wLzkTfpOXsn8spCKKxy\n\trJ9ZH3o4JYT34Yb33XLbWt9naEQPR6HYiudX6fIlauoIGqio4dZAu1z9+mUr9IDaWaky79rM6\n\tWOE00cxDU7rYfmH6g/IU+Qo2eqpjHUQrd2EE7PK7BLd6sMP5IM9UNQ1WX5sM3/jzKzRblGRZS\n\teWAL7Eg9zbTKUN2X42cStSR+TOgr89wFPZvi5A==", "Cc": "Arnd Bergmann <arnd@arndb.de>, Ngai-Mint Kwan <ngai-mint.kwan@intel.com>,\n\tnetdev@vger.kernel.org, Florian Westphal <fw@strlen.de>,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\t\"David S. Miller\" <davem@davemloft.net>", "Subject": "[Intel-wired-lan] [PATCH] fm10k: mark PM functions as __maybe_unused", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "A cleanup of the PM code left an incorrect #ifdef in place, leading\nto a harmless build warning:\n\ndrivers/net/ethernet/intel/fm10k/fm10k_pci.c:2502:12: error: 'fm10k_suspend' defined but not used [-Werror=unused-function]\ndrivers/net/ethernet/intel/fm10k/fm10k_pci.c:2475:12: error: 'fm10k_resume' defined but not used [-Werror=unused-function]\n\nIt's easier to use __maybe_unused attributes here, since you\ncan't pick the wrong one.\n\nFixes: 8249c47c6ba4 (\"fm10k: use generic PM hooks instead of legacy PCIe power hooks\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 1e9ae3197b17..52f8eb3c470e 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -2463,7 +2463,6 @@ static int fm10k_handle_resume(struct fm10k_intfc *interface)\n \treturn err;\n }\n \n-#ifdef CONFIG_PM\n /**\n * fm10k_resume - Generic PM resume hook\n * @dev: generic device structure\n@@ -2472,7 +2471,7 @@ static int fm10k_handle_resume(struct fm10k_intfc *interface)\n * suspend or hibernation. This function does not need to handle lower PCIe\n * device state as the stack takes care of that for us.\n **/\n-static int fm10k_resume(struct device *dev)\n+static int __maybe_unused fm10k_resume(struct device *dev)\n {\n \tstruct fm10k_intfc *interface = pci_get_drvdata(to_pci_dev(dev));\n \tstruct net_device *netdev = interface->netdev;\n@@ -2499,7 +2498,7 @@ static int fm10k_resume(struct device *dev)\n * system suspend or hibernation. This function does not need to handle lower\n * PCIe device state as the stack takes care of that for us.\n **/\n-static int fm10k_suspend(struct device *dev)\n+static int __maybe_unused fm10k_suspend(struct device *dev)\n {\n \tstruct fm10k_intfc *interface = pci_get_drvdata(to_pci_dev(dev));\n \tstruct net_device *netdev = interface->netdev;\n@@ -2511,8 +2510,6 @@ static int fm10k_suspend(struct device *dev)\n \treturn 0;\n }\n \n-#endif /* CONFIG_PM */\n-\n /**\n * fm10k_io_error_detected - called when PCI error is detected\n * @pdev: Pointer to PCI device\n@@ -2643,11 +2640,9 @@ static struct pci_driver fm10k_driver = {\n \t.id_table\t\t= fm10k_pci_tbl,\n \t.probe\t\t\t= fm10k_probe,\n \t.remove\t\t\t= fm10k_remove,\n-#ifdef CONFIG_PM\n \t.driver = {\n \t\t.pm\t\t= &fm10k_pm_ops,\n \t},\n-#endif /* CONFIG_PM */\n \t.sriov_configure\t= fm10k_iov_configure,\n \t.err_handler\t\t= &fm10k_err_handler\n };\n", "prefixes": [] }