Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/824096/?format=api
{ "id": 824096, "url": "http://patchwork.ozlabs.org/api/patches/824096/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1507672618-396715-1-git-send-email-shannon.nelson@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1507672618-396715-1-git-send-email-shannon.nelson@oracle.com>", "list_archive_url": null, "date": "2017-10-10T21:56:58", "name": "i40e: only redistribute MSI-X vectors when needed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b839c962ab1b5f9cc7d39db32131965175eeab11", "submitter": { "id": 70766, "url": "http://patchwork.ozlabs.org/api/people/70766/?format=api", "name": "Shannon Nelson", "email": "shannon.nelson@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1507672618-396715-1-git-send-email-shannon.nelson@oracle.com/mbox/", "series": [ { "id": 7464, "url": "http://patchwork.ozlabs.org/api/series/7464/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=7464", "date": "2017-10-10T21:56:58", "name": "i40e: only redistribute MSI-X vectors when needed", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/7464/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/824096/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/824096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBWHY2211z9t3R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 11 Oct 2017 08:59:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4A0A189453;\n\tTue, 10 Oct 2017 21:59:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WoQ6w3Vu8C1R; Tue, 10 Oct 2017 21:59:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E45AD8908B;\n\tTue, 10 Oct 2017 21:59:49 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id F3FF11C0C51\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 21:59:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 391D488F88\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 21:59:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3hzQYWUYCXSq for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 21:59:44 +0000 (UTC)", "from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 5635B88F87\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 21:59:44 +0000 (UTC)", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v9ALxe0c012438\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 10 Oct 2017 21:59:41 GMT", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv9ALxdgH010254\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 10 Oct 2017 21:59:40 GMT", "from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv9ALxdmk011158; Tue, 10 Oct 2017 21:59:39 GMT", "from sln75.us.oracle.com (/10.147.27.211)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 10 Oct 2017 14:59:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Shannon Nelson <shannon.nelson@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Tue, 10 Oct 2017 14:56:58 -0700", "Message-Id": "<1507672618-396715-1-git-send-email-shannon.nelson@oracle.com>", "X-Mailer": "git-send-email 1.7.1", "X-Source-IP": "userv0022.oracle.com [156.151.31.74]", "Cc": "netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: only redistribute MSI-X vectors\n\twhen needed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Whether or not there are vectors_left, we only need to redistribute\nour vectors if we didn't get as many as we requested. With the current\ncheck, the code will try to redistribute even if we did in fact get all\nthe vectors we requested - this can happen when we have more CPUs than\nwe do vectors. This restores an earlier check to be sure we only\nredistribute if we didn't get the full count we requested.\n\nFixes: 4ce20abc645f (i40e: fix MSI-X vector redistribution if hw limit is reached)\nSigned-off-by: Shannon Nelson <shannon.nelson@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++--\n 1 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex bf91958..535e6e7 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8176,7 +8176,7 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\tpf->num_lan_qps = 1;\n \t\tpf->num_lan_msix = 1;\n \n-\t} else if (!vectors_left) {\n+\t} else if (v_actual != v_budget) {\n \t\t/* If we have limited resources, we will start with no vectors\n \t\t * for the special features and then allocate vectors to some\n \t\t * of these features based on the policy and at the end disable\n@@ -8185,7 +8185,8 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\tint vec;\n \n \t\tdev_info(&pf->pdev->dev,\n-\t\t\t \"MSI-X vector limit reached, attempting to redistribute vectors\\n\");\n+\t\t\t \"MSI-X vector limit reached with %d, wanted %d, attempting to redistribute vectors\\n\",\n+\t\t\t v_actual, v_budget);\n \t\t/* reserve the misc vector */\n \t\tvec = v_actual - 1;\n \n", "prefixes": [] }