Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/823743/?format=api
{ "id": 823743, "url": "http://patchwork.ozlabs.org/api/patches/823743/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171010081847.4090496-1-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171010081847.4090496-1-arnd@arndb.de>", "list_archive_url": null, "date": "2017-10-10T08:17:38", "name": "i40e: mark PM functions as __maybe_unused", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f97f052de22d73226ad5d36dcf386f5f4b6b4106", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171010081847.4090496-1-arnd@arndb.de/mbox/", "series": [ { "id": 7319, "url": "http://patchwork.ozlabs.org/api/series/7319/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=7319", "date": "2017-10-10T08:17:38", "name": "i40e: mark PM functions as __maybe_unused", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/7319/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/823743/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/823743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yB94k0L2Yz9tXl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 10 Oct 2017 19:19:17 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 32E6387B68;\n\tTue, 10 Oct 2017 08:19:16 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0JOwXW37vunN; Tue, 10 Oct 2017 08:19:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BF5FF879F8;\n\tTue, 10 Oct 2017 08:19:14 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 51F561BFC90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 08:19:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4867987062\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 08:19:13 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jTbcv-Wgghqz for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 08:19:12 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E24FB86E9C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 10 Oct 2017 08:19:11 +0000 (UTC)", "from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id\n\t0MWvbc-1dneuZ3Mc0-00VxXi; Tue, 10 Oct 2017 10:18:55 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 10 Oct 2017 10:17:38 +0200", "Message-Id": "<20171010081847.4090496-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "X-Provags-ID": "V03:K0:8k8t1khesu7P762HJpMxbrZckQaC0ufQa0x1cSh5/DPuPSz+nuM\n\ttFsbHiXiXBT74y+F4bNmQOBY7kPUdw/0SDqInJBsxsOAZu8MxMUjRGRxG7M2HDV0Swj/ckR\n\tIG4WdLqIruvzAtAmhA9K7bwTOlzdjir47rniG1ZMOj9Zs+x1lEMpq2iKoLlJ9/hA9dghVQU\n\t6u+UN00pQNc7x4aB5Zoig==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:Mg7ZTLIu2Nw=:+gLyWUvSNgtujaGgQqFPeA\n\tKcpgzRMpUKRnVLMufE1KN/tmPfD2ypSbuYBw2LcZS+J0YQFJ0oOBttexoDvMVWFTyQhGsZD3F\n\tPsIEvfFKiIPNdZ6NmYIaRTRBcVYmmReYGdoThJJN39r9TPGpgZ61iNnGZ0LPaFqi7yAdtQRj/\n\tS4mDf34K3K3GGltPvetSIffug+Ju/5LMlHqd15O3fqC8mfUrWFGuwmcT6ir/Cl9fI9LbfczKy\n\t9MevkYtmDOfuTcBtpidfzZf2l2GpIqwp7FhbS71DWE0zEoHTEb7BPv4Kivg5VrUHw0MylX6dt\n\tFEn4bEt57fstbmu8xrHgVbxgUrjCwUe0teh9I5S1UAmZ1tFKarzwoYReyv8DbLL39k0TtxKen\n\tpGLeLjyAZLlEWREEI9MQ9KHntdVJE1LBtMtBm+x4oreGtpqbWNNtWz8Mxuk5QlNQW7O8+5fP3\n\tO2HYLwhhCCM+PzVl7/1dl/3JWJkpHKfOzuuB6+6AygGzvyiZecnS0UaBjFs4UKueA74F/h7Hd\n\tdiy/rut4vcPKHJvLyMGMYsbT+PWZTtJXtTeyrpVPdTKWVY7ua1KgVhTJ0DPXTsgSwVr2V5no4\n\tEylEM1Cx8T2ZVUrClbaCWZX24o87daixsW85Pjg6pEzlVEnvqRklONTKGixp5Nvnfm4cs7WKj\n\tG+AaBMQddqLw+bYi7faAGrMjNBUmDrEsuS3PgI5R2KJffDTeIoliCiHYKLUaPsquXl2atlmAe\n\tgKB1wIlNSsPZvrt9vrSFscoeoRYds4y0YCAk0A==", "Cc": "Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,\n\tMitch Williams <mitch.a.williams@intel.com>,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\t\"David S. Miller\" <davem@davemloft.net>", "Subject": "[Intel-wired-lan] [PATCH] i40e: mark PM functions as __maybe_unused", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "A cleanup of the PM code left an incorrect #ifdef in place, leading\nto a harmless build warning:\n\ndrivers/net/ethernet/intel/i40e/i40e_main.c:12223:12: error: 'i40e_resume' defined but not used [-Werror=unused-function]\ndrivers/net/ethernet/intel/i40e/i40e_main.c:12185:12: error: 'i40e_suspend' defined but not used [-Werror=unused-function]\n\nIt's easier to use __maybe_unused attributes here, since you\ncan't pick the wrong one.\n\nFixes: 0e5d3da40055 (\"i40e: use newer generic PM support instead of legacy PM callbacks\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 11 ++---------\n 1 file changed, 2 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 60b11fdeca2d..eb091268bc3c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8370,7 +8370,6 @@ static int i40e_init_interrupt_scheme(struct i40e_pf *pf)\n \treturn 0;\n }\n \n-#ifdef CONFIG_PM\n /**\n * i40e_restore_interrupt_scheme - Restore the interrupt scheme\n * @pf: private board data structure\n@@ -8419,7 +8418,6 @@ static int i40e_restore_interrupt_scheme(struct i40e_pf *pf)\n \n \treturn err;\n }\n-#endif /* CONFIG_PM */\n \n /**\n * i40e_setup_misc_vector - Setup the misc vector to handle non queue events\n@@ -12177,12 +12175,11 @@ static void i40e_shutdown(struct pci_dev *pdev)\n \t}\n }\n \n-#ifdef CONFIG_PM\n /**\n * i40e_suspend - PM callback for moving to D3\n * @dev: generic device information structure\n **/\n-static int i40e_suspend(struct device *dev)\n+static int __maybe_unused i40e_suspend(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct i40e_pf *pf = pci_get_drvdata(pdev);\n@@ -12220,7 +12217,7 @@ static int i40e_suspend(struct device *dev)\n * i40e_resume - PM callback for waking up from D3\n * @dev: generic device information structure\n **/\n-static int i40e_resume(struct device *dev)\n+static int __maybe_unused i40e_resume(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct i40e_pf *pf = pci_get_drvdata(pdev);\n@@ -12252,8 +12249,6 @@ static int i40e_resume(struct device *dev)\n \treturn 0;\n }\n \n-#endif /* CONFIG_PM */\n-\n static const struct pci_error_handlers i40e_err_handler = {\n \t.error_detected = i40e_pci_error_detected,\n \t.slot_reset = i40e_pci_error_slot_reset,\n@@ -12269,11 +12264,9 @@ static struct pci_driver i40e_driver = {\n \t.id_table = i40e_pci_tbl,\n \t.probe = i40e_probe,\n \t.remove = i40e_remove,\n-#ifdef CONFIG_PM\n \t.driver = {\n \t\t.pm = &i40e_pm_ops,\n \t},\n-#endif /* CONFIG_PM */\n \t.shutdown = i40e_shutdown,\n \t.err_handler = &i40e_err_handler,\n \t.sriov_configure = i40e_pci_sriov_configure,\n", "prefixes": [] }