Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/822118/?format=api
{ "id": 822118, "url": "http://patchwork.ozlabs.org/api/patches/822118/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171005215344.2886-14-alan.brady@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20171005215344.2886-14-alan.brady@intel.com>", "list_archive_url": null, "date": "2017-10-05T21:53:43", "name": "[v3,13/14,net-next] i40e: rename 'change' variable to 'autoneg_changed'", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f95e7b14da6ac580848feaf178b71d33b983c87d", "submitter": { "id": 69551, "url": "http://patchwork.ozlabs.org/api/people/69551/?format=api", "name": "Alan Brady", "email": "alan.brady@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20171005215344.2886-14-alan.brady@intel.com/mbox/", "series": [ { "id": 6727, "url": "http://patchwork.ozlabs.org/api/series/6727/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=6727", "date": "2017-10-05T21:53:35", "name": "i40e: refactor ethtool interface", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/6727/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/822118/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/822118/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7RSt1pr5z9t4b\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 6 Oct 2017 08:57:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8C3AE88E44;\n\tThu, 5 Oct 2017 21:57:16 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FU-PnlaUpud0; Thu, 5 Oct 2017 21:57:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3568A88E4D;\n\tThu, 5 Oct 2017 21:57:12 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 526D71CEB29\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 5 Oct 2017 21:57:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4D00E8817B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 5 Oct 2017 21:57:06 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B234VVu0sWjm for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 5 Oct 2017 21:57:05 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id CCD7B8815C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 5 Oct 2017 21:57:05 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Oct 2017 14:56:42 -0700", "from dev1-atbrady.jf.intel.com ([10.165.248.38])\n\tby fmsmga005.fm.intel.com with ESMTP; 05 Oct 2017 14:56:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,482,1500966000\"; d=\"scan'208\";a=\"159384243\"", "From": "Alan Brady <alan.brady@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 5 Oct 2017 14:53:43 -0700", "Message-Id": "<20171005215344.2886-14-alan.brady@intel.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20171005215344.2886-1-alan.brady@intel.com>", "References": "<20171005215344.2886-1-alan.brady@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v3 13/14 net-next] i40e: rename 'change'\n\tvariable to 'autoneg_changed'", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This variable isn't actually very descriptive and makes the code a bit\nconfusing as to what it is being used for. This patch enhances the\nvariable with the longer name, 'autoneg_changed', which makes it clear\nwe are concerned with autoneg changing in this context.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 2c34c82cfc54..17cb58d8d050 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -822,14 +822,14 @@ static int i40e_set_link_ksettings(struct net_device *netdev,\n {\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n \tstruct i40e_aq_get_phy_abilities_resp abilities;\n+\tstruct ethtool_link_ksettings safe_ks;\n+\tstruct ethtool_link_ksettings copy_ks;\n \tstruct i40e_aq_set_phy_config config;\n \tstruct i40e_pf *pf = np->vsi->back;\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_hw *hw = &pf->hw;\n-\tstruct ethtool_link_ksettings safe_ks;\n-\tstruct ethtool_link_ksettings copy_ks;\n+\tbool autoneg_changed = false;\n \ti40e_status status = 0;\n-\tbool change = false;\n \tint timeout = 50;\n \tint err = 0;\n \tu32 autoneg;\n@@ -921,7 +921,7 @@ static int i40e_set_link_ksettings(struct net_device *netdev,\n \t\t\t/* Autoneg is allowed to change */\n \t\t\tconfig.abilities = abilities.abilities |\n \t\t\t\t\t I40E_AQ_PHY_ENABLE_AN;\n-\t\t\tchange = true;\n+\t\t\tautoneg_changed = true;\n \t\t}\n \t} else {\n \t\t/* If autoneg is currently enabled */\n@@ -940,7 +940,7 @@ static int i40e_set_link_ksettings(struct net_device *netdev,\n \t\t\t/* Autoneg is allowed to change */\n \t\t\tconfig.abilities = abilities.abilities &\n \t\t\t\t\t ~I40E_AQ_PHY_ENABLE_AN;\n-\t\t\tchange = true;\n+\t\t\tautoneg_changed = true;\n \t\t}\n \t}\n \n@@ -974,7 +974,7 @@ static int i40e_set_link_ksettings(struct net_device *netdev,\n \t */\n \tif (!config.link_speed)\n \t\tconfig.link_speed = abilities.link_speed;\n-\tif (change || (abilities.link_speed != config.link_speed)) {\n+\tif (autoneg_changed || abilities.link_speed != config.link_speed) {\n \t\t/* copy over the rest of the abilities */\n \t\tconfig.phy_type = abilities.phy_type;\n \t\tconfig.phy_type_ext = abilities.phy_type_ext;\n", "prefixes": [ "v3", "13/14", "net-next" ] }